Message-ID: <353565dd-6802-b0a5-c5d6-3833d3c9eb4f@linaro.org>
Date:   Mon, 6 Mar 2023 11:48:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 01/11] arm64: dts: qcom: drop incorrect cell-index from
 SPMI
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Melody Olvera <quic_molvera@quicinc.com>,
        Souradeep Chowdhury <quic_schowdhu@quicinc.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230305125954.209559-1-krzysztof.kozlowski@linaro.org>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20230305125954.209559-1-krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5.03.2023 13:59, Krzysztof Kozlowski wrote:
> The SPMI controller (PMIC Arbiter)) does not use nor allow 'cell-index'
> property:
> 
>   sm8150-microsoft-surface-duo.dtb: spmi@c440000: Unevaluated properties are not allowed ('cell-index' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/ipq8074.dtsi | 1 -
>  arch/arm64/boot/dts/qcom/msm8976.dtsi | 1 -
>  arch/arm64/boot/dts/qcom/msm8998.dtsi | 1 -
>  arch/arm64/boot/dts/qcom/sc7180.dtsi  | 1 -
>  arch/arm64/boot/dts/qcom/sdm630.dtsi  | 1 -
>  arch/arm64/boot/dts/qcom/sdm845.dtsi  | 1 -
>  arch/arm64/boot/dts/qcom/sm6125.dtsi  | 1 -
>  arch/arm64/boot/dts/qcom/sm8150.dtsi  | 1 -
>  8 files changed, 8 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> index 62d05d740646..f769e63c955c 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> @@ -397,7 +397,6 @@ spmi_bus: spmi@200f000 {
>  			#size-cells = <0>;
>  			interrupt-controller;
>  			#interrupt-cells = <4>;
> -			cell-index = <0>;
>  		};
>  
>  		sdhc_1: mmc@7824900 {
> diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi b/arch/arm64/boot/dts/qcom/msm8976.dtsi
> index 2d360d05aa5e..712f80fc865c 100644
> --- a/arch/arm64/boot/dts/qcom/msm8976.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8976.dtsi
> @@ -809,7 +809,6 @@ spmi_bus: spmi@200f000 {
>  			#size-cells = <0>;
>  			interrupt-controller;
>  			#interrupt-cells = <4>;
> -			cell-index = <0>;
>  		};
>  
>  		sdhc_1: mmc@7824000 {
> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> index adf7258b3269..d450fe69fe33 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> @@ -1993,7 +1993,6 @@ spmi_bus: spmi@800f000 {
>  			#size-cells = <0>;
>  			interrupt-controller;
>  			#interrupt-cells = <4>;
> -			cell-index = <0>;
>  		};
>  
>  		usb3: usb@a8f8800 {
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index ebfa21e9ed8a..51bb0a2f25ef 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -3280,7 +3280,6 @@ spmi_bus: spmi@c440000 {
>  			#size-cells = <0>;
>  			interrupt-controller;
>  			#interrupt-cells = <4>;
> -			cell-index = <0>;
>  		};
>  
>  		sram@146aa000 {
> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> index 5827cda270a0..72d9a12b5e9c 100644
> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> @@ -1189,7 +1189,6 @@ spmi_bus: spmi@800f000 {
>  			#size-cells = <0>;
>  			interrupt-controller;
>  			#interrupt-cells = <4>;
> -			cell-index = <0>;
>  		};
>  
>  		usb3: usb@a8f8800 {
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 479859bd8ab3..dc43e438b64a 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -4924,7 +4924,6 @@ spmi_bus: spmi@c440000 {
>  			#size-cells = <0>;
>  			interrupt-controller;
>  			#interrupt-cells = <4>;
> -			cell-index = <0>;
>  		};
>  
>  		sram@146bf000 {
> diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi
> index 65033227718a..fd577eb705f8 100644
> --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi
> @@ -1134,7 +1134,6 @@ spmi_bus: spmi@1c40000 {
>  			#size-cells = <0>;
>  			interrupt-controller;
>  			#interrupt-cells = <4>;
> -			cell-index = <0>;
>  		};
>  
>  		apps_smmu: iommu@c600000 {
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index fd20096cfc6e..f89abf131e01 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -3935,7 +3935,6 @@ spmi_bus: spmi@c440000 {
>  			#size-cells = <0>;
>  			interrupt-controller;
>  			#interrupt-cells = <4>;
> -			cell-index = <0>;
>  		};
>  
>  		apps_smmu: iommu@15000000 {