Message-ID: <2eb160ff-6d36-54c3-0c72-943b78fe338f@linaro.org>
Date:   Mon, 6 Mar 2023 12:11:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 10/11] arm64: dts: qcom: sc7280: fix EUD port properties
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Melody Olvera <quic_molvera@quicinc.com>,
        Souradeep Chowdhury <quic_schowdhu@quicinc.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230305125954.209559-1-krzysztof.kozlowski@linaro.org>
 <20230305125954.209559-10-krzysztof.kozlowski@linaro.org>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20230305125954.209559-10-krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5.03.2023 13:59, Krzysztof Kozlowski wrote:
> Nods with unit addresses must have also 'reg' property:
> 
>   sc7280-herobrine-crd.dtb: eud@88e0000: ports:port@0: 'reg' is a required property
> 
> Fixes: 0b059979090d ("arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
This could use some newlines, but that's a different topic.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index bdcb74925313..71179182c3b8 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -3593,12 +3593,17 @@ eud: eud@88e0000 {
>  			      <0 0x088e2000 0 0x1000>;
>  			interrupts-extended = <&pdc 11 IRQ_TYPE_LEVEL_HIGH>;
>  			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
>  				port@0 {
> +					reg = <0>;
>  					eud_ep: endpoint {
>  						remote-endpoint = <&usb2_role_switch>;
>  					};
>  				};
>  				port@1 {
> +					reg = <1>;
>  					eud_con: endpoint {
>  						remote-endpoint = <&con_eud>;
>  					};
> @@ -3609,7 +3614,11 @@ eud_con: endpoint {
>  		eud_typec: connector {
>  			compatible = "usb-c-connector";
>  			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
>  				port@0 {
> +					reg = <0>;
>  					con_eud: endpoint {
>  						remote-endpoint = <&eud_con>;
>  					};