Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B020C61DA4 for ; Mon, 6 Mar 2023 11:34:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230005AbjCFLeZ (ORCPT ); Mon, 6 Mar 2023 06:34:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229936AbjCFLeV (ORCPT ); Mon, 6 Mar 2023 06:34:21 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CFBD55593 for ; Mon, 6 Mar 2023 03:34:05 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EEE9213D5; Mon, 6 Mar 2023 03:34:48 -0800 (PST) Received: from [10.1.196.177] (eglon.cambridge.arm.com [10.1.196.177]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A422F3F5A1; Mon, 6 Mar 2023 03:34:01 -0800 (PST) Message-ID: <20f05521-ac9b-b388-393c-274ee4a9c1ee@arm.com> Date: Mon, 6 Mar 2023 11:34:00 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2 14/18] x86/resctrl: Add helpers for system wide mon/alloc capable Content-Language: en-GB To: "Shaopeng Tan (Fujitsu)" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" Cc: Fenghua Yu , Reinette Chatre , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Babu Moger , "shameerali.kolothum.thodi@huawei.com" , D Scott Phillips OS , "carl@os.amperecomputing.com" , "lcherian@marvell.com" , "bobo.shaobowang@huawei.com" , "xingxin.hx@openanolis.org" , "baolin.wang@linux.alibaba.com" , Jamie Iles , Xin Hao , "peternewman@google.com" References: <20230113175459.14825-1-james.morse@arm.com> <20230113175459.14825-15-james.morse@arm.com> From: James Morse In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/01/2023 07:16, Shaopeng Tan (Fujitsu) wrote: >> resctrl reads rdt_alloc_capable or rdt_mon_capable to determine whether any >> of the resources support the corresponding features. >> resctrl also uses the static-keys that affect the architecture's context-switch >> code to determine the same thing. >> >> This forces another architecture to have the same static-keys. >> >> As the static-key is enabled based on the capable flag, and none of the >> filesystem uses of these are in the scheduler path, move the capable flags >> behind helpers, and use these in the filesystem code instead of the static-key. >> >> After this change, only the architecture code manages and uses the static-keys >> to ensure __resctrl_sched_in() does not need runtime checks. >> >> This avoids multiple architectures having to define the same static-keys. > Reviewed-by: Shaopeng Tan Thanks! James