Message-ID: <0a872110-3f38-0744-17f1-74de3e78f84d@linux.intel.com>
Date:   Mon, 6 Mar 2023 14:28:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.8.0
Subject: Re: [PATCH v3 9/9] i2c: designware: Add support for AMDI0020 ACPI ID
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mario Limonciello <mario.limonciello@amd.com>
Cc:     =?UTF-8?B?SmFuIETEhWJyb8Wb?= <jsd@semihalf.com>,
        Grzegorz Bernacki <gjb@semihalf.com>, Rijo-john.Thomas@amd.com,
        Thomas.Lendacky@amd.com, herbert@gondor.apana.org.au,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230303165050.2918-1-mario.limonciello@amd.com>
 <20230303165050.2918-10-mario.limonciello@amd.com>
 <ZAXWzMFBjo57UUa+@smile.fi.intel.com>
From:   Jarkko Nikula <jarkko.nikula@linux.intel.com>
In-Reply-To: <ZAXWzMFBjo57UUa+@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/6/23 14:04, Andy Shevchenko wrote:
> On Fri, Mar 03, 2023 at 10:50:47AM -0600, Mario Limonciello wrote:
>> Cezanne and Skyrim have the same PSP hardware but use a different
>> protocol to negotiate I2C arbitration. To disambiguate this going
>> forward introduce a new ACPI ID to represent the protocol that utilizes
>> a doorbell.
> 
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>> v2->v3:
>>   * Split from earlier patch to standalone
>> ---
>>   drivers/i2c/busses/i2c-designware-amdpsp.c  | 5 +++--
>>   drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
>>   2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-designware-amdpsp.c b/drivers/i2c/busses/i2c-designware-amdpsp.c
>> index 2c671973010d..44b8432458b0 100644
>> --- a/drivers/i2c/busses/i2c-designware-amdpsp.c
>> +++ b/drivers/i2c/busses/i2c-designware-amdpsp.c
>> @@ -101,11 +101,12 @@ static int psp_send_i2c_req_amdi0019(enum psp_i2c_req_type i2c_req_type)
>>   
>>   static int psp_send_i2c_req(enum psp_i2c_req_type i2c_req_type)
>>   {
>> +	const char *hid = acpi_device_hid(ACPI_COMPANION(psp_i2c_dev));
>>   	unsigned long start = jiffies;
>>   	int ret;
>>   
>> -	/* Use doorbell for Skyrim and mailbox for Cezanne */
>> -	if (boot_cpu_data.x86 == 25 && boot_cpu_data.x86_model == 80)
> 
> Ah, in this form it's getting better than I thought!
> 
These removed lines were added by previous patch. I think a bit too 
short lived if the same patchset adds and then removes lines?