Message-ID: <9f3a25be-723c-3be0-94bd-820707c80656@quicinc.com>
Date:   Mon, 6 Mar 2023 18:24:46 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] rcu: Fix rcu_torture_read ftrace event
Content-Language: en-US
To:     Douglas RAILLARD <douglas.raillard@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        "open list:TRACING" <linux-kernel@vger.kernel.org>,
        "open list:TRACING" <linux-trace-kernel@vger.kernel.org>
References: <20230306122744.236790-1-douglas.raillard@arm.com>
From:   Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <20230306122744.236790-1-douglas.raillard@arm.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3/6/2023 5:57 PM, Douglas RAILLARD wrote:
> From: Douglas Raillard <douglas.raillard@arm.com>
> 
> Fix the rcutorturename field so that its size is correctly reported in
> the text format embedded in trace.dat files. As it stands, it is
> reported as being of size 1:
> 
>      field:char rcutorturename[8];   offset:8;       size:1; signed:0;
> 
> Signed-off-by: Douglas Raillard <douglas.raillard@arm.com>
> ---
>   include/trace/events/rcu.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/rcu.h b/include/trace/events/rcu.h
> index 90b2fb0292cb..012fa0d171b2 100644
> --- a/include/trace/events/rcu.h
> +++ b/include/trace/events/rcu.h
> @@ -768,7 +768,7 @@ TRACE_EVENT_RCU(rcu_torture_read,
>   	TP_ARGS(rcutorturename, rhp, secs, c_old, c),
>   
>   	TP_STRUCT__entry(
> -		__field(char, rcutorturename[RCUTORTURENAME_LEN])
> +		__array(char, rcutorturename, RCUTORTURENAME_LEN)

Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>

-Mukesh

>   		__field(struct rcu_head *, rhp)
>   		__field(unsigned long, secs)
>   		__field(unsigned long, c_old)