Date:   Mon, 6 Mar 2023 14:55:26 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc:     Mario Limonciello <mario.limonciello@amd.com>,
        Jan =?utf-8?B?RMSFYnJvxZs=?= <jsd@semihalf.com>,
        Grzegorz Bernacki <gjb@semihalf.com>, Rijo-john.Thomas@amd.com,
        Thomas.Lendacky@amd.com, herbert@gondor.apana.org.au,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 9/9] i2c: designware: Add support for AMDI0020 ACPI ID
Message-ID: <ZAXiviOdddEK/Pak@smile.fi.intel.com>
References: <20230303165050.2918-1-mario.limonciello@amd.com>
 <20230303165050.2918-10-mario.limonciello@amd.com>
 <ZAXWzMFBjo57UUa+@smile.fi.intel.com>
 <0a872110-3f38-0744-17f1-74de3e78f84d@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0a872110-3f38-0744-17f1-74de3e78f84d@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Mar 06, 2023 at 02:28:05PM +0200, Jarkko Nikula wrote:
> On 3/6/23 14:04, Andy Shevchenko wrote:
> > On Fri, Mar 03, 2023 at 10:50:47AM -0600, Mario Limonciello wrote:
> > > Cezanne and Skyrim have the same PSP hardware but use a different
> > > protocol to negotiate I2C arbitration. To disambiguate this going
> > > forward introduce a new ACPI ID to represent the protocol that utilizes
> > > a doorbell.

...

> > > -	if (boot_cpu_data.x86 == 25 && boot_cpu_data.x86_model == 80)
> > 
> > Ah, in this form it's getting better than I thought!
> > 
> These removed lines were added by previous patch. I think a bit too short
> lived if the same patchset adds and then removes lines?

That what I have missed. Okay, coming to square 1, i.e. dropping CPU ID
completely from the series.

Note, for testing purposes you may always add a HACK patch at the end of the
series, marking it respectively. So, people may test it all and maintainer
apply w/o unneeded tail.

-- 
With Best Regards,
Andy Shevchenko