Date:   Mon, 6 Mar 2023 09:01:32 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc:     "Tian, Kevin" <kevin.tian@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Will Deacon <will@kernel.org>,
        David Woodhouse <dwmw2@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "Luck, Tony" <tony.luck@intel.com>,
        "Zanussi, Tom" <tom.zanussi@intel.com>
Subject: Re: [PATCH 3/4] iommu/sva: Support reservation of global PASIDs
Message-ID: <ZAXkLN39VUSl+t65@nvidia.com>
References: <20230302005959.2695267-1-jacob.jun.pan@linux.intel.com>
 <20230302005959.2695267-4-jacob.jun.pan@linux.intel.com>
 <BN9PR11MB52765C5E0DC0759880C08E258CB29@BN9PR11MB5276.namprd11.prod.outlook.com>
 <20230303134753.660d0755@jacob-builder>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230303134753.660d0755@jacob-builder>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QJU2iEoep1yQKqybkbppbwGcLgmKbYLno5q7DST5SMJjebvX5twy+8LioS4S?=
 =?us-ascii?Q?TJoMe8eojrB56b7FX9I/P6UrOEWWCfWBy7lwKza18SxDJQ+TFSie1LTyNOor?=
 =?us-ascii?Q?PBomum4G0IhJqZSt86bOj9C4PBNBJgK60erkRCZ8bMAYwDlCWbA1Cn2es1NN?=
 =?us-ascii?Q?UFpCJP8X1DmQDm46GgFHdEy/f+s8kXKAat8Dd6AJVLDjxCf9GpPYP8Dg/iuI?=
 =?us-ascii?Q?HrWCvXfHB2lwcpfTOf3NHOpDy4cAEfQfiXGk119vb5w0oPu5wmPTDAdH5tMj?=
 =?us-ascii?Q?RWikBdhvCaY/EKw8FLBSZljuUXcTIQe1xj4aoaonkw1dja3NkwSp7hN68N00?=
 =?us-ascii?Q?InMCBb0UPW6KzPVFSFPfJK9qc7OOXYfIyz6ZQXuzhoGsPj8WmMetKnYiRSa1?=
 =?us-ascii?Q?/zP+2jbHyFtFG52E5oYOfnwKZ7ZXQjarRqeQclCwDhgVyGrT/jWanSWrf1E5?=
 =?us-ascii?Q?f4RU9C3qZET0WBaRXVzmwSuFlg0GeG2i4l5OEydYR2p0oZArCfGVb9k+Crh2?=
 =?us-ascii?Q?ZstzwWV2zxUpk6+exAVG3QjMFzoH0PYwfsakEb/e3wCljsQOXu+nMFCjC/56?=
 =?us-ascii?Q?1RHoEp4mq3GFVC74EFLcylpEC3Ddbyb64BkQP7YW+Y7/jCcObqgkLgtJet3p?=
 =?us-ascii?Q?XA03DyYwVp8Lsy1hir4FnzVO5fx03lwLBIxgTdwTRC7Hu5rqBhONHL7kprGd?=
 =?us-ascii?Q?7EuGIsOTeojkmKR/PDE2mQnF0im0ITXqtKL8fcsCpJUUE3SN2YrGeMZj9fd7?=
 =?us-ascii?Q?6RA0rJj2RDlG+FYOFc6hGv8Jo2mkGXS8dJe7mlV2GNqMDicIZJLuOXZe7Zp8?=
 =?us-ascii?Q?xxrweKKO6bpH7DWJ1dkFfbayV/qR7LHz2OTGpRisLsE8SOc2VyMqX+ZhQUl5?=
 =?us-ascii?Q?23VK5b3UA4jaMRBsQkUt7wCSs+3yYgNBASvY7FjF2zdFiavPMuKA9FoBzBdO?=
 =?us-ascii?Q?ekGJXpqf5a7wj3mb+EAumXKu/dBmjOU4uXamaopxCOSVwr2fjNkv8/Mrf2ZF?=
 =?us-ascii?Q?d0XOfFFWmGY2g8dHqnRyp/JKxYr2gzv6p8P5qCGZAA1M7nEyTcL8EmiH4sNg?=
 =?us-ascii?Q?BpTbJN2nGi08+ZcgiZHx1Qht3NqDcfNMPHfnG+MLBIdM1Q80y//NDNxcL56e?=
 =?us-ascii?Q?tbVDa95FRHXhz3zQR3Llyxh96eZ3Kl0tdr4A+mYSfRl2PGSgE37KTUr2qi3m?=
 =?us-ascii?Q?od+Zap0/vyjmibUTUncehApoBGOXclZeX+yZ46E+Y0kD+0r8tTKlAeKLL8lR?=
 =?us-ascii?Q?NhySrp4vBFHBnA2BnGYq9iNdtHelFtTzSt9ufxxNmVh1FR7P+cHmfPwM3L1t?=
 =?us-ascii?Q?0SYzElJF/rBgIV8acAb/m6Y/+edWDRHuCGOYKOkRA12RVdXOCQ8bKlDh763C?=
 =?us-ascii?Q?GJtHwtCVTvoiefda+SxXbq/XZIlKKGxdRKzWgfTwgCeu4AnoTsZlNFuYvaAv?=
 =?us-ascii?Q?PBdRrpwqJAxXP0WVyCcWuj54mELAZUpc/x/knD+mHGE6ww6pJESy/G4kxdma?=
 =?us-ascii?Q?z8Rj6NQsK41LOFAvPI7dh4E9aGHzVx/b+hEI/AMkmH18QkOOPEeovlUNAvRn?=
 =?us-ascii?Q?TJUaS5i61bKdmC9+J++G7+WYW04E6sDlXxeCkvhV?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19959cc2-23ef-4c27-c43b-08db1e42ea80
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2023 13:01:35.6070
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7bYvvQtBNIfhA4nUm83tuznkeVcHYodgVs9yXVOsPawiaWU0A3ggeKVUEpmBtK/J
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6837
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 03, 2023 at 01:47:53PM -0800, Jacob Pan wrote:
> Hi Kevin,
> 
> On Thu, 2 Mar 2023 09:43:03 +0000, "Tian, Kevin" <kevin.tian@intel.com>
> wrote:
> 
> > > From: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > > Sent: Thursday, March 2, 2023 9:00 AM
> > > 
> > > Global PASID allocation is under IOMMU SVA code since it is the primary
> > > use case.  However, some architecture such as VT-d, global PASIDs are
> > > necessary for its internal use of DMA API with PASID.  
> > 
> > No, global PASID is not a VT-d restriction. It's from ENQCMD/S hence a
> > device requirement.
> I meant VT-d based platforms, it is kind of intertwined in that ENQCMDS
> does not restrict RIDPASID!=DMA PASID, vt-d does. Without this
> restriction, there wouldn't be a need for this patch. Let me reword.

No, Kevin is right, there is nothing about VT-d that needs global
PASID values.

The driver should be managing RID2PASID itself to avoid conflicting
with any in-use PASID, either by changing RID2PASID on demand or by
setting it to a value that is not part of the PASID number space, eg
we can make 0 entirely invalid, or the driver can reduce max_pasid of
the devices it controls and use PASID_MAX.

Jason