Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0EFFC6FD1B for ; Mon, 6 Mar 2023 13:31:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231194AbjCFNbL (ORCPT ); Mon, 6 Mar 2023 08:31:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229861AbjCFNbH (ORCPT ); Mon, 6 Mar 2023 08:31:07 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D22F92E816; Mon, 6 Mar 2023 05:31:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6BB7060EA7; Mon, 6 Mar 2023 13:31:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB3B0C433EF; Mon, 6 Mar 2023 13:31:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678109464; bh=PDxyfh9GHMbzLUrz8oTviZIgmt7uMmsCk/rf8ALQYc4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=upOM5hJF7UWkvjo7vYwexQOjCdV0rEZ2b+EF6JqmhjVnmQs1N0Oswfxb9fRsWczZd yTRhNbbO9d56vIpIEtSvTS2KyJLqZMnwF8bL2uBal36UoebQK5i4ywwSXCE9U2NcbX hNIExKqj9a4N5MdFIKWW+QTrzUywgyLpV4vfS3AKggppPsB2azyZ24FemR15ANH9Su +EeIzLQWFb9NtmVs2idMOvVfMvGnl4gw1DVQsvnFczPzC2xKzf7yFauzNNns/wo+Az bS6e8dgDY5hk6pB+BJoWMh5aW2WEeC6CZ7D0VLoAZwCATO1WZBK9VqP6A4GsBdwtRo 6QYUpPRA02nZg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pZAwK-00031b-Jh; Mon, 06 Mar 2023 14:31:45 +0100 Date: Mon, 6 Mar 2023 14:31:44 +0100 From: Johan Hovold To: Dmitry Baryshkov Cc: Johan Hovold , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/10] drm/msm: use drmm_mode_config_init() Message-ID: References: <20230306100722.28485-1-johan+linaro@kernel.org> <20230306100722.28485-10-johan+linaro@kernel.org> <26986caf-1245-88f2-60d0-5930c86ea31b@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26986caf-1245-88f2-60d0-5930c86ea31b@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 06, 2023 at 02:38:37PM +0200, Dmitry Baryshkov wrote: > On 06/03/2023 12:07, Johan Hovold wrote: > > Switch to using drmm_mode_config_init() so that the mode config is > > released when the last reference to the DRM device is dropped rather > > than unconditionally at unbind() (which may be too soon). > > This also means that drm_bridge_detach() might be called at some point > after unbind(), which might be too late. Indeed. Please disregard this patch. It's not needed to fix the bind error paths anyway. Johan