Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4481C678D4 for ; Mon, 6 Mar 2023 14:03:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230129AbjCFODQ (ORCPT ); Mon, 6 Mar 2023 09:03:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230008AbjCFODM (ORCPT ); Mon, 6 Mar 2023 09:03:12 -0500 Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6983C1B540 for ; Mon, 6 Mar 2023 06:03:10 -0800 (PST) Received: by mail-yb1-xb34.google.com with SMTP id e194so8202088ybf.1 for ; Mon, 06 Mar 2023 06:03:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678111389; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=aeI0dDbLr4/ACidaziQGMHF31Y6IixUFDfRpx8Mx/wA=; b=vK9FaEHCdgDzRu4DjPJWTQBw0ym3gDa0yjQqQCnqBt7ZdX2V3YknYc0TXVHSTIdTCs qc7ONVmFDXY7QUiQ94S/jiXwKX8qVGnMzxPlDbS1V0fMZm/jN7bIQ8qju3NkxY723rue Y7hIZb83V+L80LmBAcUuaZyC1DAXPpQGGWS2+jsN9l8ZCwZ0sCyABzVCLUs86RCwf7Hl JrAgfwV7cilq74XuMQcLbg/v+/+/Beo/pxO+lCshsMcu08+UZ3WYGEzk4V6H38StpixM c8DaUFlFVbVVM+e5qZEBCe23aWnqz/o2WWxXP+Sa3x8+9pOr6cpYrOl4CKNmRCpYpURC VVhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678111389; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aeI0dDbLr4/ACidaziQGMHF31Y6IixUFDfRpx8Mx/wA=; b=xyWFvzOfN8CHnJ4LKTWv2yAc2b7TZXGFooNeo4k5MyO9MMIhMPtspLoWefNg2Nno+S GF6XqOIpFvP1Rf5wB6hSziHdlWpQ074f9qHmTw1UfB64tFRrM8wLirN6aoohwcd+nD+v w1GVFmhsArtgWhVEcKWngZcs3PrSI95xBU5KCYjfuEd4BqVxrr7+a5CAC44cynyZmi11 2X8lLP6drUYzdsk429VgmmIyrv9dEa1q0/4OUqh0e6xpFZDnOCGGGnaTVqrgSn255rCx HKhrFVEnt+kv8QFVNK+1b/YmG71gz1M2FsB5jgUm8jMi6VdcL7iTxELqsYZXAtXp3K1S wBJg== X-Gm-Message-State: AO0yUKX+mHdZAo3oo2QOPc7VYMviwCtuAYitlmxs4zH9c12ah8KgzFP+ ibz2NMq5W0HxVGLXkcXqFNzaB15KSUx+HAyJQTG4pw== X-Google-Smtp-Source: AK7set/HdjPVX0qQf6R2XKUSVQlV3OuX7y4xtLBkiSFmdlwUeEep/Nd0dxjJM+J54cyXaepI50nVK56Wpi2U6362WPI= X-Received: by 2002:a05:6902:4f4:b0:a06:5ef5:3a82 with SMTP id w20-20020a05690204f400b00a065ef53a82mr4989421ybs.5.1678111389438; Mon, 06 Mar 2023 06:03:09 -0800 (PST) MIME-Version: 1.0 References: <20230225140118.2037220-1-xiang.ye@intel.com> <20230225140118.2037220-3-xiang.ye@intel.com> In-Reply-To: <20230225140118.2037220-3-xiang.ye@intel.com> From: Linus Walleij Date: Mon, 6 Mar 2023 15:02:58 +0100 Message-ID: Subject: Re: [PATCH v2 2/5] gpio: Add support for Intel LJCA USB GPIO driver To: Ye Xiang , Andy Shevchenko Cc: Lee Jones , Wolfram Sang , Tyrone Ting , Mark Brown , Bartosz Golaszewski , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org, srinivas.pandruvada@intel.com, heikki.krogerus@linux.intel.com, sakari.ailus@linux.intel.com, zhifeng.wang@intel.com, wentong.wu@intel.com, lixu.zhang@intel.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 25, 2023 at 3:01 PM Ye Xiang wrote: > This patch implements the GPIO function of Intel USB-I2C/GPIO/SPI adapter > device named "La Jolla Cove Adapter" (LJCA). It communicate with LJCA > GPIO module with specific protocol through interfaces exported by LJCA USB > driver. > > Signed-off-by: Ye Xiang Looks good to me, also looks like a really helpful adapter. Reviewed-by: Linus Walleij I would appreciate if Andy could ACK it too, as Intel engineer. Yours, Linus Walleij