Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758021AbXIMPKx (ORCPT ); Thu, 13 Sep 2007 11:10:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753170AbXIMPKp (ORCPT ); Thu, 13 Sep 2007 11:10:45 -0400 Received: from terminus.zytor.com ([198.137.202.10]:51503 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbXIMPKo (ORCPT ); Thu, 13 Sep 2007 11:10:44 -0400 Message-ID: <46E952D8.2000203@zytor.com> Date: Thu, 13 Sep 2007 08:10:16 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.0 (X11/20070419) MIME-Version: 1.0 To: Jan Engelhardt CC: Bill Nottingham , linux-kernel@vger.kernel.org Subject: Re: [PATCH] add CONFIG_VT_UNICODE References: <20070831201820.GF31970@nostromo.devel.redhat.com> In-Reply-To: X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1001 Lines: 27 Jan Engelhardt wrote: > On Aug 31 2007 16:18, Bill Nottingham wrote: >> As of now, the kernel defaults to non-unicode and XLATE for the keyboard. >> We've been changing this in Fedora, but that requires patching the defaults >> in the kernel. >> >> The attached introduces CONFIG_VT_UNICODE, which sets the console in unicode >> mode by default on boot, including both the virtual terminal and the keyboard >> driver. > > I would prefer to: > - make default_utf=1 in the source > - add "default_utf8 ? VC_UNICODE : VC_XLATE" to the keyboard code > as your patch does > - and do away with the new CONFIG_ option, since, surprise, surprise, > you can change it at runtime, so there is no need to do it > at compile-time too. > I concur. -hpa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/