Message-ID: <d086da44-5027-4b43-bd04-29e030e7eac7@intel.com>
Date:   Mon, 6 Mar 2023 15:47:54 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH RESEND net-next v4 0/4] net/mlx5e: Add GBP VxLAN HW
 offload support
Content-Language: en-US
To:     Gavin Li <gavinl@nvidia.com>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <roopa@nvidia.com>,
        <eng.alaamohamedsoliman.am@gmail.com>, <bigeasy@linutronix.de>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <gavi@nvidia.com>, <roid@nvidia.com>, <maord@nvidia.com>,
        <saeedm@nvidia.com>
References: <20230306030302.224414-1-gavinl@nvidia.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230306030302.224414-1-gavinl@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2ZHTUpBTFhBckF1Z1c4MFd0ZHJpNmltS1VOTDRNN1U2WlpKNGxtSWRZbDlz?=
 =?utf-8?B?emZKWmtUblR1MXI2KzR4Z0lPbW9pbXpYQy9QbjMyd0ZMSGpwN3hjS0lkQi9H?=
 =?utf-8?B?Uml4ZHU4M3hRNkRtcnJidmErK2tRTUE0MVIzMXVISktwajdiVUV6SmlMSGJY?=
 =?utf-8?B?L3hqZmZjRnErSVp6SnRkK3dNemlvOUtOUXBCMmRSZXJNVXVXd1ZYa3JOQ01o?=
 =?utf-8?B?L3FsVWxSVUxJdFlDSWZzbXpEYTFzbHBXczBPT25Za0xseFdMaVk0V2F6Nldu?=
 =?utf-8?B?TUJXK1A4bnd3SGkwK1huc29YTVprSlpoMnBranN3b2prNlZUK29uYkpEdnlB?=
 =?utf-8?B?dWd2TkhsVHZzYXo4bXZBQ1RYZEZGNmJ6OXV0NFNJK3RxR1RyRFcweFFxWXhX?=
 =?utf-8?B?WDArYkxud2ZtZG5qZzhXWWQ2UmZDSW91TVhPM2ZzRk9PS3RHdHlqaGFTazh5?=
 =?utf-8?B?YnRjdkpOU2NXeW5Ob09mSlZDK21QSEZiOFVOQWFlRXVNaFFNT0V5T2tHNWtq?=
 =?utf-8?B?U0JHSXlYQzRSbW1CT2FJYzdHQUVMQXZHK0Z1dmdnT3RGdjRRM3RPdDRYdGdl?=
 =?utf-8?B?WXlUbS9YMERLQ3QyV2pNQzROc0pETUpBMHlsNnRDRTk1ZFpaczhucDdqK2ZK?=
 =?utf-8?B?WFJmSk9pOUpmU3dLRXBpVmw4QVB4a1E0alFqcTl5V3FFNEJ5V1Y0UUkyY252?=
 =?utf-8?B?UVVFWGZiNXZvZ3hqOUxhRnB0Zkw1VUhVWDFDVlJaWTY2RllHTDBtRkxYTS83?=
 =?utf-8?B?ekNuWU5aN3VqWXJ2TmcwNEFMWmY3bm5UazgyWVBEY2pTTWhFcC9yS1RoVEtY?=
 =?utf-8?B?YS9UZnoyWWYzT3pwNmtqdzVycGZFZzBFTjh5eTJCL1Y3QlZuMlp3MXUwRjk4?=
 =?utf-8?B?cmcvNVNONUd2MG5zeGh1V0hnUFFuSGRXV2tISG5VZmI0TjBldlFWM2ZrVzh5?=
 =?utf-8?B?L1FrQWhkRG9QUW5ydlRNZ2NDQVpRemtBSHJTRDFVUnR6enBWNDhFOU51ZmZZ?=
 =?utf-8?B?cTd3T3d1cnI4RUl2R2t3RzhkZ0YwMytxMUJjSVNaVHFydzhWRTNEdytDa1JD?=
 =?utf-8?B?dzFZemhVNWphSS8xWUYraTZILy9ZYmFiamVCTE94RHhNbXNDOUdyV3hMTnJj?=
 =?utf-8?B?MC9sZXFsNnczNG5lUWc3QzVjZTVrQTlZOVdFMmtuOWp1M2x0bFFRcXkrZzZW?=
 =?utf-8?B?dUlHeXRvcGd2d0xGeGUzaHczVjJOWDE4NVB0VGJrUVJZK3VxYklvTkw1bG5v?=
 =?utf-8?B?dG1tQStBN1JrYnV1YXNxa2ZpcVQzMk5ZV3JhdC9WL2JsOWVEQzQ4KzNPQkRM?=
 =?utf-8?B?UUw5QXpkL2RuQ0VUQ2FveVk1SkR6cXRrTVV1aThmK3cySmZFVGhoc1RRM1Ux?=
 =?utf-8?B?V0VuZjVUYzduSWJaaWhseFhXbmhGN2p5R3RBS2dJVTZ4aW9RU0RsclFKY3pJ?=
 =?utf-8?B?eThIQVlteUpyb1FNYk9HZTg3Yk9UN3p3U1h4czFrUHU4THhZcXlJOWtPOHhh?=
 =?utf-8?B?bStmMGZFTGhlY2Fnb0VlTi82dHc0K2J3Ky9LTHhJZ29vN3Jsbk9kSEV1Z2U0?=
 =?utf-8?B?SXFNMEN5WGR5aitRZTJjUmNmNmJRemMxZUR6Szlya0VNQlNxUitXUElNYy80?=
 =?utf-8?B?eTBTU2ZOOUo4c3N0Q2VnOGF2eGJrYytJelhNWG05b1FxWmtrSENIUis3OWls?=
 =?utf-8?B?UVVmditpWmFqNHcxVkpZWkgwOXhLQ1d0aTQwOW53Nk4rQTdqc04zYjZOd1hz?=
 =?utf-8?B?SlR2VnBIa0lLanR6V2dBSkc0aFhaaFNCc0tXNlVlVmZldm5OTjA0cE02MEpT?=
 =?utf-8?B?VDlhd0wrditNeU9uTVZueEVmTDNkUFNQcW43THN1OEVKRGVmQkxlWFprQ0hs?=
 =?utf-8?B?am5QQURxQWxMVWNSUklnclNXbHRJdGFRN2pZWTJ3UmlwNHVvWVVIczF6ZldM?=
 =?utf-8?B?eFkwOE9vVVFYeGd4QzBoWTBGa2svRURiNXZJMmE2TVk4SldrM1VRZlRCWDYz?=
 =?utf-8?B?QXN4cTlIR2ZpV1Nac085VUI4RGQzSEVGb205c1pzYzZlNWxINVhIWkVXeFVn?=
 =?utf-8?B?OWx2bkJSVUx6Z1dBbW5YODdrZFNIOFhRWXFLSEFVZFF2K0pqT0FPTHRhdFE3?=
 =?utf-8?B?WWJ2RkROQUlLSjNQSnBac2J6VWRESEFhL1V1QnFubDQ3V0ErUE8xOG0xRFhn?=
 =?utf-8?Q?UVdSt7b0dx6VLnE+roA1nIU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 242150cc-1c47-4cc4-0a8f-08db1e51f5ce
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2023 14:49:17.0818
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dtQKbB4J64vyQHA9WX+Z+SYDaF9NlJdxXvLPF6niCH8cJyqqXwdtdTz/KvNktHv6V1DDnczZC/BeYELvLiTxGzoXbDzxJO+UBSKHmkz8qA8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6872
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Gavin Li <gavinl@nvidia.com>
Date: Mon, 6 Mar 2023 05:02:58 +0200

> Patch-1: Remove unused argument from functions.
> Patch-2: Expose helper function vxlan_build_gbp_hdr.
> Patch-3: Add helper function for encap_info_equal for tunnels with options.
> Patch-4: Add HW offloading support for TC flows with VxLAN GBP encap/decap
>         in mlx ethernet driver.
> 
> Gavin Li (4):
>   vxlan: Remove unused argument from vxlan_build_gbp_hdr( ) and
>     vxlan_build_gpe_hdr( )
> ---
> changelog:
> v2->v3
> - Addressed comments from Paolo Abeni
> - Add new patch
> ---
>   vxlan: Expose helper vxlan_build_gbp_hdr
> ---
> changelog:
> v1->v2
> - Addressed comments from Alexander Lobakin
> - Use const to annotate read-only the pointer parameter
> ---
>   net/mlx5e: Add helper for encap_info_equal for tunnels with options
> ---
> changelog:
> v3->v4
> - Addressed comments from Alexander Lobakin
> - Fix vertical alignment issue
> v1->v2
> - Addressed comments from Alexander Lobakin
> - Replace confusing pointer arithmetic with function call
> - Use boolean operator NOT to check if the function return value is not zero
> ---
>   net/mlx5e: TC, Add support for VxLAN GBP encap/decap flows offload
> ---
> changelog:
> v3->v4
> - Addressed comments from Simon Horman
> - Using cast in place instead of changing API

I don't remember me acking this. The last thing I said is that in order
to avoid cast-aways you need to use _Generic(). 2 times. IIRC you said
"Ack" and that was the last message in that thread.
Now this. Without me in CCs, so I noticed it accidentally.
???

> v2->v3
> - Addressed comments from Alexander Lobakin
> - Remove the WA by casting away
> v1->v2
> - Addressed comments from Alexander Lobakin
> - Add a separate pair of braces around bitops
> - Remove the WA by casting away
> - Fit all log messages into one line
> - Use NL_SET_ERR_MSG_FMT_MOD to print the invalid value on error
> ---
> 
>  .../ethernet/mellanox/mlx5/core/en/tc_tun.h   |  3 +
>  .../mellanox/mlx5/core/en/tc_tun_encap.c      | 32 ++++++++
>  .../mellanox/mlx5/core/en/tc_tun_geneve.c     | 24 +-----
>  .../mellanox/mlx5/core/en/tc_tun_vxlan.c      | 76 ++++++++++++++++++-
>  drivers/net/vxlan/vxlan_core.c                | 27 +------
>  include/linux/mlx5/device.h                   |  6 ++
>  include/linux/mlx5/mlx5_ifc.h                 | 13 +++-
>  include/net/vxlan.h                           | 19 +++++
>  8 files changed, 149 insertions(+), 51 deletions(-)
> 

Thanks,
Olek