Date:   Mon, 6 Mar 2023 15:51:28 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Jason Xing <kerneljasonxing@gmail.com>
Cc:     willemdebruijn.kernel@gmail.com, davem@davemloft.net,
        dsahern@kernel.org, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
        Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH v2 net-next] udp: introduce __sk_mem_schedule() usage
Message-ID: <ZAX98D91HvKrJBCO@corigine.com>
References: <20230306115745.87401-1-kerneljasonxing@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230306115745.87401-1-kerneljasonxing@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dYwfMedUrknaE2btRhKvADiRFzeoTrMWDLuePRCGDscjSW11ZKETHb3yMzdd?=
 =?us-ascii?Q?gcOxu/94TEFXuZ0aABmcXVJo952sqizqsPn+J5rXp87WorXo9BKxb42k6SyV?=
 =?us-ascii?Q?jgj00Y2PVeC2VpeUl8hb3tN81StFAjq8nDroH7j826Unk1iYffWDdaAW9OKV?=
 =?us-ascii?Q?MpxA9eg6dYaymzHPBlj9rduFSTzc0oLsbSZo3yxxq7y9ng0W4xeiS6U6S53a?=
 =?us-ascii?Q?X0WEed1dMN+OEHTE7MEFdF3OKEYdQBE0fXaLbh8Ca1Dd9i7ujQKYxxaYP3CZ?=
 =?us-ascii?Q?XYdpZEjO++wkuywZ37k6dNF0mMrUe4Qly6J9RL0mzMeDfceknp+Xd60q5BR9?=
 =?us-ascii?Q?L+ugz+72nLtQkHGWWHxGOdMPSxJtI6NZlamqFY4M4H7o6CXzHGNlk3JSRAyO?=
 =?us-ascii?Q?TF0QUDY9Hy8XRRckOO3mYzKf7DVaL877EY4nfyd7Z/L49s72G07xC/bcdsQt?=
 =?us-ascii?Q?A47224hZfstAqZHM30slyS3aBbVGElEELEv/d/FOZWbNEVgOba5WLrIgULvZ?=
 =?us-ascii?Q?3TXFR/cC9khGjpuDz+IqUSI2eKN3sk51aW+zUkkp3PTvJnubKlhCOdFSLjht?=
 =?us-ascii?Q?ORF7xaoXNO1jKmG6KgJmmJt5oQRl8Blsj7FKIsXA2HGVmQcNwPW6F+RqbEtI?=
 =?us-ascii?Q?fRYuXfullN21Gwr/MJVM6XvqtkWy8aFSdeBrJCuIAHoydigvquFRVOEOuWmN?=
 =?us-ascii?Q?qmk7OjAAXM53ppKy0pOkDbe7HXCu1b8fvVu4Hn/XcHL64ATayy2benJmEKCj?=
 =?us-ascii?Q?N8DM9q4U0ABPM/Vz9KkalFtWAZjtIHOiAlM4fkJFaIyarcQtg+7K9wkfRhri?=
 =?us-ascii?Q?QjDXNAy3X5LI6S+jH3DCebDvCesIz94U2T1dsT68x0QbmPPE30MYesz7/9LU?=
 =?us-ascii?Q?xcd8DSpzd0s52406Avb7Yg3pHsDSKhuKMq83MLcHfRrknYionOYguiRg3j6T?=
 =?us-ascii?Q?r5vcDAg8k0J/6jXN2bKLMcPIW/ZeN+gy7KDwjXB6UmTrtI1QRwr32MYvFhdN?=
 =?us-ascii?Q?ehMzZiSEk3hqqz8CkAvBUjGR6ZRH08YRfS5Xxd6wgCyrv4FcKOF/+sWO+grk?=
 =?us-ascii?Q?ScH6EQQRL+xkFrHa+OfLBPOA9XJ8iS47613RJ19vRJdLORNCLEGJ9QbKlifg?=
 =?us-ascii?Q?NHRaE9QZDX6ySeL+mKwUXkBCdobpm82z31P6yyuTmOXAgG5GK4MjqpjyFHBx?=
 =?us-ascii?Q?8CJ/KdOX5U1DEfGlNvdk+H+acJ4zPF5Q1THXOSIhc4gfpywVrSCGyrXEpZhU?=
 =?us-ascii?Q?pLXj2VVsWQfU3X+L07AivmyzEXjcOIW1dkmfJZeugOZdiEAEVYVXZ8Bx+vL0?=
 =?us-ascii?Q?H6EaH7/Rnifx3znpJKLyBsO157/qVmM4ur+R0PEqUpmCa7UcVdNXsJH3DtPE?=
 =?us-ascii?Q?2a+XxphLOrsr6zobmq2Xc+OndNZR3Mb08Cjrt4+pSLUB4uOjQkkZdVdPPNzQ?=
 =?us-ascii?Q?daff/5tS1g+3+0pOAsmRlqshFdfX1Th6Saj0C8xwqU58ONbTzfLKP0gq2dW+?=
 =?us-ascii?Q?wDQdwbQjRAOkRrctYy5ZDj31Oj6fHxmjSeAIdlm9L7yFarl1lDFNXRjpMtk9?=
 =?us-ascii?Q?uxRkI7vIbz7Xzp65Djxi+OTpDEiahfyT667/trbaCSumlW6kdYbJ69HU38eU?=
 =?us-ascii?Q?y2HR4WdlDxVhdU5LvfzSZO0lWmS5Yi9bhRBy7/TmXmSWBfiCG2dIAIJn7whr?=
 =?us-ascii?Q?w5g1Dg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd36e6b4-5f0f-49d7-28ae-08db1e524c0d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2023 14:51:41.7326
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9Urr+5FV5NJXHBi6Fca9yUWLv0jsYtewhwgz6KEmbzeY+9/W4F2q8lmrHMumC4cAV0pU+VpHVrijenruSK3/6AzGWq6y3zPO2Dp9c+haInI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB6140
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 06, 2023 at 07:57:45PM +0800, Jason Xing wrote:
> From: Jason Xing <kernelxing@tencent.com>
> 
> Keep the accounting schema consistent across different protocols
> with __sk_mem_schedule(). Besides, it adjusts a little bit on how
> to calculate forward allocated memory compared to before. After
> applied this patch, we could avoid receive path scheduling extra
> amount of memory.
> 
> Link: https://lore.kernel.org/lkml/20230221110344.82818-1-kerneljasonxing@gmail.com/
> Signed-off-by: Jason Xing <kernelxing@tencent.com>
> ---
> V2:
> 1) change the title and body message
> 2) use __sk_mem_schedule() instead suggested by Paolo Abeni
> ---
>  net/ipv4/udp.c | 31 ++++++++++++++++++-------------
>  1 file changed, 18 insertions(+), 13 deletions(-)
> 
> diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
> index 9592fe3e444a..21c99087110d 100644
> --- a/net/ipv4/udp.c
> +++ b/net/ipv4/udp.c
> @@ -1531,10 +1531,23 @@ static void busylock_release(spinlock_t *busy)
>  		spin_unlock(busy);
>  }
>  
> +static inline int udp_rmem_schedule(struct sock *sk, int size)

nit: I think it's best to drop the inline keyword and
     let the compiler figure that out.