Date:   Mon, 6 Mar 2023 16:06:20 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Gavin Li <gavinl@nvidia.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, roopa@nvidia.com,
        eng.alaamohamedsoliman.am@gmail.com, bigeasy@linutronix.de,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        gavi@nvidia.com, roid@nvidia.com, maord@nvidia.com,
        saeedm@nvidia.com
Subject: Re: [PATCH RESEND net-next v4 4/4] net/mlx5e: TC, Add support for
 VxLAN GBP encap/decap flows offload
Message-ID: <ZAYBbP8HCXf/DHdn@corigine.com>
References: <20230306030302.224414-1-gavinl@nvidia.com>
 <20230306030302.224414-5-gavinl@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230306030302.224414-5-gavinl@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iNN8T02gZh+JAxFR0p5WoV2rZzwoALEkDXy3G/aWESMj93ZYmFN5l+oobwhI?=
 =?us-ascii?Q?l6aznqaKfEz0Glj6XIVLRsT4zczFGUbdV2e7GDklORck2ffYG77zEj3IHqPk?=
 =?us-ascii?Q?vGJB4qxwwEhl+pyGQfZ+y+IYP1CEvS8u0Oh/ZDCub3sFGlA1kZTt//eV9Isf?=
 =?us-ascii?Q?mOEMp/Vsik3yCnXep51OMaxmGU2C+9R3C3+WmvQG0Rim8xU7d4tHGB5JmLp7?=
 =?us-ascii?Q?QHTFG/mor2s3xw+uutdWYLTQ4oKJqRzeo9i4DGb8S6tilFKPjqjX2fyRz50E?=
 =?us-ascii?Q?GACM4M7y6pOJ2DhJNgtdwqI04grTjQNe8108fRE0og6EAqf3lrJmlTekuG9Z?=
 =?us-ascii?Q?ifFV/dR+8H8xQCopbgreljbB/f8fjIlvD/R7eeL9LLjX1pojKNyaUgZRvwrd?=
 =?us-ascii?Q?TgErouFcUlVmd6HmjzwC6wWRnYh1hWOefQSdDBDFLDUEQjDMr/R3HbTv1jKE?=
 =?us-ascii?Q?vn3uN7rdw8do4wFRNLKkIDtz23Y+Kmkar+0iY/ECvv8lZ55t0Kh030iveOOf?=
 =?us-ascii?Q?F2SQ+ULdWzgeIAoYaJyevosw1tD2XiUzHrrMpExl3iSFjWGyKAUodJTqZXXq?=
 =?us-ascii?Q?on8Q1d8R7/BRIQQcjjcWRSJ7ie4lm++EiJRsAKYndFxQ8URgE/36iWWQuWnK?=
 =?us-ascii?Q?qhAkbaQcPIM0VCMz7BG3CDJeR+V1ZWQdqoPyauqQUBNkRZvhz6KMxeiBb0iT?=
 =?us-ascii?Q?AV+px2YNtoyqQSCiTXrN93VLk03CC+1DEgvl/zsr0pYfeW47NoA14U1qoLTZ?=
 =?us-ascii?Q?Nv2j1DdXy5kqeMMrR/6l1UJkynAhJGt+xVDs4FwOK4lmlwttCT3ipnrM1jWO?=
 =?us-ascii?Q?fDC4Kc19imI9OP4qJu2IKP8hdfE6QQx4e1YKGu91Q6WnLuwVLBMmDCWj1s8O?=
 =?us-ascii?Q?6+wI0ZUeAkV+7VpszRUqXKwlZW8o8xcT4y8Kb89jWhCpyoq5GFOpjan+HrVh?=
 =?us-ascii?Q?2jtGDDJQm+Q/wIDfbFZy6VkjyDlJsIA7ibS5g9r5p0TlesuXatx5rSjg9x1W?=
 =?us-ascii?Q?sbGWMYXmSQKWqWDxYvBDEo4/aoldiQd3wziD2U5zFAPMYyBK7nKCjlrq5w9D?=
 =?us-ascii?Q?H+QlATMfp0AmvHkdEMCeqpwrdfWJ72w/FjsjCvmrlNTmwlHo0dcdyLqP1tJK?=
 =?us-ascii?Q?wujfCJmJzfexdDNLt33KEHT5Sk8ZFynEUsrTYsA5m7IEASvqQ4J2ig5PxeR7?=
 =?us-ascii?Q?7STBrq1M+51QJ8HEf8OnXHsMfFCpYYgcySMjcMbO15Wmtm/VD/MVCU/NtE1x?=
 =?us-ascii?Q?TZ26Mlu4ry0MxnihdiCGN8nyBXGSkZkQNsaPBCgkjDSqxHIjUuD3e3Dw/RDF?=
 =?us-ascii?Q?j42QsWPGxwmfl8ZFEJVsf8AHrBoDevKi2SlcZ/khXiDRz1jvNxcHwO6+77RR?=
 =?us-ascii?Q?jtaB3lf39HsIFjpvDVTIi21FuZiBeqacmJkoSBXKyNuI9V8xMOUcPBl2CRi2?=
 =?us-ascii?Q?XVG6JakL+yEFviNwNgKsMpU5dD6j65l3zbEMFXfv/N/6eaE8zj2KYcRDoXYn?=
 =?us-ascii?Q?ZEoKLwLrmkdpq6RBdaZPZPLNHgifNHyHw0rfBdoqFwreycfW26GxufnNQR8f?=
 =?us-ascii?Q?gUu7O1Z2tfSsNWh5WnA5rjEFXs79ZCnSw7PzfM6/PHRTKxjadZI0FLOqXZip?=
 =?us-ascii?Q?RTtL8DitdTGKWvZ5OocmOxqkjdiLsHLzmVJHzQWwKb8tkHOOMf0GyYUuLuqj?=
 =?us-ascii?Q?TCnr8A=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 362e351a-548e-46ea-8436-08db1e545bfb
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2023 15:06:27.4384
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iK0wO2T3s+dFV55TZDlbXUMYM7KZv8XhS4xTF7BIqaxIzkopR1ty7I/aXyC/xtLbSfGRuh+l5y5D43DoMx6k5cKx0YqjSFxCMPsgA6EkNm0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3938
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 06, 2023 at 05:03:02AM +0200, Gavin Li wrote:
> Add HW offloading support for TC flows with VxLAN GBP encap/decap.
> 
> Example of encap rule:
> tc filter add dev eth0 protocol ip ingress flower \
>     action tunnel_key set id 42 vxlan_opts 512 \
>     action mirred egress redirect dev vxlan1
> 
> Example of decap rule:
> tc filter add dev vxlan1 protocol ip ingress flower \
>     enc_key_id 42 enc_dst_port 4789 vxlan_opts 1024 \
>     action tunnel_key unset action mirred egress redirect dev eth0
> 
> Signed-off-by: Gavin Li <gavinl@nvidia.com>
> Reviewed-by: Gavi Teitz <gavi@nvidia.com>
> Reviewed-by: Roi Dayan <roid@nvidia.com>
> Reviewed-by: Maor Dickman <maord@nvidia.com>
> Acked-by: Saeed Mahameed <saeedm@nvidia.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>

FWIIW, I did provide a Reviewed-by tag for the other patches in this
series, but I don't believe I did for this patch..