Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C3AC61DA4 for ; Mon, 6 Mar 2023 15:29:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230003AbjCFP3g (ORCPT ); Mon, 6 Mar 2023 10:29:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230110AbjCFP3b (ORCPT ); Mon, 6 Mar 2023 10:29:31 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C9DA34329 for ; Mon, 6 Mar 2023 07:28:57 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8F189B80E60 for ; Mon, 6 Mar 2023 15:28:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B43CC433EF; Mon, 6 Mar 2023 15:28:46 +0000 (UTC) Date: Mon, 6 Mar 2023 10:28:44 -0500 From: Steven Rostedt To: Hillf Danton Cc: John Stultz , LKML , Wei Wang , Midas Chien , "Chunhui Li (=?UTF-8?B?5p2O5pil6L6J?=)" , Kees Cook , Anton Vorontsov , "Guilherme G. Piccoli" , Tony Luck , linux-mm@kvack.org Subject: Re: [PATCH v2] pstore: Revert pmsg_lock back to a normal mutex Message-ID: <20230306102844.1293adfa@gandalf.local.home> In-Reply-To: <20230306010323.2909-1-hdanton@sina.com> References: <20230302062741.483079-1-jstultz@google.com> <20230304031029.3037914-1-jstultz@google.com> <20230306010323.2909-1-hdanton@sina.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Mar 2023 09:03:23 +0800 Hillf Danton wrote: > PS what sense made by spinning on owner until need_resched() with preempt > disabled in the non-rt context? Not sure what the question you have here is? If need_resched() is set, we want to schedule out. -- Steve