Message-ID: <3c1354b2-831e-d523-a539-904135fe34f4@nvidia.com>
Date:   Mon, 6 Mar 2023 15:58:38 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] soc/tegra: cbb: remove linux/version.h
Content-Language: en-US
To:     Muhammad Usama Anjum <usama.anjum@collabora.com>,
        Thierry Reding <thierry.reding@gmail.com>
Cc:     kernel@collabora.com, kernel-janitors@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230303130346.2062989-1-usama.anjum@collabora.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20230303130346.2062989-1-usama.anjum@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VjJxeDhwaTdyeXFGbThTSXowK21QdDlHM3A2N0hYbG9kR0QxSzJpR0dNVnYw?=
 =?utf-8?B?Q2pRS1kxbVM0V1pUc3NjdXdUMWswTmJuMzljOXN4d0FyMUZneGl6RFZLQS9q?=
 =?utf-8?B?OVRLajR1NGozS2Yvd041U3h3Q1V3dzZjRjVmWmVqL1JCd1RXY1VlUmQ0RHZB?=
 =?utf-8?B?MUF0VUJvcUt2TTB2OWIvaHNIWkJWTlN4cUIxNnIrYWpNVk5jRlQ2Q2xQZ1dO?=
 =?utf-8?B?ZlpWSWVTYmpmdnQ4UXNaL0FNS3ViRkhsV1haSG1RWkZnS2hxb1FpMWhQeGZG?=
 =?utf-8?B?d3VGRHhqS3BvMUZhUDdGS2ZocTJidGt5eENqWUN2blU5dDR6WmFHMmxnMmh1?=
 =?utf-8?B?UnZqZXcxZ2ZsZFlxdGd2c3lOZXhQUHU5ME0rUndyR202WWxEL0lCSVlGUXFP?=
 =?utf-8?B?Z0x4OHBOTkUyMGVuaDNHMG5iRm5YRUZLcTd2bm95MzJETEM4MjVkdGdRejd6?=
 =?utf-8?B?aGFPYXBkeVBsTzFWSzZ5MktPNXh2VkU2TXYybjF2R3Z0aFpFYlRSM05Jczh6?=
 =?utf-8?B?Um9sMllpQmlPcVh0UmdmVFF2bm5uTFlxalpILzNOUFlXcHRVL20xaDNIenRZ?=
 =?utf-8?B?ODdRV3ZjRVRINktUbHFwTzBhZ0hXa0owWFpOanpCODRuVWtvMkh4Y2tsQzhX?=
 =?utf-8?B?cmpsaHI4bUtyVzY2dnJXWTlYaXArUE5BaVg2TEg1YktTS2ZLeWppdHVjczRT?=
 =?utf-8?B?UUZNdytLbXhpcUVPMW1oZFZHR0FQNWdwbTZGUGtGRHgrT3JWWnR1aXZsQ3E2?=
 =?utf-8?B?V3BKUTMwVVNYcmlLUThqS2tQRmpSbkZxY3d3dlBNeWNQNnd6djZ1NXVuRW5x?=
 =?utf-8?B?ZUJqSHFhby90L29LamprRkR5Z3VrRStIOWJtVXZwU3VTRTMvWDc2N2RFaGRa?=
 =?utf-8?B?OVgxblJHaWtWK3JYUXFNRU94alZTaUp1anFjaGlwR3Bodld0V3p2Vy9LWEhv?=
 =?utf-8?B?Q3prODRnUmo5MEVaNkMyUUI0SXlLOTIydWRmaTVzMk1CcXpzdVlpZVpNaEhZ?=
 =?utf-8?B?NExQU1pQbFJVQ0tyeENKR0RlQWdSdmR3MXoxeGhOcU83anJtTjVFOTdwSTN5?=
 =?utf-8?B?djhvOGtCN2ZOSEZ6ZU9Fa2YyMjhqOTVkNVlRcFljWTA2b3ZHbzdWdVdXSEJQ?=
 =?utf-8?B?eHVURXFmVWVIOGdHYXNjcS9qa3BQVkdtalRKSDVYYWJxMlErcStnNkNmYytX?=
 =?utf-8?B?em8xdlhHbXAyQldCeHVwYmRweTB3Ulp4NXliNUk0YWppdjlya0ZaT2gzZHd1?=
 =?utf-8?B?RjZkL0hDbE1QWWswd0UxdzRZL29UQ3RWODZkOHd2RHdrekNoWGhUTkFzSnJS?=
 =?utf-8?B?NHN4a05lQisreXBIc3lVUWwrcG5XQm0xZFVENWdDNE1reTFveGFhanIyS25J?=
 =?utf-8?B?S21sYVprTmJtQkVKTWhtenZIMVRzeHBrTlVVL1AwZ3lFTkdMOC8wVDBCeU9K?=
 =?utf-8?B?RTdndW93VGp3V0h4QXpZZkN6YVdxYmtIZ1VaUVhHZkNxREhITzU0dURIc2lX?=
 =?utf-8?B?enEvbmUwdnE0UEx2bFUzdmtFTkxwTTl2ZmVpVlZQOXR0NmlrU3pucVAvMHdX?=
 =?utf-8?B?UkNJc0cyQXo1eTZPcVlzbUt6dEgrblZ4SzlGTnpPa3Z6akRXZGtMSk1jd3Zr?=
 =?utf-8?B?eGJsUXNzM3dFRTJ2SUQ0eDdkbTc3Ny8vWlJYak9ra1dweDQ3V1gzSDNqZDJT?=
 =?utf-8?B?S3BkTjlwcUNHOFowTzRJTEhQclFWcWFWZFJpUEVOS1BNZjk0eWMybTlVR3ZJ?=
 =?utf-8?B?ZFB3ZXdBZlU2VURSUEVtakszY2lzY2JlZjVQdEliL0RTNE5Nam82TGJ4aTJS?=
 =?utf-8?B?eVFQbGo3TEJGRElLSmRycUFBdnIrbEZDNk0ydzZSNUE0eEtqRWo1UWg5WlU5?=
 =?utf-8?B?QXdsRVVpQ1p5eDd6eXFHYkI4cnRhYWl6bjdHR2J0dXZmTUFZa3lnbWNYZ0tG?=
 =?utf-8?B?YVBtOXZPRXIwekZlUXBqbVd0MURsNlo3QWlQNG9XOGFScnVXYTdISHNwc0h6?=
 =?utf-8?B?a2xWajhZTGpjM0RySlQxNi9VUm1MVnFLY1FsMlh2OS9NZTlOMGhCVHUycDFE?=
 =?utf-8?B?MHNvRU9xWlA0TmtXamVWSnhLK0Q3MWtYK1dLTnc0a2wyWWVBTVVHb2tnN0gw?=
 =?utf-8?B?aThHYTBzUGdEdXZOUjZBSTh2ekxDSk0vcDM1WmtQZ0pCMGxZcUZOQlJEdFkw?=
 =?utf-8?B?LzZCek52aFJydnZEM0hNcExWQmxGa3pWSXI1Z2RGV2NZSUdjeXJQbVpMUDJr?=
 =?utf-8?B?ejhFdDhHMWRoK2hKWFdJVHBvU1lRPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5f40f67-fd30-4fd9-4fac-08db1e5ba9f9
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2023 15:58:44.8114
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7w3irN1toy3DD96yOEagZMwse4evES/KHkJQ16ax4mS65kYdhsSb+pm6FZscq5/x1c+jh/YkCN7mjuXmPj0Inw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8195
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 03/03/2023 13:03, Muhammad Usama Anjum wrote:
> make versioncheck reports the following:
> ./drivers/soc/tegra/cbb/tegra-cbb.c: 19 linux/version.h not needed.
> ./drivers/soc/tegra/cbb/tegra194-cbb.c: 26 linux/version.h not needed.
> ./drivers/soc/tegra/cbb/tegra234-cbb.c: 27 linux/version.h not needed.
> 
> So remove linux/version.h from these files.
> 
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
>   drivers/soc/tegra/cbb/tegra-cbb.c    | 1 -
>   drivers/soc/tegra/cbb/tegra194-cbb.c | 1 -
>   drivers/soc/tegra/cbb/tegra234-cbb.c | 1 -
>   3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/soc/tegra/cbb/tegra-cbb.c b/drivers/soc/tegra/cbb/tegra-cbb.c
> index a8566b9dd8de..bd96204a68ee 100644
> --- a/drivers/soc/tegra/cbb/tegra-cbb.c
> +++ b/drivers/soc/tegra/cbb/tegra-cbb.c
> @@ -16,7 +16,6 @@
>   #include <linux/of_address.h>
>   #include <linux/interrupt.h>
>   #include <linux/ioport.h>
> -#include <linux/version.h>
>   #include <soc/tegra/fuse.h>
>   #include <soc/tegra/tegra-cbb.h>
>   
> diff --git a/drivers/soc/tegra/cbb/tegra194-cbb.c b/drivers/soc/tegra/cbb/tegra194-cbb.c
> index d4112b683f00..a05fc2caff3b 100644
> --- a/drivers/soc/tegra/cbb/tegra194-cbb.c
> +++ b/drivers/soc/tegra/cbb/tegra194-cbb.c
> @@ -23,7 +23,6 @@
>   #include <linux/of_address.h>
>   #include <linux/interrupt.h>
>   #include <linux/ioport.h>
> -#include <linux/version.h>
>   #include <soc/tegra/fuse.h>
>   #include <soc/tegra/tegra-cbb.h>
>   
> diff --git a/drivers/soc/tegra/cbb/tegra234-cbb.c b/drivers/soc/tegra/cbb/tegra234-cbb.c
> index f33d094e5ea6..e23e8acfd7c7 100644
> --- a/drivers/soc/tegra/cbb/tegra234-cbb.c
> +++ b/drivers/soc/tegra/cbb/tegra234-cbb.c
> @@ -24,7 +24,6 @@
>   #include <linux/of_address.h>
>   #include <linux/interrupt.h>
>   #include <linux/ioport.h>
> -#include <linux/version.h>
>   #include <soc/tegra/fuse.h>
>   #include <soc/tegra/tegra-cbb.h>
>   

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks
Jon

-- 
nvpublic