Message-ID: <7212f65a-4d2d-5ecd-235d-95b60f45a0e8@amd.com>
Date:   Mon, 6 Mar 2023 11:17:26 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] amdgpu: Avoid building on UML
Content-Language: en-US
To:     Peter Foley <pefoley2@pefoley.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20230112-amduml-v1-1-5e4a0d37de16@pefoley.com>
From:   Felix Kuehling <felix.kuehling@amd.com>
In-Reply-To: <20230112-amduml-v1-1-5e4a0d37de16@pefoley.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmFjWVB3cUNCVXlDK1F0SlJheFR1MUFhYUtpY3NmOXFBMm5sTlp4bWdxNzNr?=
 =?utf-8?B?SU13NDRBMVFtTVcvRVZGQUJiUFhWVzhzam1WT2Y5WXFTdElSd3dua0dyMUFH?=
 =?utf-8?B?MUVjbDk3bzFhQ0JZbGlZK09ZYzNWWnFwU3FYV1Q2MGFmdWl3UDlWVG8wcjk5?=
 =?utf-8?B?SU54N2pqSDlmYlFpcndJSHFQaXgvZWlLZ3ZwQVd1TzNjZXEvbHdjWDVwcW1W?=
 =?utf-8?B?KzNHbC9rNUh6QSsycUFVVmtrNDhmWHVwRlVpeC90aVZmSkduMkh3TlAxYUpq?=
 =?utf-8?B?M2NmeHFBOS9mc1RhVDQxZzhEMG9OOTY5NnhmTVZvdFVSd2tCc0ZJcnl5QUN0?=
 =?utf-8?B?Ukk5WHcrWTJFNng4dE4xSVhlVEp5MWJnY1llVVliY2NPSG4xemk5cGs4RVNE?=
 =?utf-8?B?ZHJLNk5ITFlUb3MxcWZXYU1YbnA3Qnk4YW5LRW9JT0NQQTlQTzhSUTlROEYx?=
 =?utf-8?B?SUVYck5tZFFzYmQ1MFpjaDZBOUcyYktJRzNLMXZCeFROdzZ6Q0M1NU1ZalI3?=
 =?utf-8?B?L0N4cHMyOHRzc1lRMVFzaUxVdCs0OHplQXNVSW9FYSsxODNtRDlETm45ZC9o?=
 =?utf-8?B?ejd4dk9DbXU5Qjd2NE82bTBsaFpNcG0wNDhBYzZGUHdtOVE2aEFmMFlFMWJF?=
 =?utf-8?B?N3dScm5uVkpjUlh1RXNhQUE2UFdWQjZxT2dnb2s1bXMwWGVOajBmZWJ0cmV6?=
 =?utf-8?B?VXFmc3lzT2k5Rit3eitCYXM0ZEw0ZmhYQ0pIaWh5TkFNc2MzdVdxS00reTFC?=
 =?utf-8?B?bmF3WlRLUThmaXZod0lNdkN2ZXg1TkNXbEVKVzR4R29kN0JGTC9xSWFGSmFm?=
 =?utf-8?B?TWpxMFdYUEF0YVJOWkFCQmhCRWg1NmJtRCtyWkRyNURTMTJnODZPZHp0UW5o?=
 =?utf-8?B?b2NyTGxjNG1EaUFnUVB5NEZqNk9LMmVZNFRLdEFHQTFnQktIM1JnUHRicWVm?=
 =?utf-8?B?THdKZUxmV2Y1S3d0OElvYmJzMkdjQ2RYb3VFem1EU1NCbVFFYlVEbXF0cE1k?=
 =?utf-8?B?NXRsSkhmTGkyVkYyTTZUUDdYOHRuMHVEQUNJNFRSM3VSWlJiUDhiaFdEOFFJ?=
 =?utf-8?B?UVppL2ROU3ZDL3haMkUxUVBrNFBQOHo2WEdOQjVFbHlURUpXbVQ0aThNd0hi?=
 =?utf-8?B?d1VLTjFPR3VtTnFiRUIxRzBUWG5qVm9HaEhpOWNTa3Mxc2kyN3ViazNmNkVx?=
 =?utf-8?B?M3dvUzlicHIxZ0h1SzErcTZiZkJZQjZRUDMxNzVLcDl1anNQaGZEUm8wMHZR?=
 =?utf-8?B?alhwM0ZLd2l0OStkNkpCb0NxTWErUzdzc2laZkpaQm5VV3pLbzRUTGRMTFhZ?=
 =?utf-8?B?bzIxL3hKWUIxb25HZmFaT2dCRzBjUEhZM1gyL3JaUHJXTFpQcG9jK1gzUmpk?=
 =?utf-8?B?YW1sSzkrNStBOXRsZ21wNDlpS1FDZFlOc2tpUW9tN0txMHJnOExtUGpFSEdH?=
 =?utf-8?B?K2M3dmNkZERJS2FrZmN2S2ZSQnBGTWdUczJoL3UrVzdsblI4RDc1eld2MmRP?=
 =?utf-8?B?ZVZ4V1JSckNjUDh6SVZ2cWlCM2M1YmNNaFlFOHJEakRlN3FLMXdtUkh0K0Ns?=
 =?utf-8?B?QXAzdUtIMFpTa1RVSk9iSXdxRU1SODIzREdtc1NETWFSSlliZ1JFSG5DMkFs?=
 =?utf-8?B?d2tDTEtuRkRKc3IwQzhKZzk5WGJQSFBQZDhBclFSYnExUVdGTmJ6QlVNcm5q?=
 =?utf-8?B?SU4zQTRydk1xWWp4TThXY01MOW1mdzBvYWtoMDRGVGk2dHRhaUJaNUZobXg2?=
 =?utf-8?B?a3ZFd0pJQmtUNmRGN2p0d3pOUmJ4ZFlJMnhXME1LYlk2bGM0SERtcHp0RjVO?=
 =?utf-8?B?KzNqOUFaVzZYRWx4TnJPVG0wbHBGNThzN1JqTHR0ck84QkZkTkZMYjlXTk9C?=
 =?utf-8?B?VmExbkVQTjdwdllnUnJnbExkOUV0OWRJS3RoRS9neHZNTmkrcVM2NXg3K1BQ?=
 =?utf-8?B?aDlNM0EwWFMyWWhOdE5rb3RBam1zLzUwUE5yanZkRC93Ui9XMEljN2hMSzdM?=
 =?utf-8?B?MUV1VVNSRGZhK1RUU0JTREd2NGJORVdieHU0dE81T295eTRzY3htTGRuRXdy?=
 =?utf-8?B?REgzcVVhS2E5RG1wd1RzSU1JWFgvL1NFMERHMmZYZVBzdGV4cDFBUHRPVkd0?=
 =?utf-8?Q?R4M2wFVVMwGUv7XNA+lQtm3kz?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05fe4c60-da80-4497-b7e1-08db1e5e47fe
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2023 16:17:28.8410
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KjvYZFulerTGVVPXMNfHVgSkUMa4Hoh8Bux/8nusqcpp3ySyZMBfxbncB1gclOjqf7ziqrIxTbDbS+ydVNacmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4469
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Looks like this patch got lost over the holidays. Alex, are you OK with 
applying this patch? Or are people looking for a more general solution 
to not build HW drivers for UML? FWIW:

Acked-by: Felix Kuehling <Felix.Kuehling@amd.com>


Am 2023-01-12 um 23:30 schrieb Peter Foley:
> The amdgpu driver tries to use fields not supported by UML's cpuinfo
> struct. Disable the driver when targeting UML to avoid tripping up
> allyesconfig.
>
> e.g.
> ../drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_hwmgr.c: In function ‘intel_core_rkl_chk’:
> ../drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_hwmgr.c:1742:33: error: initialization of ‘struct cpuinfo_x86 *’ from incompatible pointer type ‘struct cpuinfo_um *’ [-Werror=incompatible-pointer-types
> ]
> ../drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c: In function ‘kfd_cpumask_to_apic_id’:
> ../drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:2157:48: error: ‘struct cpuinfo_um’ has no member named ‘apicid’
>
> Signed-off-by: Peter Foley <pefoley2@pefoley.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig b/drivers/gpu/drm/amd/amdgpu/Kconfig
> index 5fcd510f1abb..aa0008ff8712 100644
> --- a/drivers/gpu/drm/amd/amdgpu/Kconfig
> +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
> @@ -3,6 +3,7 @@
>   config DRM_AMDGPU
>   	tristate "AMD GPU"
>   	depends on DRM && PCI && MMU
> +	depends on !UML
>   	select FW_LOADER
>   	select DRM_DISPLAY_DP_HELPER
>   	select DRM_DISPLAY_HDMI_HELPER
>
> ---
> base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
> change-id: 20230112-amduml-565935d34bfb
>
> Best regards,