Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E4C8C64EC4 for ; Mon, 6 Mar 2023 17:40:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230038AbjCFRkk (ORCPT ); Mon, 6 Mar 2023 12:40:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229830AbjCFRkg (ORCPT ); Mon, 6 Mar 2023 12:40:36 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0ACE6A1D0 for ; Mon, 6 Mar 2023 09:39:53 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 331F31FDDD; Mon, 6 Mar 2023 17:38:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1678124291; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CjsdVtOT19sgmnwLtBgOV0bQr30Doz68iTxFvJb7MVY=; b=iKZM4a3kjBj5igyGY9nYaFFnSsecXkdh5ETnei0KWtPfemR/f5AArLWkAJ4+Lg4TtIE0kl vUB6kadcOXfROHaa35OTTCCy1yWNEWmcg/Ms2e1M8gjrIm2RrgNQ1GNa7ht1TCwke30eAw 1FfzsnYou26QuH3TIZzqY+mDnTm1v1U= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1443D13513; Mon, 6 Mar 2023 17:38:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yRV7AQMlBmStdwAAMHmgww (envelope-from ); Mon, 06 Mar 2023 17:38:11 +0000 Date: Mon, 6 Mar 2023 18:38:10 +0100 From: Michal Hocko To: Vlastimil Babka Cc: Uladzislau Rezki , Gao Xiang , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mel Gorman , Baoquan He , Christoph Hellwig Subject: Re: [PATCH] mm, vmalloc: fix high order __GFP_NOFAIL allocations Message-ID: References: <20230305053035.1911-1-hsiangkao@linux.alibaba.com> <6452176f-4c17-8e09-8561-c659cbea4014@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6452176f-4c17-8e09-8561-c659cbea4014@suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks. Here is an incremental diff diff --git a/mm/vmalloc.c b/mm/vmalloc.c index bef6cf2b4d46..b01295672a31 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2938,7 +2938,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid, /* * Higher order nofail allocations are really expensive and * potentially dangerous (pre-mature OOM, disruptive reclaim - * and compaction etc. + * and compaction etc). */ alloc_gfp &= ~__GFP_NOFAIL; nofail = true; @@ -2965,7 +2965,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid, /* * Higher order allocations must be able to be treated as - * indepdenent small pages by callers (as they can with + * independent small pages by callers (as they can with * small-page vmallocs). Some drivers do their own refcounting * on vmalloc_to_page() pages, some use page->mapping, * page->lru, etc. -- Michal Hocko SUSE Labs