Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Mon, 06 Mar 2023 18:57:17 +0100
Message-Id: <CQZHTJDTRJXM.3OF3W3WAZBLAK@vincent-arch>
Subject: Re: [PATCH v3 2/2] dyndbg: use the module notifier callbacks
From:   "Vincenzo Palazzo" <vincenzopalazzodev@gmail.com>
To:     "Jason Baron" <jbaron@akamai.com>, <mcgrof@kernel.org>
Cc:     <jim.cromie@gmail.com>, <gregkh@linuxfoundation.org>,
        <linux-kernel@vger.kernel.org>, <linux-modules@vger.kernel.org>,
        "Peter Zijlstra" <peterz@infradead.org>
References: <cover.1677861177.git.jbaron@akamai.com>
 <5884c688d10c9703fb0457f8839d6becc8657f8f.1677861177.git.jbaron@akamai.com>
In-Reply-To: <5884c688d10c9703fb0457f8839d6becc8657f8f.1677861177.git.jbaron@akamai.com>
Precedence: bulk

> Bring dynamic debug in line with other subsystems by using the module
> notifier callbacks. This results in a net decrease in core module
> code.
>
> Additionally, Jim Cromie has a new dynamic debug classmap feature,
> which requires that jump labels be initialized prior to dynamic debug.
> Specifically, the new feature toggles a jump label from the existing
> dynamic_debug_setup() function. However, this does not currently work
> properly, because jump labels are initialized via the
> 'module_notify_list' notifier chain, which is invoked after the
> current call to dynamic_debug_setup(). Thus, this patch ensures that
> jump labels are initialized prior to dynamic debug by setting the
> dynamic debug notifier priority to 0, while jump labels have the
> higher priority of 1.
>
> Tested by Jim using his new test case, and I've verfied the correct
> printing via: # modprobe test_dynamic_debug dyndbg.
>
> Link: https://lore.kernel.org/lkml/20230113193016.749791-21-jim.cromie@gm=
ail.com/
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202302190427.9iIK2NfJ-lkp@int=
el.com/
> Tested-by: Jim Cromie <jim.cromie@gmail.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> CC: Jim Cromie <jim.cromie@gmail.com>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Jason Baron <jbaron@akamai.com>

Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>