Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4C0CC64EC4 for ; Mon, 6 Mar 2023 19:30:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229785AbjCFTaO (ORCPT ); Mon, 6 Mar 2023 14:30:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229568AbjCFTaM (ORCPT ); Mon, 6 Mar 2023 14:30:12 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F13706E6A8; Mon, 6 Mar 2023 11:30:02 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 30323B810CB; Mon, 6 Mar 2023 19:30:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD916C433D2; Mon, 6 Mar 2023 19:29:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678131000; bh=hCveUPTHfPlfd4ckjlJ+h3qtXYHgC0QYnx+BbTyXMjI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=LrhrxY/V1SwrNdgraCO6Bs1NZMyDpSOsvOEZ+opYk8NgYUYkAjV0zyInHnQ3lrP5k X2tGx75cKEQ+zzNKBHmI//i0VIznb6u2ACEq+815kVC8ZWZssS/r/dEaP3DxqCQnMX JUt0ERw2LjVEvXtaoTaZsaj5y+ncmgBsNbtNdzlcMIs/OmkJCnw2E+sE87Firfr+hM maTOtEW6p77FT8CfM/1L4yIWAzysbpxFOjiv+gD2aKdFnm+bMWK2ncJe98jDEgtmEW toRRq/TQ3aRRnCL+qMKKiwkbIzCHC1wuPzIPbncBP+csjE1TxmGuIAiUABxm6VgHdw tqb2JHsPbBZzA== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230222121453.91915-12-nick.alcock@oracle.com> References: <20230222121453.91915-1-nick.alcock@oracle.com> <20230222121453.91915-12-nick.alcock@oracle.com> Subject: Re: [PATCH 11/27] kbuild, clk: bcm2835: remove MODULE_LICENSE in non-modules From: Stephen Boyd Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Hitomi Hasegawa , Michael Turquette , Florian Fainelli , Ray Jui , Scott Branden , linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org To: Nick Alcock , mcgrof@kernel.org Date: Mon, 06 Mar 2023 11:29:57 -0800 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Nick Alcock (2023-02-22 04:14:37) > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. >=20 > So remove it in the files in this commit, none of which can be built as > modules. >=20 > Signed-off-by: Nick Alcock > Suggested-by: Luis Chamberlain > Cc: Luis Chamberlain > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Florian Fainelli > Cc: Ray Jui > Cc: Scott Branden > Cc: linux-clk@vger.kernel.org > Cc: linux-rpi-kernel@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > --- Applied to clk-fixes