Message-ID: <d97ab14301c65d775cd69c1efebedb37.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230226053953.4681-3-rdunlap@infradead.org>
References: <20230226053953.4681-1-rdunlap@infradead.org> <20230226053953.4681-3-rdunlap@infradead.org>
Subject: Re: [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        Riku Voipio <riku.voipio@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        linux-clk@vger.kernel.org
To:     Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Date:   Mon, 06 Mar 2023 11:30:36 -0800
User-Agent: alot/0.10
Precedence: bulk

Quoting Randy Dunlap (2023-02-25 21:39:47)
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>=20
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>=20
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>=20
> Fixes: 3a49afb84ca0 ("clk: enable hi655x common clk automatically")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Riku Voipio <riku.voipio@linaro.org>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: linux-clk@vger.kernel.org
> ---

Applied to clk-fixes