MIME-Version: 1.0
References: <20230306040739.51488-1-blarson@amd.com> <20230306040739.51488-11-blarson@amd.com>
 <20230306160017.ptd3ogundxvus5zm@mobilestation>
In-Reply-To: <20230306160017.ptd3ogundxvus5zm@mobilestation>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 6 Mar 2023 21:59:29 +0200
Message-ID: <CAHp75VfFMiy35Q1bX3Az3HgkhK+4bfH+pCE2XwOYVpqT8UiFXA@mail.gmail.com>
Subject: Re: [PATCH v10 10/15] spi: dw: Add support for AMD Pensando Elba SoC
To:     Serge Semin <fancer.lancer@gmail.com>
Cc:     Brad Larson <blarson@amd.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org,
        adrian.hunter@intel.com, alcooperx@gmail.com, arnd@arndb.de,
        brendan.higgins@linux.dev, briannorris@chromium.org,
        brijeshkumar.singh@amd.com, catalin.marinas@arm.com,
        davidgow@google.com, gsomlo@gmail.com, gerg@linux-m68k.org,
        krzk@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org,
        lee.jones@linaro.org, broonie@kernel.org,
        yamada.masahiro@socionext.com, p.zabel@pengutronix.de,
        piotrs@cadence.com, p.yadav@ti.com, rdunlap@infradead.org,
        robh+dt@kernel.org, samuel@sholland.org, skhan@linuxfoundation.org,
        suravee.suthikulpanit@amd.com, thomas.lendacky@amd.com,
        tonyhuang.sunplus@gmail.com, ulf.hansson@linaro.org,
        vaishnav.a@ti.com, will@kernel.org, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Mar 6, 2023 at 6:00 PM Serge Semin <fancer.lancer@gmail.com> wrote:
> On Sun, Mar 05, 2023 at 08:07:34PM -0800, Brad Larson wrote:

...

> > -     node = of_parse_phandle(np, syscon_name, 0);
>
>         node = of_parse_phandle(dev_of_node(pdev->dev), syscon_name, 0);

Side note: I would rather see syscon_fwnode_to_regmap() instead of
this. And IIRC syscon already has an API to find by name.

> > +     if (!node)
>
> > +             return dev_err_probe(&pdev->dev, -ENODEV, "failed to find %s\n",
> > +                                  syscon_name);
>
> Hm, using dev_err_probe() with known error value seems overkill.

It's allowed use and it helps to drop a few unnecessary lines of code.

> > +     syscon = syscon_node_to_regmap(node);
> > +     if (IS_ERR(syscon))
> > +             return dev_err_probe(&pdev->dev, PTR_ERR(syscon),
> > +                                  "syscon regmap lookup failed\n");

-- 
With Best Regards,
Andy Shevchenko