Date:   Mon, 06 Mar 2023 22:03:49 +0000
To:     Gergo Koteles <soyer@irl.hu>, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
From:   Caleb Connolly <caleb@connolly.tech>
Cc:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm845-oneplus-common: add Hall sensor
Message-ID: <940dec11-dbcb-d6df-3722-0375bfe86508@connolly.tech>
In-Reply-To: <20230306174147.185239-1-soyer@irl.hu>
References: <20230306174147.185239-1-soyer@irl.hu>
Feedback-ID: 10753939:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 06/03/2023 17:41, Gergo Koteles wrote:
> Enable the Hall effect sensor (flip cover) for OnePlus 6/6T.
> The GPIO is mapped to SW_LID events as in msm8916, msm8994,
> msm8998 devices.
>
> Signed-off-by: Gergo Koteles <soyer@irl.hu>

Reviewed-by: Caleb Connolly <caleb@connolly.tech>
> ---
>  .../boot/dts/qcom/sdm845-oneplus-common.dtsi  | 25 +++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/a=
rm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> index 64638ea94db7..b01542d79ae2 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> @@ -29,6 +29,23 @@ chosen {
>  =09=09stdout-path =3D "serial0:115200n8";
>  =09};
>
> +=09gpio-hall-sensor {
> +=09=09compatible =3D "gpio-keys";
> +=09=09label =3D "Hall effect sensor";
> +
> +=09=09pinctrl-0 =3D <&hall_sensor_default>;
> +=09=09pinctrl-names =3D "default";
> +
> +=09=09event-hall-sensor {
> +=09=09=09gpios =3D <&tlmm 124 GPIO_ACTIVE_LOW>;
> +=09=09=09label =3D "Hall Effect Sensor";
> +=09=09=09linux,input-type =3D <EV_SW>;
> +=09=09=09linux,code =3D <SW_LID>;
> +=09=09=09linux,can-disable;
> +=09=09=09wakeup-source;
> +=09=09};
> +=09};
> +
>  =09gpio-keys {
>  =09=09compatible =3D "gpio-keys";
>  =09=09label =3D "Volume keys";
> @@ -753,6 +770,14 @@ &usb_1_hsphy {
>  &tlmm {
>  =09gpio-reserved-ranges =3D <0 4>, <81 4>;
>
> +=09hall_sensor_default: hall-sensor-default-state {
> +=09=09pins =3D "gpio124";
> +=09=09function =3D "gpio";
> +=09=09drive-strength =3D <2>;
> +=09=09bias-disable;
> +=09=09input-enable;
> +=09};
> +
>  =09tri_state_key_default: tri-state-key-default-state {
>  =09=09pins =3D "gpio40", "gpio42", "gpio26";
>  =09=09function =3D "gpio";
> --
> 2.39.2
>

--
Kind Regards,
Caleb