MIME-Version: 1.0
References: <20230302092109.367-1-ravi.bangoria@amd.com> <20230302092109.367-2-ravi.bangoria@amd.com>
 <CAM9d7cjEvjcYwjA+HfsDHKDX8FGZCECTZ8vDMPHBUSqfQSCOfA@mail.gmail.com> <c5f1c3c2-6de3-a40d-9cf0-c1c7638acfc3@amd.com>
In-Reply-To: <c5f1c3c2-6de3-a40d-9cf0-c1c7638acfc3@amd.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Mon, 6 Mar 2023 14:29:10 -0800
Message-ID: <CAM9d7ch9OsFz9N71QG5DOyygctK+bVAFGQByUGAvy=d29rzWZg@mail.gmail.com>
Subject: Re: [PATCH 1/2] perf/ibs: Fix interface via core pmu events
To:     Ravi Bangoria <ravi.bangoria@amd.com>
Cc:     peterz@infradead.org, eranian@google.com, acme@kernel.org,
        mark.rutland@arm.com, jolsa@kernel.org, irogers@google.com,
        bp@alien8.de, x86@kernel.org, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org, sandipan.das@amd.com,
        ananth.narayan@amd.com, santosh.shukla@amd.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Mar 2, 2023 at 9:54 PM Ravi Bangoria <ravi.bangoria@amd.com> wrote:
>
> Hi Namhyung,
>
> >> diff --git a/kernel/events/core.c b/kernel/events/core.c
> >> index a5a51dfdd622..c3f59d937280 100644
> >> --- a/kernel/events/core.c
> >> +++ b/kernel/events/core.c
> >> @@ -11633,9 +11633,13 @@ static struct pmu *perf_init_event(struct perf_event *event)
> >>                         goto fail;
> >>
> >>                 ret = perf_try_init_event(pmu, event);
> >> -               if (ret == -ENOENT && event->attr.type != type && !extended_type) {
> >> -                       type = event->attr.type;
> >> -                       goto again;
> >> +               if (ret == -ENOENT) {
> >> +                       if (event->attr.type != type && !extended_type) {
> >> +                               type = event->attr.type;
> >> +                               goto again;
> >> +                       }
> >> +                       if (pmu->capabilities & PERF_PMU_CAP_FORWARD_EVENT)
> >> +                               goto try_all;
> >
> > Wouldn't it be better to use a different error code to indicate
> > it's about precise_ip (or forwarding in general)?  Otherwise
> > other invalid config might cause the forwarding unnecessarily..
>
> That would make things easier and we might not need this new capability.
> Most appropriate error codes seems ENOENT, EOPNOTSUPP and EINVAL but all
> are already used for other purposes. Any other suggestions?

Maybe we can have more liberty for the error code since
it's not returned to the user.  How about ESRCH, EIO or ENXIO?

Thanks,
Namhyung