From:   Asmaa Mnebhi <asmaa@nvidia.com>
To:     "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>
CC:     "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4] gpio: mmio: handle "ngpios" properly in bgpio_init()
Thread-Topic: [PATCH v4] gpio: mmio: handle "ngpios" properly in bgpio_init()
Thread-Index: AQHZUHBpmwUyJW1DpkeY8R87iuQYWq7uV5UAgAAAPsA=
Date:   Mon, 6 Mar 2023 22:39:26 +0000
Message-ID: <CH2PR12MB38959136005B21C93159C5A8D7B69@CH2PR12MB3895.namprd12.prod.outlook.com>
References: <20230306211237.14876-1-asmaa@nvidia.com>
 <ZAZrKPw38ERSbzXg@surfacebook>
In-Reply-To: <ZAZrKPw38ERSbzXg@surfacebook>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o05OCGwRlSwIEdQ+q50PH6g42q4dd4rbw0DaJBizKZTl6RL4yZrUZUMkCFH1?=
 =?us-ascii?Q?ZbgE0ojR0ycnnhf496MJ4w26NyZ15SpyWAWpvXLsdn8pFrQbBnkMsLkBFiy5?=
 =?us-ascii?Q?iWwbPDRJ9bJ0RsyO+mgVXDFJfLydOhod5jVkv1SIeHMmWe7PInZi+XnMu8sm?=
 =?us-ascii?Q?quUxLIY0t0MQPVyX1uJpPNmNW06IJqQRjyQMvLG4xQDBFZCJx8Z+0OPLBC9V?=
 =?us-ascii?Q?LXi+FCeVAzu9BJK9kjQP/WffAx3TnvNafbNU5RU2MbKZsMxe36PrJC5wjBDU?=
 =?us-ascii?Q?vPg64g/nlhUDW8ppuDsPzWxVLlQjxCNJ20vJxL8Gifi/ZCc3f325pMJMgiBM?=
 =?us-ascii?Q?9xnoglyrVg4vkpC6XRA+lqx1oYmZg21UV0pkABdg49H9cDYdmfXrdEpc1gov?=
 =?us-ascii?Q?BrfhIjFVcu0yop5SkCVZBbNllRTok1ROaZ1gZ3Oxy/sqlJwwjo/UWKmXAptQ?=
 =?us-ascii?Q?dA+tSC2C8VVNOqMeHNj6+A5oz+zZZ1iTZNpuyhw4NfWfUvDEDFGQrdiumgWd?=
 =?us-ascii?Q?AJnnEbXrAKTDkcuo/X/Gr8w4XMDfCcvSExnXGIDYmjCXfsBb5WkDKWQ76MO8?=
 =?us-ascii?Q?6mZo7C2QADPyQWOigZWyOONug7bJiYIFji1DVkWflF4rGHI2zkQYZBAFJHzB?=
 =?us-ascii?Q?JsGX303t0xLLWMUzjrS8A1m4Fx0Y4q5qc40BR4uQDuY+OCk+5GPHLdN1XhJo?=
 =?us-ascii?Q?+B3mpWavPi/4bA7zdNzpFUo0TR4UgKv4pVRbLzCcDP9y9UxPAd7K8uS3Hd3n?=
 =?us-ascii?Q?k1amrZE+/h6VlClQj/1f8ZfJ597RoQBQiGVlo5UatUWZQQcCyahSS9/BW18i?=
 =?us-ascii?Q?i0v/Oz8Lvsu4hhcRere0czTpzbhE0dRCSZLLZhhG43aH16EGJBpqK0/ipnvU?=
 =?us-ascii?Q?iWrNqPKYSIgrfES9uLXQ4XKUjmkjDo6A4WKzljOd+Zj0PSuO+McM8v4JmRIL?=
 =?us-ascii?Q?POXRhlgWdL+J+F0CkG+hyomsCFMOC8HSLp65aEvRPTfZcePKkBqcXN8MP4EV?=
 =?us-ascii?Q?aNqstCW2SNB8CtipnZVWx6NJNtvf3fpw0BheOwat91vfmc0qjB0joNStGSEx?=
 =?us-ascii?Q?L9QqxPA5rH6UHNP5W38UOc6e8/2acO18q5qMG1TXAEd39F1diN4FQvSTuemR?=
 =?us-ascii?Q?l1iWmcV780vCqpozP/mKJ4H67R5G6vBGTw2qiZXA7PtbWrNG/wKLAQ6xqIJL?=
 =?us-ascii?Q?JO81M9u/tm45frbtOZ69K2eP+OlylUYc79z4QlAdcmmI1Wu7Qm1g7UKDKOjS?=
 =?us-ascii?Q?sbZQEEpkrMryMrD5WqmklztCD3zM/jtYOeMAdtbkObALWrAynC/foyvK0ZSX?=
 =?us-ascii?Q?/MPUPa0VSSrJpVTl/aZGAKX3cBndr2op0yuYzQ7EWW/tOXWITGMWJQh/ZWcj?=
 =?us-ascii?Q?qSxNgLs9m6R/sE5i6t/IThZ8xE/KPRChDX+ACyYbnPby9pcoekCWFMsCDNJd?=
 =?us-ascii?Q?uzFvEsX97me4cKONDOAfmudowNBFqe9TDimmDFj69ibuoUxSV1AZ/iJqp972?=
 =?us-ascii?Q?vmp1PabFxLjlAbM9Dm6YQJcn865Ty/3wECURpbaxeBur6J+Pk2YiG4h9z+Ia?=
 =?us-ascii?Q?t1GgD69sfV/98n0YL8o=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3895.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07cdbc42-dc21-407f-fdea-08db1e93a467
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2023 22:39:27.0205
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4kbxftUN0X4PXFKJSyiJdv/mXy4jZBc3veWZLXCr6moK7lRAwXMvs7z0x2/uSRwRuoE3b6bqCjcgTLJjBoBMDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7021
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

 > Mon, Mar 06, 2023 at 04:12:37PM -0500, Asmaa Mnebhi kirjoitti:
> > bgpio_init() uses "sz" argument to populate ngpio, which is not
> > accurate. Instead, read the "ngpios" property from the DT and if it
> > doesn't exist, use the "sz" argument. With this change, drivers no
> > longer need to overwrite the ngpio variable after calling bgpio_init().
>=20
> Thank you!
>=20
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>=20
> Sorry it took a bit longer for us to settle on this.

Thank you Andy!