Date: Thu, 13 Sep 2007 21:19:38 +0200
From: Sam Ravnborg <sam@ravnborg.org>
To: Chris Wedgwood <cw@f00f.org>, Oleg Verych <olecom@flower.upol.cz>
Cc: LKML <linux-kernel@vger.kernel.org>, davej@redhat.com,
       Eric Sandeen <sandeen@sandeen.net>
Subject: Re: [RFC PATCH] Add a 'minimal tree install' target
Message-ID: <20070913191938.GD27146@uranus.ravnborg.org>
References: <20070912232534.GA26868@puku.stupidest.org> <20070913183359.GA27146@uranus.ravnborg.org> <20070913185753.GA9259@puku.stupidest.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070913185753.GA9259@puku.stupidest.org>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1911
Lines: 58

Hi Chris.

Thanks for working on this.
 
> > > +if [ "$srctree" != "$objtree" ] ; then
> > > +    cp --parents $(find -type f -name "Makefile*" -o -name "Kconfig*" -not -ipath "$objtree/*Makefile" ) ${tgtdir}
> >                                                                                                ^
> > Why this wildcard??? (objtree/>*<Makefile)
> > Seems to be a typing error.
> 
> no, it's so we catch things like
> 
> linux/build/Makefile
> 
>  *and*
> 
> linux/build/foo/bar/Makefile
Obviously - I missed the find when I looked.
Thanks for the explanation. And no comments needed in the script -
I should just have read the full command line.

> 
> > > +#rm -rf ${tgtdir}/Documentation
> > Remove this line since it is commented out
> 
> right, actually, it can be uncommented but the 'make help' fails; i'm
> not sure if we need make help to work since most of the other targets
> won't anyhow
> 
> so should i remove it (leaving 'make help' as usable) or remove it?
Un-comment it so we do not break make help.

> > Something less hardcoded are preferred. Maybe like:
> > cp -a `ls | grep -v ^asm` asm-generic $(tgtdir}/include
> 
> ok (though i'm not a big fan of ls | grep as a rule, it tends to be
> fragile when people do dumb things)

find . -maxdepth 1 -! -name 'asm*'
seems to do the trick and it is better than ls.

> 
>     sed -n "s/^ALTARCH[[:space:]]:=[[:space:]]\(.*$\)\+/\1/p"
> 
> (i'm sure there is a better way though)

Oleg (added to mail) - you are quite confident in sed et al.
Let us know if there is a simpler way.

(We want to pick i386 from include/asm-x86_64/Kbuild
and similar for the architectures that uses ARCHDEF).

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/