Date:   Tue, 7 Mar 2023 11:52:52 +1100
From:   Stephen Rothwell <sfr@rothwell.id.au>
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        David Miller <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Networking <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the net tree
Message-ID: <20230307115252.2b23c4f5@oak.ozlabs.ibm.com>
In-Reply-To: <d5b3d530-e050-1891-e5c0-8c98e136b744@gmail.com>
References: <20230307083703.558634a9@canb.auug.org.au>
        <d5b3d530-e050-1891-e5c0-8c98e136b744@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/QZfzygOe5M27vvB.wvaVLQK";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/QZfzygOe5M27vvB.wvaVLQK
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Heiner,

On Mon, 6 Mar 2023 23:16:09 +0100 Heiner Kallweit <hkallweit1@gmail.com> wr=
ote:
>
> On 06.03.2023 22:37, Stephen Rothwell wrote:
> >=20
> > Commit
> >=20
> >   58aac3a2ef41 ("net: phy: smsc: fix link up detection in forced irq mo=
de")
> >=20
> > is missing a Signed-off-by from its committer.
>=20
> Seems to be ok, false positive?
>=20
> net: phy: smsc: fix link up detection in forced irq mode
> Currently link up can't be detected in forced mode if polling
> isn't used. Only link up interrupt source we have is aneg
> complete which isn't applicable in forced mode. Therefore we
> have to use energy-on as link up indicator.
>=20
> Fixes: 7365494550f6 ("net: phy: smsc: skip ENERGYON interrupt if disabled=
")
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>

It was committed by Jakub Kicinski <kuba@kernel.org>

$ git show --pretty=3Draw 58aac3a2ef41
commit 58aac3a2ef414fea6d7fdf823ea177744a087d13
tree 26bf9b3b866bd43baa1b8055d42536ac7ce3b3cf
parent 89b59a84cb166f1ab5b6de9830e61324937c661e
author Heiner Kallweit <hkallweit1@gmail.com> 1677927164 +0100
committer Jakub Kicinski <kuba@kernel.org> 1678137790 -0800

--=20
Cheers,
Stephen Rothwell

--Sig_/QZfzygOe5M27vvB.wvaVLQK
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmQGiuQACgkQAVBC80lX
0GyXywf+N2S0korooYAI10TLOcpdf2nsSWuCLwlezBTU/cqR4cC69Bgzi7i+4vf1
clTfhbWTVBd5aYcIvq4wOWoTuQRoHHcPIVdKPAl+grip7wdPdKHLyngeF7xrTiqJ
DKtDq8cjPMeE6Dhr9bsx9WR18ROAQmRELyU5ZA+hTPKd/KgvXzKrRpFuyz8UBxTc
v1GHZdb5sgTJxISPNWlW3XefsUc4H42ZBHmUy34/fDrW2aTXHGeMmHN8u7R+/L2W
oie70dPm3+KovnnC9lWadkg0/jqH49aW4xDDres3NbRexY+WMT67Dm8gutU78qLm
4D779FSb1NMVRkjhem4H5mAsxPxA2g==
=BX3z
-----END PGP SIGNATURE-----

--Sig_/QZfzygOe5M27vvB.wvaVLQK--