Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3725DC6FD1B for ; Tue, 7 Mar 2023 01:33:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230030AbjCGBdk (ORCPT ); Mon, 6 Mar 2023 20:33:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230011AbjCGBdQ (ORCPT ); Mon, 6 Mar 2023 20:33:16 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22F576C895; Mon, 6 Mar 2023 17:32:28 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C8896B81283; Tue, 7 Mar 2023 01:32:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4280AC433EF; Tue, 7 Mar 2023 01:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678152745; bh=EJo/w9osdGXrw0fp0h5jJPIkK8rkzG76FPt137jlcJk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JpKrN/+QfBTMvJbMTYxCZCpTe+Nl5WEqFHNtuGe0UmoLNoxyofoaECgSqaEruV5nC k18MOaf4llXqmtAJI2MW3cNjt7T1llwq0i/2eSG2o4Wgt6JmCD4nY24TZbr7LCMAuN VPdnQ2dbV1rCQLveEuzrzRal2n2cXNGI9vT36fgHDrrznT38JvoqUDfy+RZ5P2AjHd 5T8YwMzN6qfCrOsHY7Kyq2bXggUInVxUVeQgXYkRWVLWfw5kJEooyUG7gibA9Q70l6 3Ruc7Z9D/WUlqiFr4r8v8g8fNuA0jRPfibtc0cG3dTm1ZTU0Ul55+/CMQxSvF6MJvl RWZr9ADti9ywQ== Date: Mon, 6 Mar 2023 17:32:24 -0800 From: Jakub Kicinski To: Stephen Rothwell Cc: Heiner Kallweit , Stephen Rothwell , David Miller , Networking , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: Signed-off-by missing for commit in the net tree Message-ID: <20230306173224.52afebb0@kernel.org> In-Reply-To: <20230307115252.2b23c4f5@oak.ozlabs.ibm.com> References: <20230307083703.558634a9@canb.auug.org.au> <20230307115252.2b23c4f5@oak.ozlabs.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Mar 2023 11:52:52 +1100 Stephen Rothwell wrote: > > Seems to be ok, false positive? > > > > net: phy: smsc: fix link up detection in forced irq mode > > Currently link up can't be detected in forced mode if polling > > isn't used. Only link up interrupt source we have is aneg > > complete which isn't applicable in forced mode. Therefore we > > have to use energy-on as link up indicator. > > > > Fixes: 7365494550f6 ("net: phy: smsc: skip ENERGYON interrupt if disabled") > > Signed-off-by: Heiner Kallweit > > Signed-off-by: David S. Miller > > It was committed by Jakub Kicinski > > $ git show --pretty=raw 58aac3a2ef41 > commit 58aac3a2ef414fea6d7fdf823ea177744a087d13 > tree 26bf9b3b866bd43baa1b8055d42536ac7ce3b3cf > parent 89b59a84cb166f1ab5b6de9830e61324937c661e > author Heiner Kallweit 1677927164 +0100 > committer Jakub Kicinski 1678137790 -0800 Yes, my bad, sorry.