To:     Ranjan Kumar <ranjan.kumar@broadcom.com>,
        Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc:     Wenchao Hao <haowenchao2@huawei.com>,
        Sathya Prakash <sathya.prakash@broadcom.com>,
        Suganath Prabu Subramani 
        <suganath-prabu.subramani@broadcom.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        <MPT-FusionLinux.pdl@broadcom.com>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linfeilong@huawei.com>
Subject: Re: [PATCH] scsi: mpt3sas: fix NULL pointer access in
 mpt3sas_transport_port_add()
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1mt4pmj8g.fsf@ca-mkp.ca.oracle.com>
References: <20230225100135.2109330-1-haowenchao2@huawei.com>
Date:   Mon, 06 Mar 2023 20:42:14 -0500
In-Reply-To: <20230225100135.2109330-1-haowenchao2@huawei.com> (Wenchao Hao's
        message of "Sat, 25 Feb 2023 18:01:36 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/GyvHyoutPExHFBwU+uS2otmcyXgoq1RzaUlrooC1fx44/vbjhAC6JBu2zOY?=
 =?us-ascii?Q?vNf42//k83dJUMg2/GgcpuNYqQTxeFE+ig1DjrTSTH0UZgjjn+YEmRqZsZPZ?=
 =?us-ascii?Q?DzGKXJllbbnV9XOumANXX1UPNMT6H1gMyUNNGrTky1b0z89GkcmUAwdYADa2?=
 =?us-ascii?Q?tA2YESM6Jq5JxD4ThzIWgx679OgiHPrRtWKF+qs5h2lnEA4Y2UU3p0mbpNFf?=
 =?us-ascii?Q?dRmyrdu+c7H6oxrqwhS4lkQupvO/pp3ODdFEzf6COldrFSupyzTdRQqZQh8Q?=
 =?us-ascii?Q?0tXI4hWe2a+VdrokIQQKdr9NQgrEuXzzDBs2gFhxQ5O3X+Nl13FPGcDl/MDb?=
 =?us-ascii?Q?v2HVf+bcyd6u6LkNfYkjQ/9Qeq/d/1WtVEl1995qZ0sNX6FeTFhUDirYNbNW?=
 =?us-ascii?Q?0w6HBWCDIE+AqYFeNhRej4BXLJmJK/1m3SPaW2i7MOlktYHxKTvxFC9pMFKx?=
 =?us-ascii?Q?NtIYvDnelriU1B8CYPJkBX8MXIfWKkIdaKzTU022oaoqAIfmYN20gJHJwryk?=
 =?us-ascii?Q?IcrcKYRTTaMQs0XIq6y4IfOgosLS3eLUZolDfHSCHMJ+lqSuglxMIbNv9u8f?=
 =?us-ascii?Q?2RgREN+D2fRjQi2G+pA1kEFclCEJL4e67GdgAki+B4R4Y6aZVgRc5YNkQeFl?=
 =?us-ascii?Q?ApziiaEbLZ29AsdUqyxvHTnins+O3TbEqkFG2dJK41Twe8gse+8Xq2bH8CbG?=
 =?us-ascii?Q?bowjvSP23dlFu4UKVyHh/JwUTiSCZ3NTyQnOOlViP9LRpX08lM45H3NILFhu?=
 =?us-ascii?Q?crzj+3KYRuNZ+i28LJrOqFWddN61FNPWmAQuEtNShtQEMGa8J0lZSAsvpRnS?=
 =?us-ascii?Q?E7YFA/GkzH17d2h4+9dC35cB+9cfxO4FQrY/1D06qi+42R2A3oKbM1uWNf5M?=
 =?us-ascii?Q?Ku/osvMwe0ljPO/juraeglM8kVhQvlMZ+nGX78xSMsPAjOv2QMM2rvESPRGH?=
 =?us-ascii?Q?WsK8uJ75ClCG9D+gi3iSYKefGwhwHuGVdM/hXHdd50QCOAottHsfzcWUeQTg?=
 =?us-ascii?Q?GApTgqdRpLa4ONszf60v/DfP5NQBsQBaPx83W4e+IIyiF3sYy9yO4/UYA4ix?=
 =?us-ascii?Q?6z3WKWJx/TBJjzf/blUs7c/GBnTuQxENIUrkitsIXFrLic4Iflcpt8ntjLnE?=
 =?us-ascii?Q?dWHSFWseVGgQo6yjjTO9uVXsOacju+zd1wUD1+rKuD0pqcOW2250EAPesLWv?=
 =?us-ascii?Q?DV55CWZZbqv4eqHMf7JGegr+xsm22HJRwfDM/JvsyF1zF7HZkciBmqZ+D1/G?=
 =?us-ascii?Q?rkBuzWdyzlH/N2QNUDDCKlud6QTwoGdhNVmHpcDfwCE/YwvVKOOQyib686ma?=
 =?us-ascii?Q?na2u3qKOTOXUdjqnNlytDljpzXrpNfkMlAeU7X4zPeo6MEzRGuSQrFGD6Oy0?=
 =?us-ascii?Q?9xlJ1uFHap/Vl5DayYxtTGNv4mN0dgzKfazUFEMsWB78PqX7fqdhzIDVAggj?=
 =?us-ascii?Q?ac/sBXLgCuy+agXsrNoI5WeCEWalg8iy4rKtiJ0CheuZLgVeisqNrr23zo2C?=
 =?us-ascii?Q?X5RNVx1+/J2ga0iJNqrWrPAdthvvEO8UBZLMiyIrTcaglYawVBfMj5qYV3rF?=
 =?us-ascii?Q?XFjjxtA9IYhyBHb5H1JUGY2CUazIgiO7YWgEGgN/lQE9LHkP2HbtUIQ5BvmM?=
 =?us-ascii?Q?ew=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 8p9d/m3S0ysD05dB54ew6JeMmWvlU3DXV9zlx5PghttJIWJB4OiIeJxcmiGYgkFvO3IRLRQFDMQf8R6WVA1bYUZ8mlzY3W8QheJxhAo7D1OQfZ80TVDH1MB/PFukwpVWXLZ7kGV+E8DtUXZU4B1s0+DkWXsrrEWgIH7SAWI2JDtudPZk8wO+Fjq6QT0hMN9SHWUx2+7Tfhgy4H2fvAkozMlk/xiov6XSQ7xt/l7l/RHlMHDty0+qZGU9qYmdS0h2MkEHvzO4CrPrroTNzca30l5GXdQ+hD/sRObaXRTD5zbPwP8CBHtRhjoIFBo9OnUFGWtqj6+mlylRRVQ9gQphNdcp3dLWK40DXkFmv0ipPBs7ZWd+I5evMjGBxQa/jlLBbIIjwJjlOIlQLliecGm/fkSG3k7OSU+1+Iv1Wnjtr+bYySMcbpqM1dTt5n1zjCRQOsKNQDcjaxTAMpfnu7ih/ceknKRS0okXDFRbtm82xkYtxMk/Oanqu5gsUeZTA3W+7d2pq+RSl2cnVq7LMuhXiydJ2ZhI0+w+1O4N4wi7XwkEN/L28Ocp0OBgvUrlm0Ie8qkPFmsZR7N0fbYoEaBri9GshC+2GllUMQs6QPo7iDru6trZCTh3uQAhfsJVg0umsU5DVmrUWoesceFdxD+krwre9NUIhC5akUytOoXHroKVCtOCVcc5SM4Q4bLlXRaKEswLZvAvjKQygieFt9ahI5HedbS1s1tF6mSkNnQ3sWXXOnBR/wVL2GaocKLMa8Sv0ZcWoIBF9PzqdVOi3+qVijAvm0kQF5PLZQdle8lJXwOw+oI3o4wht1aP7A8Gw+uOAi1lbZ5zDjhYsnOMZYDyWiv+qQse8Bnp7XjqDs+tnEM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8de70991-9852-4f36-ab76-08db1ead2f3c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 01:42:17.4986
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uH3zgIyi7RrT5xk+Dlgxy4L1lcU9IofYCiLWaZl7NEE2o5jLC1fmbN7CV5Oux/NxhZAhHPg6L1ntmOv3dxVt5ljQMbF6tnjZNfwszNDdta4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5273
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-06_14,2023-03-06_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 bulkscore=0 phishscore=0 spamscore=0 mlxlogscore=999 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2303070014
X-Proofpoint-GUID: v6RdGBOl5IY_SAFIZQN3fPUu7YpUFELr
X-Proofpoint-ORIG-GUID: v6RdGBOl5IY_SAFIZQN3fPUu7YpUFELr
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Ranjan/Sreekanth,

> port is allocated by sas_port_alloc_num() and rphy is allocated by
> sas_end_device_alloc() or sas_expander_alloc() which may return NULL,
> so we need to check the rphy to avoid possible NULL pointer access.
>
> If sas_rphy_add() called with failure rphy is set to NULL, we would
> access the rphy in next lines which would also result NULL pointer
> access.
>
> Fix commit 78316e9dfc24 ("scsi: mpt3sas: Fix possible resource leaks
> in mpt3sas_transport_port_add()")

Please review!

-- 
Martin K. Petersen	Oracle Linux Engineering