Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From:   Brad Larson <blarson@amd.com>
To:     <krzysztof.kozlowski@linaro.org>
CC:     <adrian.hunter@intel.com>, <alcooperx@gmail.com>,
        <andy.shevchenko@gmail.com>, <arnd@arndb.de>, <blarson@amd.com>,
        <brendan.higgins@linux.dev>, <briannorris@chromium.org>,
        <brijeshkumar.singh@amd.com>, <broonie@kernel.org>,
        <catalin.marinas@arm.com>, <davidgow@google.com>,
        <devicetree@vger.kernel.org>, <fancer.lancer@gmail.com>,
        <gerg@linux-m68k.org>, <gsomlo@gmail.com>, <krzk@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <lee.jones@linaro.org>,
        <lee@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
        <linux-spi@vger.kernel.org>, <p.yadav@ti.com>,
        <p.zabel@pengutronix.de>, <piotrs@cadence.com>,
        <rdunlap@infradead.org>, <robh+dt@kernel.org>,
        <samuel@sholland.org>, <skhan@linuxfoundation.org>,
        <suravee.suthikulpanit@amd.com>, <thomas.lendacky@amd.com>,
        <tonyhuang.sunplus@gmail.com>, <ulf.hansson@linaro.org>,
        <vaishnav.a@ti.com>, <will@kernel.org>,
        <yamada.masahiro@socionext.com>
Subject: Re: [PATCH v10 05/15] dt-bindings: soc: amd: amd,pensando-elbasr: Add AMD Pensando SoC System Controller
Date:   Mon, 6 Mar 2023 18:18:22 -0800
Message-ID: <20230307021822.71245-1-blarson@amd.com>
In-Reply-To: <e82ca6f6-0870-f9b0-172f-bc6d54a9749b@linaro.org>
References: <e82ca6f6-0870-f9b0-172f-bc6d54a9749b@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 02:18:56.8598
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1966c802-c4e7-407d-8915-08db1eb24e47
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT059.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7198
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/03/2023 09:35, Krzysztof Kozlowski wrote:
>> On 06/03/2023 05:07, Brad Larson wrote:
>>> Support the AMD Pensando SoC Controller which is a SPI connected device
>>> providing a miscellaneous set of essential board control/status registers.
>>> This device is present in all Pensando SoC based designs.
>>>
>>> Signed-off-by: Brad Larson <blarson@amd.com>
>>> ---
>>>
>>> v10 changes:
>>> - Property renamed to amd,pensando-ctrl
>>> - Driver is renamed and moved to soc/drivers/amd affecting binding
>>> - Delete cs property, driver handles device node creation from parent num-cs
>>>   fixing schema reg error in a different way
>>>
>>> v9 changes:
>>> - Instead of four nodes, one per chip-select, a single
>>>   node is used with reset-cells in the parent.
>>> - No MFD API is used anymore in the driver so it made
>>>   sense to move this to drivers/spi.
>>> - This driver is common for all Pensando SoC based designs
>>>   so changed the name to pensando-sr.c to not make it Elba
>>>   SoC specific.
>>> - Added property cs for the chip-select number which is used
>>>   by the driver to create /dev/pensr0.<cs>
>>>
>>> ---
>>>  .../bindings/soc/amd/amd,pensando-ctrl.yaml   | 60 +++++++++++++++++++
>>>  1 file changed, 60 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/soc/amd/amd,pensando-ctrl.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/soc/amd/amd,pensando-ctrl.yaml b/Documentation/devicetree/bindings/soc/amd/amd,pensando-ctrl.yaml
>>> new file mode 100644
>>> index 000000000000..36694077b2e6
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/soc/amd/amd,pensando-ctrl.yaml
>> 
>> Your subject suggests this is pensando-elbasr but you write everywhere
>> pensando-ctrl. Confusing. Pick one.
>
> Actually pensando-ctrl is for sure not correct, because it misses the
> name of the SoC (you call it everywhere "elba").

The reason I dropped elba as part of the name is this driver and its associated 
SPI attached device (cpld or fpga depending on the board design) will be used
across a series of SoCs starting with Elba.  Implying its Elba specific is misleading.

Regards,
Brad