Message-ID: <7c721c17-1d72-5fbc-4d69-d8d6bc12b404@amd.com>
Date:   Tue, 7 Mar 2023 08:49:54 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 1/2] perf/ibs: Fix interface via core pmu events
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     peterz@infradead.org, eranian@google.com, acme@kernel.org,
        mark.rutland@arm.com, jolsa@kernel.org, irogers@google.com,
        bp@alien8.de, x86@kernel.org, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org, sandipan.das@amd.com,
        ananth.narayan@amd.com, santosh.shukla@amd.com,
        Ravi Bangoria <ravi.bangoria@amd.com>
References: <20230302092109.367-1-ravi.bangoria@amd.com>
 <20230302092109.367-2-ravi.bangoria@amd.com>
 <CAM9d7cjEvjcYwjA+HfsDHKDX8FGZCECTZ8vDMPHBUSqfQSCOfA@mail.gmail.com>
 <c5f1c3c2-6de3-a40d-9cf0-c1c7638acfc3@amd.com>
 <CAM9d7ch9OsFz9N71QG5DOyygctK+bVAFGQByUGAvy=d29rzWZg@mail.gmail.com>
Content-Language: en-US
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <CAM9d7ch9OsFz9N71QG5DOyygctK+bVAFGQByUGAvy=d29rzWZg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXRQeHIrSzJyNDJLcG5FbDF5eU43RWUzWXlRaFNEWi9POXFxMTZXWlMxUll2?=
 =?utf-8?B?Q2tlZnhxNkJUNzFKYXZVMDRxMmQ4S3pHZlFVeGVzVy9NU1hyTEpyM3BtWEJ2?=
 =?utf-8?B?TFNLN2xSSXYxa0hiYTZpSXRuM3p0NVhubzZnN0xVM3FPUHJLUEpna1VHZWFB?=
 =?utf-8?B?NjdMOUc1ZGhXUkQ5ZDdQN3NtMWpxcko4SkhrWUV1MzdCNVF6bW5RdVhQbzVW?=
 =?utf-8?B?NXJZRHhVU2k2ZXNUQ29ET2hqeVhWUXpMWDBRZ1VKaktIbWwxcE9ia2NjdC9u?=
 =?utf-8?B?ZGljTzFHMkwxK3RYVG9mZHZpdGVjbEhWSEFmUU5Sc3U0SFVESWhmZ0E4dUdq?=
 =?utf-8?B?UWdBWHlwUzgzY00vL28vUFBqclRHeGgyWThUUllxNEhXZnlCcmdVTVoxdWZ2?=
 =?utf-8?B?eC9oMFNTY2RoVjFXb1pUR2xDb1RoblpOQnduV0htbWNxVjdFRkFDNlkwYVNK?=
 =?utf-8?B?QnEyaGluTUNvT0NoV1lvVVpDYjdkVGlPMSsvcC9HRnpYT0p3aUtteWZ2ZnJJ?=
 =?utf-8?B?Mmo2aEgvWTRtSzVkSjA5NDhySEhaL2tVMWxyYTdyRUVxWkoxd3BGZlJiRjd2?=
 =?utf-8?B?TlRWSXFGMVA0YzQwKzhQc1VMaUVwZUNQM3NmemZBYTR1alYvdXBmNlliTUVs?=
 =?utf-8?B?Q25wNEVKWFhUMUg4UnN1OStCU3JHSEdHcERjR3dFcTM0YkpESFVrVUNrQmxz?=
 =?utf-8?B?TTNaRVVrMHFkRVI1cjQ5V3FKQnlLeUgyS0l1WkJ3c09hS3ZtMjE4V2lkWk5I?=
 =?utf-8?B?S3VGMU9OYWRwZndZU1IvUEFLb2pwYmpJRWtJMnc3VmxWNS8vSDRQbW1ld21q?=
 =?utf-8?B?WXpFaFBDakhwdWtURUtrdGZqdUlNTkh5TnNtcWdoUEFOM1h1UDN1eUxvdFEw?=
 =?utf-8?B?NGxMVGJoRjlZKy9icWZER09CQmhJR0trdklKaDVoWDZMQnhiYXQ2TUp2WFRa?=
 =?utf-8?B?cmUvb3prQlRiYTdWR0JsN0dSbDhHQThpM3paVDVnZmhFQlJRK3ZLUE9ucDM5?=
 =?utf-8?B?WkVMTG1GUDhqWDB3RFBjMnJicGhpWG4xa0UvbitkMGxucERaYlJuTXVnd0tZ?=
 =?utf-8?B?cDE2SzBBWUJubnpWUWF3NHlKOXlWc29YRWdpOGEzWjQrTEJsTW1oYjFqWmdJ?=
 =?utf-8?B?NjlpR0wwbkYraVNtVUF0eXloK2lpdU5mZEpaTFVhZGRORVN1L01IclkyWHNs?=
 =?utf-8?B?OHIzdUpBK3ZidUhJQjNSS3Jpc2VacVcyZXlrZnRKdjI3cWV6djVZdHI1V3pL?=
 =?utf-8?B?WFZVUTVvS1RhTTAvRkdlR1JJR2U4SXVFaC93SlVhaVIvUzlNeHpBdFFocHlw?=
 =?utf-8?B?dXc1dkplQlNiY2svUHVJemNjVWphSVZ3MXpHWGJCaE16NG5KcWNPU0xHMWtZ?=
 =?utf-8?B?NHJOUnFDUWRpS2FGNVcvek81UUZvTW4zcGV4VWlmcmFhVzJFRzVMWVR5cDRo?=
 =?utf-8?B?dWQwOGlnM3YxMHBkRkl4bUI5ZVk1WDcrbU5wRGgyeHgrcXJueCtYa29yQXBT?=
 =?utf-8?B?VTdyY2VvUVRhNWRDb05YQjArNTM1dzVDUVNZZVFMYkQ4NXh6ZmtYM2d5WGhr?=
 =?utf-8?B?cmVkN3F5UFJlbnJldmJDZnFacUJ2NTFXUHMrZE4ybHd5MmZkRk1mWkdablFY?=
 =?utf-8?B?enNOZnFFOGgvRWxNOVFlZDhlb25HdERIdk5QeFJ6SzhYeFRKTWozRTBUZ1Z2?=
 =?utf-8?B?V25rZU5aZU8zQlg2cExzSFRxcEdKdE5jd2hHdDk4aC9SQk5QS0lCdEVRQlpW?=
 =?utf-8?B?L1pmRkJvdnppK2VWTEdLalJadjdJUTY4cWIrSWVtNWhUbitWbEZEVzh0OFU0?=
 =?utf-8?B?dEM5MVBSOTZjY1JNQVk5UElSaXpkNWFrV2x2ci9KajVZd0x6Y1cwbWxTb0xp?=
 =?utf-8?B?UWJxRHE2VEl0SVY3UzBmWWdNQjJYS1VvZVN3bXA4RGVkOS8zYXZHcmc1b2c5?=
 =?utf-8?B?ZXhHcS9JMVRORXFYTUkrNHlNZFBLZ1ZlUE83cmlLMGpOdXNOVzQ3SWFWVldX?=
 =?utf-8?B?ZGNCMWhzVGpVY0JuTUk3WDh4Mmg5Z2llUCtDOS9XYWtuTW5ZYXZkVWVKeXFy?=
 =?utf-8?B?clNpR3grSDRDOE9tS3NsWVhFVW05QzVldzZ2a3U3QUJhQTJmN2kyZkp0YnRV?=
 =?utf-8?B?UzNQRjdJWjFhVkQwRk9OWTQrSVdXRTh3Q0hibEpKcUFRalFnOHN2MktuaEw0?=
 =?utf-8?Q?309o1kVbOajESnlZr62mZ0wKX8gUP/nd2YMfQMDVwFt0?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 518a546b-75bc-47b6-46ae-08db1ebadcd9
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 03:20:12.6669
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FBRwtzX2RSBOMCBdhmfTXadnElbb5/SYC/q7XlcFmieFuhhzkXX05pcGMpQKP+ASS68tZ5ZW+nLoX4YS/cAMZw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8915
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07-Mar-23 3:59 AM, Namhyung Kim wrote:
> On Thu, Mar 2, 2023 at 9:54 PM Ravi Bangoria <ravi.bangoria@amd.com> wrote:
>>
>> Hi Namhyung,
>>
>>>> diff --git a/kernel/events/core.c b/kernel/events/core.c
>>>> index a5a51dfdd622..c3f59d937280 100644
>>>> --- a/kernel/events/core.c
>>>> +++ b/kernel/events/core.c
>>>> @@ -11633,9 +11633,13 @@ static struct pmu *perf_init_event(struct perf_event *event)
>>>>                         goto fail;
>>>>
>>>>                 ret = perf_try_init_event(pmu, event);
>>>> -               if (ret == -ENOENT && event->attr.type != type && !extended_type) {
>>>> -                       type = event->attr.type;
>>>> -                       goto again;
>>>> +               if (ret == -ENOENT) {
>>>> +                       if (event->attr.type != type && !extended_type) {
>>>> +                               type = event->attr.type;
>>>> +                               goto again;
>>>> +                       }
>>>> +                       if (pmu->capabilities & PERF_PMU_CAP_FORWARD_EVENT)
>>>> +                               goto try_all;
>>>
>>> Wouldn't it be better to use a different error code to indicate
>>> it's about precise_ip (or forwarding in general)?  Otherwise
>>> other invalid config might cause the forwarding unnecessarily..
>>
>> That would make things easier and we might not need this new capability.
>> Most appropriate error codes seems ENOENT, EOPNOTSUPP and EINVAL but all
>> are already used for other purposes. Any other suggestions?
> 
> Maybe we can have more liberty for the error code since
> it's not returned to the user.  How about ESRCH, EIO or ENXIO?

Ok. We can probably use ESRCH, although it's meaning is little different:

  $ errno -l | grep ESRCH
  ESRCH 3 No such process

Thanks,
Ravi