Message-ID: <1abaf06a-83fb-8865-4a6e-c6a806cce421@nvidia.com>
Date:   Tue, 7 Mar 2023 17:19:35 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH RESEND net-next v4 0/4] net/mlx5e: Add GBP VxLAN HW
 offload support
To:     Alexander Lobakin <aleksander.lobakin@intel.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, roopa@nvidia.com,
        eng.alaamohamedsoliman.am@gmail.com, bigeasy@linutronix.de,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        gavi@nvidia.com, roid@nvidia.com, maord@nvidia.com,
        saeedm@nvidia.com
References: <20230306030302.224414-1-gavinl@nvidia.com>
 <d086da44-5027-4b43-bd04-29e030e7eac7@intel.com>
Content-Language: en-US
From:   Gavin Li <gavinl@nvidia.com>
In-Reply-To: <d086da44-5027-4b43-bd04-29e030e7eac7@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2NaNVJEbVFQOE16TEYxdUhXSXF3RDV3dUppeUVTbXNOYkl4Tm1yRHUyUDZF?=
 =?utf-8?B?UlE2UDVyQ0xjY2E5TEhaVHJ4a2xYdFlPS1lMSncrMkU0SHJ2RzJoQjVwVzJw?=
 =?utf-8?B?WmlsaWh6ZnpDUDVtZkNkSTNHZTZ6RTZpN1M4eXlFajYrNmRTZVEwSUhQZ2N6?=
 =?utf-8?B?WGpMWlBObE1HWVF3T3JSb1kzUWlJYnpkMmxCMTZ4RHpZRGxQOGxMZ2FzODdN?=
 =?utf-8?B?R1RhOHpsalZzNnJ2MnQzYmpUSS9yZk1jUVlZVnJFR1YybmdQV3FWbHlEeVVI?=
 =?utf-8?B?OTJBVjVjYVNXTlUxc1VSRUZ1Qkk4UWxHSjBlcitkejJMY3FYSlZJd3Z1Kzdr?=
 =?utf-8?B?d3lNZWdzK2hPaEtKUW9RZnR2MWE4NGpGL3hYYmo2VFFOdVN2NnFaRmVlendN?=
 =?utf-8?B?T0lrRXBRTWl2QVVidzF3QmxjQlo0bVU1eS9hREtRMU9ieDY4dldGS2JBbFNm?=
 =?utf-8?B?WlNzSkxGVHk1bTlleFR0bXQzamVDNnJQV3hmeTFkVVJUbmNmcXdVUWhpa1RN?=
 =?utf-8?B?L0JZRk5ldnZFL1lPOTZaOWRDdERXdXI5K2hUdXdmT3JPemJLMU44Z1d1VGQ3?=
 =?utf-8?B?bVpZVnNWdm5xcDRicStib1dCcHIzMHJxUDVqaTRpZFNhR3p5SnI2YWJPcTFU?=
 =?utf-8?B?b1hLOUVGeXRiS0psMk9VVndZTURTM0JqSTEreVdTeHRub2xQUllKblZpL2hu?=
 =?utf-8?B?Q01IWmI0S2Jwd1AwRWgxS3RrTWV3TjNieVF1SW1GMENwN3VQZDI3RW5WaXdx?=
 =?utf-8?B?YTR4MkdjcmhkclZvMzdneGxLbE91M2d0dS80V2JvUlFxUjY4aElSTHg4RzNt?=
 =?utf-8?B?TldDZTZIdlpqdkhDTjVlWCtSTVpEZ2w0OWM4eXRoL0ZlUUpnS3d4ZkpoN0Ji?=
 =?utf-8?B?UEJaSmYybDNLQ0J6cllwcHRDV3dJbFJaSjFZUVRscUZCMXNEOXovbnc3ei9F?=
 =?utf-8?B?ai9DcVI4ZVQ1bEdXbnJTSzloaHc2MXJUUkV4azJmeWZUSXZhbElHWFA1OXVZ?=
 =?utf-8?B?eWJoaW93eVJCZVJKaHRmZ3lYdWZVSFFPL2cyVWtaZ0N3WVNhUXEvRWFOTzdE?=
 =?utf-8?B?THo3NHRuZVRPR3FZSHptZ0dVRmhsSUFHS2FicjUrSWN1Tjl2TVgvV3NDeDZT?=
 =?utf-8?B?TytCV2lqajU3Z1BIbnppQUMxVFNjbmJkUHptNVNIOVplRTE0QVJFSGVSKzVP?=
 =?utf-8?B?Z3dXUlN4RWdxUTN1MTQydnBCVVhLZDdaZjlnaXFsR1NNZDlBWmVyellIQU9I?=
 =?utf-8?B?a3BOczdEcEw3cXNoLzZlY1RrRFFoaThEajNvZURlVXhSMTB5OUpHQjFxUDY1?=
 =?utf-8?B?Q2ZmaXpxMytCTElJLzZPSFZlOWw3TTNhVjN1WVl1Zmk4YUY4TFUzZnR3SVUv?=
 =?utf-8?B?Z0h2aFRqc3VFVkRoZm5iQ3JJc0hveFRiSCt1TG9KamE4MmxzNjh6ZVZ5WjhY?=
 =?utf-8?B?eDJYNW5ES2FyN0ZJSzNmVHlqbE1hbElDbkV6Rk1tY2ErTDA2UVl6WG1oLzFo?=
 =?utf-8?B?aGljRSt3NktteEtEeWhmL2pIRCtjdFRJYlhKam5RQzRKSHpMNUMwNFI2d1Z3?=
 =?utf-8?B?em9TODAwSDJuN0xWenZhYjdNQUJqelJuOFNzTzR3Y3NCMjlRNEpwNWlic201?=
 =?utf-8?B?bWkvMEtGUzBiRkhDMk9vYktHZDJwMFdqVUY0NmxXS0dKT1JZeGE2ZmUxOW83?=
 =?utf-8?B?NmxPUURiQXIzZjFheVJ1emFReTJsWnl0MjFQSWJsS0FXU0t6NkpGcU5ONnU0?=
 =?utf-8?B?akRRMmNmMitnc2ZRZC80elhtUWc0QjhFR2dDS1YycE5XZGl2SlZSUG9Eek8w?=
 =?utf-8?B?Vno5MGFRbllQckxrSUdaUVlZblUrdkVIVmg3TTQ3elZsTzhHMGVmU0FlSHFo?=
 =?utf-8?B?L2tNZEMzNzFxbUJWeWhjWmVac3p0cVM5OTZ3WnBrSVpVYzNZcUNpeStVMHIv?=
 =?utf-8?B?ZHYxa012SEE5WlVEd3lhYWh6bDB2SnF2eEFjcVE5bzBYb0ZyNWdPaUlHMXpE?=
 =?utf-8?B?M2RBeHArcTF0Ty9UYVJaRFhXMzJUbjRhV01xV1llT3RycldNWktrQi9hUFNI?=
 =?utf-8?B?a2VkSFJYTUVLR0p2cGZlMW95TVM2eXpUK3Zpd2JyTnZhVWNuZzJRVDd0ZzZj?=
 =?utf-8?Q?Uclgu3vN9gx3MVHCHVFpfRMzC?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ad9e80e-d8bd-4dfd-a52d-08db1eed1b09
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3835.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 09:19:51.5256
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rXH0cHVgMM7IkffirpU0YNWwxE5pgA9eb5QQnP9TNBu7bYwDl3G8olcEZmSM6KxR8szV6p6MxuH32R+p2EuG4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7302
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/6/2023 10:47 PM, Alexander Lobakin wrote:
> External email: Use caution opening links or attachments
>
>
> From: Gavin Li <gavinl@nvidia.com>
> Date: Mon, 6 Mar 2023 05:02:58 +0200
>
>> Patch-1: Remove unused argument from functions.
>> Patch-2: Expose helper function vxlan_build_gbp_hdr.
>> Patch-3: Add helper function for encap_info_equal for tunnels with options.
>> Patch-4: Add HW offloading support for TC flows with VxLAN GBP encap/decap
>>          in mlx ethernet driver.
>>
>> Gavin Li (4):
>>    vxlan: Remove unused argument from vxlan_build_gbp_hdr( ) and
>>      vxlan_build_gpe_hdr( )
>> ---
>> changelog:
>> v2->v3
>> - Addressed comments from Paolo Abeni
>> - Add new patch
>> ---
>>    vxlan: Expose helper vxlan_build_gbp_hdr
>> ---
>> changelog:
>> v1->v2
>> - Addressed comments from Alexander Lobakin
>> - Use const to annotate read-only the pointer parameter
>> ---
>>    net/mlx5e: Add helper for encap_info_equal for tunnels with options
>> ---
>> changelog:
>> v3->v4
>> - Addressed comments from Alexander Lobakin
>> - Fix vertical alignment issue
>> v1->v2
>> - Addressed comments from Alexander Lobakin
>> - Replace confusing pointer arithmetic with function call
>> - Use boolean operator NOT to check if the function return value is not zero
>> ---
>>    net/mlx5e: TC, Add support for VxLAN GBP encap/decap flows offload
>> ---
>> changelog:
>> v3->v4
>> - Addressed comments from Simon Horman
>> - Using cast in place instead of changing API
> I don't remember me acking this. The last thing I said is that in order
> to avoid cast-aways you need to use _Generic(). 2 times. IIRC you said
> "Ack" and that was the last message in that thread.
> Now this. Without me in CCs, so I noticed it accidentally.
> ???

Not asked by you but you said you were OK if I used cast-aways. So I did the

change in V3 and reverted back to using cast-away in V4.

>> v2->v3
>> - Addressed comments from Alexander Lobakin
>> - Remove the WA by casting away
>> v1->v2
>> - Addressed comments from Alexander Lobakin
>> - Add a separate pair of braces around bitops
>> - Remove the WA by casting away
>> - Fit all log messages into one line
>> - Use NL_SET_ERR_MSG_FMT_MOD to print the invalid value on error
>> ---
>>
>>   .../ethernet/mellanox/mlx5/core/en/tc_tun.h   |  3 +
>>   .../mellanox/mlx5/core/en/tc_tun_encap.c      | 32 ++++++++
>>   .../mellanox/mlx5/core/en/tc_tun_geneve.c     | 24 +-----
>>   .../mellanox/mlx5/core/en/tc_tun_vxlan.c      | 76 ++++++++++++++++++-
>>   drivers/net/vxlan/vxlan_core.c                | 27 +------
>>   include/linux/mlx5/device.h                   |  6 ++
>>   include/linux/mlx5/mlx5_ifc.h                 | 13 +++-
>>   include/net/vxlan.h                           | 19 +++++
>>   8 files changed, 149 insertions(+), 51 deletions(-)
>>
> Thanks,
> Olek