Message-ID: <22501426-2271-2f54-a80e-920ad5461d4f@nvidia.com>
Date:   Tue, 7 Mar 2023 17:22:34 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH RESEND net-next v4 4/4] net/mlx5e: TC, Add support for
 VxLAN GBP encap/decap flows offload
Content-Language: en-US
To:     Simon Horman <simon.horman@corigine.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, roopa@nvidia.com,
        eng.alaamohamedsoliman.am@gmail.com, bigeasy@linutronix.de,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        gavi@nvidia.com, roid@nvidia.com, maord@nvidia.com,
        saeedm@nvidia.com
References: <20230306030302.224414-1-gavinl@nvidia.com>
 <20230306030302.224414-5-gavinl@nvidia.com> <ZAYBbP8HCXf/DHdn@corigine.com>
From:   Gavin Li <gavinl@nvidia.com>
In-Reply-To: <ZAYBbP8HCXf/DHdn@corigine.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUZhNEQyVERTczM4em1CZitmd3VtdW1VdmFOVUF4Y2hXbkpPbHN6VkNXV05Y?=
 =?utf-8?B?a1h1Qi8zUTR0djZkeTdhMFo3bU1oRlA1bzFLNXJNMUJtNGdqSWVFK2Y1SHRs?=
 =?utf-8?B?SytlWmxVQUpWZXJXSEdRKzduSndsS3ZqUThCU1B4OFNIZFZ6SFNMVkdYdzM0?=
 =?utf-8?B?UmcvRmdKNVBTbEYzdFJ3QndFMWpyclRuQUl2YnZyenFQbDF4NFJyaWM1djRz?=
 =?utf-8?B?Q3REVTM1WGRUSjVsZzF6MnE5Ync2N0lRVmc5SWo2QUljM0VPekU1TjlHS2Ir?=
 =?utf-8?B?ZlljN1lYYy83eldqb3dMMkdvVXNqUWQ4OG9jc254VmxyYmNaUUxNeHAxcGtG?=
 =?utf-8?B?NXV5ZjFOZnV4WjJveWUxRWRqMzY0ZWRuSXhzSWdRTVFsVmxtOG5iU0M1eWFL?=
 =?utf-8?B?YTMrc1k5bXoxaU5oWHcwSnlSdmR6dDFFTG1VREplMFU4UnJEQ3k5R2hodkg1?=
 =?utf-8?B?eXJ3YWF5RCtTVUR1cmJkUGtBTU5JMzdCMlYvS1FnTDBlYVhha2VFZjJBdDUr?=
 =?utf-8?B?TVFVK3lLTitDYklHVGc2N2Q4Tkh4TnM4OEF1bmo3UzdFZGNUVDhxWUVpRlMx?=
 =?utf-8?B?b1IvQTZMV2Z3QlZtWDZrV1E5WTdtZHY0dDVwNUV2U3cvMmtwMmJwOXp4MlNN?=
 =?utf-8?B?eElIL0hua21zNnd4TGFVVWt0enlDQkxhRGRzM09Wd3B3L1JocU90RnRXMGtj?=
 =?utf-8?B?QjJBYWFWMWoyRjdwdm1rMU5OVVhudWJJZkJpMGFrNDFzanNkL21JV3FFRk94?=
 =?utf-8?B?bFdrU0NFeWhUdDFkTkNWK1JRSzcraitIdWVRcGxEeVRJdjkvZUZpeFdxMVAv?=
 =?utf-8?B?M25EdlRadGNuT25Mb3lBblBHMDRPaW1IcWRxd1pEMUI0QmVZMUJjRTBNSjJ0?=
 =?utf-8?B?RFBZaGNkTitJajBIazFNaFQ4cTNFZXRBYU85cWtLbVlwWEVoT29aWXJPQllv?=
 =?utf-8?B?d05PcmxKSlVlbVNDa0NudkVoU0UzRGRLMUhqM1d3Ti9qQmZPTHRhWisydWJP?=
 =?utf-8?B?ZTVrMnY5em9hTTFxTU1ZT1ZudDNOWks1QUlGckRsSjVkcmRjbEJEdVJ5NnZZ?=
 =?utf-8?B?UUNpdGtpM0xrL3JPdlpNVXFGK2lOL2JHa1lNdHdxeTViQzVhRVJJeFJ5WkZ5?=
 =?utf-8?B?bi9OcTJXSmlZMC9qaklNSnVucUJxZG53V1h1cXRJVldIekJKNW40VHM2UHBN?=
 =?utf-8?B?TEcyWDcwQXJzaUl2VFFHc0k2WVRsRGpFTUw3ek9YVFJ5LzEwTlFibVkvaERQ?=
 =?utf-8?B?MWtEWWJVK0djRkRYZDZaNy9TUEVRcWF1MmtOWDVGSmZVQSs4b3lSelpSeXZ5?=
 =?utf-8?B?Z28rOGg0RGxTeUVSaEV1VG9qZGErSjJ0czBjNWJ1Yk9tbzlMckhhL01qMUJX?=
 =?utf-8?B?KzZ1RnZpLzlRZG5PN2E2VDZsSkQxVHUxQjVlYThYTnB2NGxqNEdyaW81N2dz?=
 =?utf-8?B?SFFaVExEaU1zMkF2Z1YvNEFLcDFsWWUrT1J5Z2lhYkdBemFiRUp1ck8xVHdQ?=
 =?utf-8?B?T1Y0WjFaY283WWMxZVIyUk9QSHRidUlZK0cwY2lIZyt5NkxxR0dBWktac25I?=
 =?utf-8?B?czcxOTRPcEJTcG1GV3pGTGdTSEtoZWNBM2srblZEWHNmaS9TUlorVWdBUWNp?=
 =?utf-8?B?MWhaYXJ4TEFhbi9pNXcyY0x6VVlGRjRzSktHV1oraDUzUnlmNFk2Q1VNTW01?=
 =?utf-8?B?NVhkMTg4VlJLSjRHbDkrWGU5cEQzSld2TWk5SGhERTR6TWFNZkJxd21rRkFU?=
 =?utf-8?B?MmhlVlFnSmI1V2FZOFM5UlRFUXRWS0gvdjJXVWRWSXFpN0pjUkVWNlhaMEVM?=
 =?utf-8?B?RlF5OXg5RmFFcE1UZGx2cVB0SGludVZOc3BPL1Z0QXEyMnlTekNWZXg2Rzhi?=
 =?utf-8?B?VWpVSENNY0grNE1EeFEyVU5QSnJZOUlxWXRoMW9sRXFsMHB0Z2I3N1d4NVYw?=
 =?utf-8?B?d045MzJyc284TXBXNGVybzhNYTAzUEU3SWVjckhXWG1GQkdXQWNSZVJwNWRh?=
 =?utf-8?B?SnJPbTJ3ampuS01sZFF4S3I0ZXZWVmg5SmFCcW9Qby84Nkk0bXkvVXpLaStB?=
 =?utf-8?B?RG1BMytTN1hCY1Y1YURaQnpGK29DNHdqbDFiOUdaaGYvbUxtN0tBdGxvcFVj?=
 =?utf-8?Q?OZyesH7OxMKAuGTVX4b5DJOC3?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2cc81d2-b7bd-46a3-763b-08db1eed8691
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3835.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 09:22:51.8069
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0R7pqz4OkghonnMJQER+i3Ch3oWRq5y2iIRJ+Nup3uDR7c4eQx0QHPXXcn38TpKRvT91MH6WQEjtO3Mu/7l2/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7302
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/6/2023 11:06 PM, Simon Horman wrote:
> External email: Use caution opening links or attachments
>
>
> On Mon, Mar 06, 2023 at 05:03:02AM +0200, Gavin Li wrote:
>> Add HW offloading support for TC flows with VxLAN GBP encap/decap.
>>
>> Example of encap rule:
>> tc filter add dev eth0 protocol ip ingress flower \
>>      action tunnel_key set id 42 vxlan_opts 512 \
>>      action mirred egress redirect dev vxlan1
>>
>> Example of decap rule:
>> tc filter add dev vxlan1 protocol ip ingress flower \
>>      enc_key_id 42 enc_dst_port 4789 vxlan_opts 1024 \
>>      action tunnel_key unset action mirred egress redirect dev eth0
>>
>> Signed-off-by: Gavin Li <gavinl@nvidia.com>
>> Reviewed-by: Gavi Teitz <gavi@nvidia.com>
>> Reviewed-by: Roi Dayan <roid@nvidia.com>
>> Reviewed-by: Maor Dickman <maord@nvidia.com>
>> Acked-by: Saeed Mahameed <saeedm@nvidia.com>
>> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> FWIIW, I did provide a Reviewed-by tag for the other patches in this
> series, but I don't believe I did for this patch..
ACK. Will remove in V5