MIME-Version: 1.0
In-Reply-To: <48975544-9b5f-eb2a-e2a2-f0ffa537aa1c@huawei.com>
References: <20230302135804.2583061-1-chenxiaosong2@huawei.com> <48975544-9b5f-eb2a-e2a2-f0ffa537aa1c@huawei.com>
From:   Namjae Jeon <linkinjeon@kernel.org>
Date:   Tue, 7 Mar 2023 18:27:31 +0900
Message-ID: <CAKYAXd-3t6W1fv128D7LDcusZcabJdq3D6eq3ndE9_gP+PsVqg@mail.gmail.com>
Subject: Re: [PATCH] ksmbd: fix possible refcount leak in smb2_open()
To:     ChenXiaoSong <chenxiaosong2@huawei.com>
Cc:     sfrench@samba.org, stfrench@microsoft.com,
        linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2023-03-07 17:52 GMT+09:00, ChenXiaoSong <chenxiaosong2@huawei.com>:
> Hi Namjae and Steve:
Hi Chen,
>
> Do you have any suggestions for this patch?
Sorry, It was in the spam box...
I have sent ack. Thanks for noticing.
>
> =E5=9C=A8 2023/3/2 21:58, ChenXiaoSong =E5=86=99=E9=81=93:
>> Reference count of acls will leak when memory allocation fails. Fix this
>> by adding the missing posix_acl_release().
>>
>> Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
>> Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com>
>> ---
>>   fs/ksmbd/smb2pdu.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
>> index 0685c1c77b9f..f04d810a2588 100644
>> --- a/fs/ksmbd/smb2pdu.c
>> +++ b/fs/ksmbd/smb2pdu.c
>> @@ -2977,8 +2977,11 @@ int smb2_open(struct ksmbd_work *work)
>>   							sizeof(struct smb_acl) +
>>   							sizeof(struct smb_ace) * ace_num * 2,
>>   							GFP_KERNEL);
>> -					if (!pntsd)
>> +					if (!pntsd) {
>> +						posix_acl_release(fattr.cf_acls);
>> +						posix_acl_release(fattr.cf_dacls);
>>   						goto err_out;
>> +					}
>>
>>   					rc =3D build_sec_desc(idmap,
>>   							    pntsd, NULL, 0,
>>
>