Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21A32C678D4 for ; Tue, 7 Mar 2023 09:43:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229706AbjCGJn5 (ORCPT ); Tue, 7 Mar 2023 04:43:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230437AbjCGJnp (ORCPT ); Tue, 7 Mar 2023 04:43:45 -0500 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70E1F8A39E; Tue, 7 Mar 2023 01:43:32 -0800 (PST) Received: from booty (unknown [77.244.183.192]) (Authenticated sender: luca.ceresoli@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id EF9851C0005; Tue, 7 Mar 2023 09:43:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1678182210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=01+uAnOiSLbTM0wZcSQJcnuJqtQP5yT5es3lE/RNx8s=; b=W0FOXboaN+ZfaE1tOFAvB0nH9CZUt2e57a9f90MZdoalOOiRKe0aTlMaeJ30NwVZqfyo7Z E7WglxyOR0vU8/phJe7AxiQe+XKeN5p2ay7pUIouDSX2Ay0fBGasMnn9/cSzAtIjyXvIQJ Rh4itmk/epniRXUBvtOCitKQ2WBfhBnYYLsISU4V8mS/NeEvdFBoWqyCIlFUXbetFBE4qd nqOOcIBvSesXGNQcH5WFlReYR0+9moZA4Qmn1GzlWA6Do6HpxR0cQvHIqFwiQwhzrl9oR6 prAQn9sFF5bs4Bnu/mh0mzYOUwG2LOouY+sy65380JLuYEXYQye9zegYfMJQrw== Date: Tue, 7 Mar 2023 10:43:24 +0100 From: Luca Ceresoli To: Johan Hovold Cc: Georgi Djakov , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "NXP Linux Team" , "Andy Gross" , "Bjorn Andersson" , "Konrad Dybcio" , "Sylwester Nawrocki" , Artur =?UTF-8?Q?=C5=9Awigo=C5=84?= , "Krzysztof Kozlowski" , "Alim Akhtar" , "Thierry Reding" , "Jonathan Hunter" , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Alexandre Bailon Subject: Re: [PATCH v2 04/23] interconnect: imx: fix registration race Message-ID: <20230307104324.121166d1@booty> In-Reply-To: <20230306075651.2449-5-johan+linaro@kernel.org> References: <20230306075651.2449-1-johan+linaro@kernel.org> <20230306075651.2449-5-johan+linaro@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Mar 2023 08:56:32 +0100 Johan Hovold wrote: > The current interconnect provider registration interface is inherently > racy as nodes are not added until the after adding the provider. This > can specifically cause racing DT lookups to fail. > > Switch to using the new API where the provider is not registered until > after it has been fully initialised. > > Fixes: f0d8048525d7 ("interconnect: Add imx core driver") > Cc: stable@vger.kernel.org # 5.8 > Cc: Alexandre Bailon > Reviewed-by: Konrad Dybcio > Tested-by: Luca Ceresoli v2 works just as well, so my Tested-by is confirmed. Maybe it's useful mentioning the hardware used for testing so: [Tested on i.MX8MP using an MSC SM2-MB-EP1 Board] Tested-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com