Message-ID: <9ce5434e-4c19-cb34-d3fa-99738c265b03@redhat.com>
Date:   Tue, 7 Mar 2023 11:22:16 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] selftests/mm: fix split huge page tests
Content-Language: en-US
To:     Zi Yan <ziy@nvidia.com>, Andrew Morton <akpm@linux-foundation.org>,
        linux-mm@kvack.org
Cc:     linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        Shuah Khan <shuah@kernel.org>,
        Zach O'Keefe <zokeefe@google.com>
References: <20230306160907.16804-1-zi.yan@sent.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20230306160907.16804-1-zi.yan@sent.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 06.03.23 17:09, Zi Yan wrote:
> From: Zi Yan <ziy@nvidia.com>
> 
> Fixed two inputs to check_anon_huge() and one if condition, so the tests
> work as expected.
> 
> Fixes: c07c343cda8e ("selftests/vm: dedup THP helpers")
> Signed-off-by: Zi Yan <ziy@nvidia.com>
> Cc: Zach O'Keefe <zokeefe@google.com>
> ---
>   tools/testing/selftests/mm/split_huge_page_test.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c
> index 76e1c36dd9e5..b8558c7f1a39 100644
> --- a/tools/testing/selftests/mm/split_huge_page_test.c
> +++ b/tools/testing/selftests/mm/split_huge_page_test.c
> @@ -106,7 +106,7 @@ void split_pmd_thp(void)
>   	for (i = 0; i < len; i++)
>   		one_page[i] = (char)i;
>   
> -	if (!check_huge_anon(one_page, 1, pmd_pagesize)) {
> +	if (!check_huge_anon(one_page, 4, pmd_pagesize)) {
>   		printf("No THP is allocated\n");
>   		exit(EXIT_FAILURE);
>   	}
> @@ -122,7 +122,7 @@ void split_pmd_thp(void)
>   		}
>   
>   
> -	if (check_huge_anon(one_page, 0, pmd_pagesize)) {
> +	if (!check_huge_anon(one_page, 0, pmd_pagesize)) {
>   		printf("Still AnonHugePages not split\n");
>   		exit(EXIT_FAILURE);
>   	}
> @@ -169,7 +169,7 @@ void split_pte_mapped_thp(void)
>   	for (i = 0; i < len; i++)
>   		one_page[i] = (char)i;
>   
> -	if (!check_huge_anon(one_page, 1, pmd_pagesize)) {
> +	if (!check_huge_anon(one_page, 4, pmd_pagesize)) {
>   		printf("No THP is allocated\n");
>   		exit(EXIT_FAILURE);
>   	}

Hard to read. It should probably be "get_huge_anon()" to then check for 
the value in the caller manually. Negative value could be used as an 
indicator for an error obtaining the value.

Anyhow, was briefly confused about the 4 ("magic value" also apprearing 
in "size_t len = 4 * pmd_pagesize;") but it seems to be the right thing 
to do.

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb