Date: Fri, 14 Sep 2007 00:06:22 +0200
From: aherrman@arcor.de
To: Luca Risolia <luca.risolia@studio.unibo.it>
Cc: akpm@linux-foundation.org, linux-usb-devel@lists.sourceforge.net,
       video4linux-list@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] v4l: Build error with et61x251, if V4L1_COMPAT is not selected
Message-ID: <20070913220622.GA5764@devil>
References: <20070913123627.GD10348@devil> <200709131707.16666.luca.risolia@studio.unibo.it>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200709131707.16666.luca.risolia@studio.unibo.it>
User-Agent: mutt-ng/devel-r804 (Linux)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 997
Lines: 29

On Thu, Sep 13, 2007 at 05:07:16PM +0200, Luca Risolia wrote:
> On Thursday 13 September 2007 14:36:27 aherrman@arcor.de wrote:
> > With current git tree I get an build error
> > for et61x251, if V4L1_COMPAT is not selected:
> >
> > drivers/media/video/et61x251/et61x251_core.c: In et61x251_show_:
> > drivers/media/video/et61x251/et61x251_core.c:718: error: implicit
> > declaration of to_video_device
> >
> > Fix: add VIDEO_V4L1_COMPAT as a dependency for this driver.
> 
> No, wait. The driver really is V4L2 only. If you can, please fix it by 
> replacing to_video_device() with container_of() instead:
> 
> cam = video_get_drvdata(container_of(cd, struct video_device, class_dev));

Ah just some v4l1 remainders.
I'll do that.


Regards,

Andreas

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/