MIME-Version: 1.0
References: <20230307074038.17391-1-lukas.bulwahn@gmail.com>
 <20230307100350.1c0af7b9@xps-13> <1e321754-5bdd-4019-8524-2222ee369502@app.fastmail.com>
 <20230307113846.5dab6e66@xps-13>
In-Reply-To: <20230307113846.5dab6e66@xps-13>
From:   Lukas Bulwahn <lukas.bulwahn@gmail.com>
Date:   Tue, 7 Mar 2023 11:58:07 +0100
Message-ID: <CAKXUXMwn8wLBtTru74Mo4D=X6gA-M3b3Zin0L_ugtN9-R2L7-A@mail.gmail.com>
Subject: Re: [PATCH] mtd: parsers: remove reference to config MTD_NAND_TMIO
To:     Miquel Raynal <miquel.raynal@bootlin.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Mar 7, 2023 at 11:38=E2=80=AFAM Miquel Raynal <miquel.raynal@bootli=
n.com> wrote:
>
> Hi Arnd,
>
> arnd@arndb.de wrote on Tue, 07 Mar 2023 11:26:48 +0100:
>
> > On Tue, Mar 7, 2023, at 10:03, Miquel Raynal wrote:
> > > Hi Lukas,
> > >
> > > lukas.bulwahn@gmail.com wrote on Tue,  7 Mar 2023 08:40:38 +0100:
> > >
> > >> Commit 568494db6809 ("mtd: remove tmio_nand driver") removes the con=
fig
> > >> MTD_NAND_TMIO and its corresponding driver.
> > >>
> > >> Remove the reference in MTD_SHARPSL_PARTS to that removed config.
> > >>
> > >> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > >> ---
> > >> Arnd, please ack.
> > >> Miquel, please pick this minor non-urgent patch on top of the commit=
 above.
> > >
> > > Actually I guess the SHARPSL driver is not selectable right now, so
> > > this should be sent as part of my next fixes PR.
> >
> > I don't see why not, it just depends on 'ARCH_PXA||COMPILE_TEST' and
> > should work fine with CONFIG_MACH_SPITZ PDAs.
>
> Sorry, I overlooked the diff, indeed there is nothing broken, so I'll
> queue it to nand/next. I thought MTD_SHARPSL_PARTS was not selectable
> anymore without COMPILE_TEST, which would have been problematic.
>
> Fixes tag still welcome though :)
>

Arnd's commit is not broken. It does what Arnd writes in his commit
message what it should do.

And this patch is just a clean-up that removes references, but it is
just "stylistic" and reduces the complexity of Kconfig dependency
definitions for non-existing config symbols. I do not see that this
patch fixes Arnd's patch. It is just a clean-up with a reference to
Arnd's patch to understand why this clean up can be done now.

If you REALLY want the Fixes: tag, I can sure add it. But, I do not
claim that I am fixing anything here; nothing was broken in the first
place. The reference to the commit of interest is in the commit
message, and anyone can follow or extract the information if they are
interested.

So, please keep this patch in the queue for nand/next.

Lukas

> Thanks,
> Miqu=C3=A8l