Message-ID: <ca7a9708-8909-d663-d02f-240f8087aa9a@linaro.org>
Date:   Tue, 7 Mar 2023 14:13:53 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] firmware: qcom_scm: Add SM6375 compatible
Content-Language: en-US
To:     linux-arm-msm@vger.kernel.org, andersson@kernel.org,
        agross@kernel.org
Cc:     marijn.suijten@somainline.org, linux-kernel@vger.kernel.org
References: <20230307012247.3655547-1-konrad.dybcio@linaro.org>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20230307012247.3655547-1-konrad.dybcio@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7.03.2023 02:22, Konrad Dybcio wrote:
> While it was introduced in bindings, requiring a core clock, and added
> into the DT, this compatible was apparently forgotten about on the driver
> side of things. Fix it.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  drivers/firmware/qcom_scm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index 916a0c2fc903..2e8961c84b68 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -1494,6 +1494,7 @@ static const struct of_device_id qcom_scm_dt_match[] = {
>  	},
>  	{ .compatible = "qcom,scm-msm8994" },
>  	{ .compatible = "qcom,scm-msm8996" },
> +	{ .compatible = "qcom,scm-sm6375", .data = (void *)SCM_HAS_CORE_CLK },
On a second thought, maybe the qcom,scm compatible could optionally consume
all three clocks with schema guarding how many should be used, to prevent
having to add nonsensical compatibles?

Konrad
>  	{ .compatible = "qcom,scm" },
>  	{}
>  };