MIME-Version: 1.0
References: <20230302093300.62098-1-acelan.kao@canonical.com>
In-Reply-To: <20230302093300.62098-1-acelan.kao@canonical.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Tue, 7 Mar 2023 14:13:39 +0100
Message-ID: <CAJZ5v0gDne=4SdMRzZw-r7jZ4rftXQ4XpVHVBytmJLotPy+azA@mail.gmail.com>
Subject: Re: [PATCH] ACPI: video: Add backlight=native DMI quirk for Dell
 Vostro 15 3535
To:     AceLan Kao <acelan.kao@canonical.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Thu, Mar 2, 2023 at 10:33 AM AceLan Kao <acelan.kao@canonical.com> wrote:
>
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
>
> Sometimes the system boots up with a acpi_video0 backlight interface
> which doesn't work. So add Dell Vostro 15 3535 into the
> video_detect_dmi_table to set it to native explicitly.
>
> Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com>
> ---
>  drivers/acpi/video_detect.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index 710ac640267d..14d6d81e536f 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -716,6 +716,13 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
>                 DMI_MATCH(DMI_PRODUCT_NAME, "Dell G15 5515"),
>                 },
>         },
> +       {
> +        .callback = video_detect_force_native,
> +        .matches = {
> +               DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +               DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 15 3535"),
> +               },
> +       },
>
>         /*
>          * Desktops which falsely report a backlight and which our heuristics
> --

Applied as 6.3-rc material, thanks!