Date:   Tue, 7 Mar 2023 15:18:28 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     "Song, Xiongwei" <Xiongwei.Song@windriver.com>
Cc:     "claudiu.manoil@nxp.com" <claudiu.manoil@nxp.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: Response error to fragmented ICMP echo request
Message-ID: <20230307131828.ly5zudvllke2pe4j@skbuf>
References: <PH0PR11MB51923E3796E4D2420C700580ECB79@PH0PR11MB5192.namprd11.prod.outlook.com>
 <PH0PR11MB51923E3796E4D2420C700580ECB79@PH0PR11MB5192.namprd11.prod.outlook.com>
 <20230307123522.rtit24jseb5b2vep@skbuf>
 <PH0PR11MB519201AEC268247F6890157FECB79@PH0PR11MB5192.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <PH0PR11MB519201AEC268247F6890157FECB79@PH0PR11MB5192.namprd11.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HmWFju5B9r/7LfBN0pxJlXdw1n/yUVTKbMEfO1JOn/+ScOn+ivRFZC76S8+q?=
 =?us-ascii?Q?BmHFBBQr5/SAe4YqWDNmGUpw/2nyRawo0scV80MG0xbvRCgu1RFhZeRQCAOU?=
 =?us-ascii?Q?VB+vW6BgoDwFYGnSf/a9NnPTpDC/uHLkEqlGDLccbTav4dhUP8hfMM5Rwj6I?=
 =?us-ascii?Q?VLG1BWilz95Gjja8gjCvRboejt1gzr6Dnjjv3OmlDAeU/bzbj9Dfmf2Wvq0t?=
 =?us-ascii?Q?TtzF8xndwKiXPZx9Hfso75viVC2Fm0EFIF6J/qlBTZvXRMUyT8jlpqCawWCt?=
 =?us-ascii?Q?iz1E/9D8wpmeDnMaUF0m9evYYukhdZ7iZn7v1ujqYC5dvol0dorAJgQ5Kv/W?=
 =?us-ascii?Q?EcWAv5CcTP9bDLgMKEcQPlkTV+B65jwnzpsHUs/wL1H5cMWLTTACZij1ll1G?=
 =?us-ascii?Q?zageoEMENz0c8J0faL8Ist6YmYBLwKmKe0ngQpZxMlOKGJXg6E/fsRstxUJx?=
 =?us-ascii?Q?FsEisAw1aAE9jYSL6IH2nWpqlUMOPE9LG8QyT2YWPxbpFMM2q3p5Q4fApH5o?=
 =?us-ascii?Q?wc+/cbD9Ec5AjFMAZ0geGnqeCEV3ZZC106DU5Xl7tYe4o68v3lRuAFFSHWT7?=
 =?us-ascii?Q?Avx9cMnJ7yYEasgP7DjzTLQL7P5B9b1dP/0Ru8ObF2xGCDaw3EH6VnrXaPEz?=
 =?us-ascii?Q?8V9KBhhh79rZ+gP75Z7WnVKCaaQdQY9NnjL6UjV/g2HnZKBtKfckSMNln8LR?=
 =?us-ascii?Q?/x0dmgQh/GNNb5ajidLdahaTzrSoP+jyQqs55qLU39TfA5MRcFDR10KcfHpP?=
 =?us-ascii?Q?JzHSRK6wp4wBeEF3HoMsdUTiLF8p4QUmzL77tuMItxbe63Xzzk+DhmfUHx4D?=
 =?us-ascii?Q?zj6OVCHndBFnwJotPcIxRiQabGD/CDvebQIOjPzltzx3JymQWc0o5xxpLcdO?=
 =?us-ascii?Q?qmyi6PcIBQ7sEjcIapOfSABpBh9okzsYY5qqj65v9corIqdTGd3NCGz3MBwy?=
 =?us-ascii?Q?3yr2wbZlE+cfigfibEtPMPRbqm2oylcMMeMd2IF+XJF7WRaRovUmlv8whz+I?=
 =?us-ascii?Q?hDxPjjwh6Bz8NvCrqlaMWp0e/Huvx5WgfH3ZKSuiqaPE9O3n9JvdfnTZNGTF?=
 =?us-ascii?Q?YC3FOCQHRulxkZH9sjuiG9y0BalPDYDn91shJL1YzcejMmJXageliy0n1DPa?=
 =?us-ascii?Q?iV8Q2NvwX8IhgRbjdDeDHo2Eg5xzMaxUADQ3eMyxDmQFZel+PU+ya5Kj/boS?=
 =?us-ascii?Q?RSXbo8lmbG8/Vt6hPpcOu3AgEZ7+9ZTh6EIzT5IYEILWEfShwvv/8FLr58fI?=
 =?us-ascii?Q?Q98VGb6DuFK83RH3Dvm5otipouyFwpICNU0MFml+7mjMa6ihKT1yacP4oaan?=
 =?us-ascii?Q?xf0q61XnkmjVnoe7JIazGx5t36aSZZqJmifajK0maaIyx8w8sO0us8/nauC6?=
 =?us-ascii?Q?2CZco7O9p5guP+BLi6pBmuMxwd0yrnArY9FVK4RrVDWlqDT8Lsc0Zm/s9NI9?=
 =?us-ascii?Q?1LS+rSTPw0MIsWErUslOMdj58NZGxEtQgrxvzoa6yyCiAjOtcx+x4Lwpvefg?=
 =?us-ascii?Q?bpvOeVfiUiLCYFmtxCCx2TC9BADM2iPTMGXWxQj65kARdw7EUHG7T/dw7JkO?=
 =?us-ascii?Q?eIxyJIczwFnnx8YGPv/hsZOVJis7sXAhrbV1rcJ5+j7hKpH6D3k8P/aZJ0r6?=
 =?us-ascii?Q?pA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f2311f6-f859-42cf-a5ea-08db1f0e72eb
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 13:18:32.3450
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /JVP4wHrjHSVFnprDlox77aqosPDYO+87Cv6wEbOdWGqcVUBnsgBQtUET90HKS7vH5MivG/TllY9cveQPcxk6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7624
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 07, 2023 at 12:56:17PM +0000, Song, Xiongwei wrote:
> > Frames 3 and 4 are sent with DEI=1 and are dropped, frames 1 and 2 are
> > sent with DEI=0 and are not dropped. I'm not sure if varying the DEI
> > field is part of the intentions of the test? Is there any RFC which says
> > that IP fragments over VLAN should use DEI=1, or some other reason?
> 
> I didn't notice that. Let me check the test why set DEI=1. 

Ok. It would be good to have an answer to this, because one of the
assumptions of that patch was that whomever sets DEI=1 doesn't get to
complain that their packets are *actually* dropped :)

FWIW, if you do need to set up a reservation for traffic received on a
port, section 8.6.3.3.15 Buffer reservation watermarks (page 817) should
help with this:
https://www.nxp.com/docs/en/user-guide/LLDPUG_RevL5.15.71-2.2.0.pdf