Date:   Tue, 7 Mar 2023 22:53:09 +0800
From:   Chester Lin <clin@suse.com>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>,
        s32@nxp.com, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Larisa Grigore <larisa.grigore@nxp.com>,
        Ghennadi Procopciuc <Ghennadi.Procopciuc@oss.nxp.com>,
        Andrei Stefanescu <andrei.stefanescu@nxp.com>,
        Radu Pirea <radu-nicolae.pirea@nxp.com>,
        Matthias Brugger <mbrugger@suse.com>
Subject: Re: [PATCH v5 0/3] Add pinctrl support for S32 SoC family
Message-ID: <ZAdP1Z+LcgOQWvtK@linux-8mug>
References: <20230220023320.3499-1-clin@suse.com>
 <CACRpkdYknZo3Q7_CeSkOL2XwwAmKERskx24o-toaVy=rs0Yf5Q@mail.gmail.com>
 <ZAZ3JZQ4Tuz5vyH1@surfacebook>
 <CACRpkdbksZ59ndrRAQpTGa01GTq4c_2EcOQ2mtz1PLjqU8_nug@mail.gmail.com>
 <CAHp75Vf3ve-NdMG6iti-KSs=tGGgGf9tNj=aK7Jofk9233WocQ@mail.gmail.com>
 <CACRpkdaCZSoem31GmDC97LPYcZqRjkyf=6VGtXdXK0iwrV74qA@mail.gmail.com>
 <ZAc3nKEiYbUEX2xv@linux-8mug>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZAc3nKEiYbUEX2xv@linux-8mug>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWFubVduc1lJR1ZycU9XcFIrQ0lkMUt3MUlZVTdCVnU0aS9abm4vb0VhYWkz?=
 =?utf-8?B?ZXFhSjVHQUc1aENDTkZuS3ZEVHhHNmNSdUpyem1EWDRwSks0YWxjOGJIaUkz?=
 =?utf-8?B?TGpTdmp5bGJqZlVDOWpUZ2VYN1NSeUtvVHR0NXlORGE5SGhSU0U5c1FkYXBY?=
 =?utf-8?B?c0QxMjlTT1ZjQjgxUDlTWkRyQ2pSanl5TC8vN2w2ZmdzZzY1Q0VoSGkwcDA0?=
 =?utf-8?B?eGxmQ0pRR3hrV0E2SmFLV0Vwc1lHN0NFaHg1SFlNWnFUYnA1NXM4NVp3V2Mw?=
 =?utf-8?B?YmxkSzllamk0YXdkdlNFbDgxNEJ3SWlIUEhOejNKOExZc0dhc2h6QTBKWXJQ?=
 =?utf-8?B?UzkwV2NmdTVSNjNPMTN1dlpVOS9kVmN1WlNBa3JrOFA3ZHJDNEpLY1MxVTdl?=
 =?utf-8?B?VGg1a3hoQy9jVndSNjlMTStqUXJpVWoyZ2RFTldvUUxxbTlsYjg4UG12M0kz?=
 =?utf-8?B?QU5DTVArNDNydzhDYzU5bkZld2dScHdQT1d4YU1yOGh6SGU5bWVuS1pFejhm?=
 =?utf-8?B?aE1kUmRmVDhjRkczS2tiazZjTkwrdzdRU3BWWFY5ZXR2L1hqUkhybTRiLzhn?=
 =?utf-8?B?ZW9DNXQyR2xKZ0NER1ByOWNJRUJBNzlMenE4aUpFWDhDUm52dHQ2TE5NdW4x?=
 =?utf-8?B?ak9uNkd0d1NMUlQzTjAzODJOdE5Vam5HRWlDZHkwVFlSVVpuU3Q4c3FhRVZt?=
 =?utf-8?B?U29BRnM1b1Rhc0pIaTJBMk1KajU1OTZDNzI5U3hhNE5ZY3c2UkNCbThPeVkv?=
 =?utf-8?B?a2E2cVZ1WUpod2FzUnpTMVlBKzJMcm1ramdzcXY3WnVobTluYXdwRlRGZ1c0?=
 =?utf-8?B?eGZmT2V1VkRnTGRMVVBDNkJ6RnRtSmduTVhYRWxiYVBJM2Z6YlZ6d0Jxc3Bq?=
 =?utf-8?B?SENzR2llYlA3OFRXaVBSQjNDbHRDTDJOSUsvV01SQ3NId2pCSUJzYzJDUmJN?=
 =?utf-8?B?SHd0SDFBdWpnS2dZdTFJRVJta1luRm54L3M3N1E4MTBuZ2JMRG43Z3pNWXND?=
 =?utf-8?B?SlNqQjdFUWUwZStBTXVxV2ZvbjhUbkdTSEdGaEwwV2ZDd3pkem9zdiswMzdO?=
 =?utf-8?B?THh1bzFrQkh1STkwWVo4WW4rcXFoSVNTMEhLUlBtV1NKU0ppQU9VS0ZnSlJp?=
 =?utf-8?B?ZEFHdFA2RVdpMTdGQUg4d3hZbDdUQWoxSmExN3BpU2lTVmV0OStzMDhGSFY1?=
 =?utf-8?B?emtVbHpXU3lSbTIzYlBIeEU2bm9yNHNXQzhwdnFFYmtqbm9LdWlJTkpqS1VN?=
 =?utf-8?B?QUpmOEFGMVlMdlpvRThaeW10TnZWWmtBa3l1emxDNlVBTkhjcTh3SzNTZjJR?=
 =?utf-8?B?aGNRSWN5akJXd05abDVsUWhwZDkvbnFETXpnWktBVlY0QWttdlc5ZHVXR2Nx?=
 =?utf-8?B?T3EzcWVDdGxEUFVad3lKVkR1cklqdldZNlRMelVwUU42cVFGekZQRmlWZHIr?=
 =?utf-8?B?V2ZnSEkyYnBHb01zV2lyTWo5bWRSbmF1WVJXVGZmQ2dlaGk1N25SdVJWTHpX?=
 =?utf-8?B?VzVOcVNPRUZlbVQ0QnZiK2pNZEl1aEhqRWVWbFRqRzA4ekVoQmQzSHhvOWh6?=
 =?utf-8?B?V0N6MHpxV3dUZWhpNEJGY1NHRGxJM2NpemIrdlNuV0V5Z0lwOGhGbDQ0NFg2?=
 =?utf-8?B?d2ZlMm1SR1FBRHA2elFTOWNLaUpaVDdlUmNtYmRnbzVnS3d5dHlGd3RNZmc0?=
 =?utf-8?B?cHJwcHcvdW4vNklqbjB3Mmw5TnpFTjBPODRNdjZaakVJa3U4emJuUGo2QUZp?=
 =?utf-8?B?KzAyLzMyd1Q4K2kzU0t5M3F4MXZsOC9zazlzcFZucjRlMjVZYzgvNjVqMHM0?=
 =?utf-8?B?K1Y5bkY2M2c3aFpva1VvTm5hQmpzbC82M1ViWGxpWG5LbGRTdmwvZkxvZkxV?=
 =?utf-8?B?LzRuZHJvYzNsckIzU25ZYUU4dnRERWQvRlM2VjhZMzdUakJpTDJEYng0a0VU?=
 =?utf-8?B?QXpHN1hrTnZSeTBZc2hzbW5tKzNjaDcrc2R1ck9XWmhjQzc1WXV3cXRiUVdU?=
 =?utf-8?B?U1F3Mkc2bHAxb3lTVjlOb3JJWk8zR05lalJjUEZuZFo3cTIwNExoV1I2aGhm?=
 =?utf-8?B?L2k2bTM4bktxNW1lZU5vcDRPS0pQeEVtd1ZBMTlGVWNzOEswNUpqTEtTdWVZ?=
 =?utf-8?Q?8a78=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 748b6f9c-c666-47ce-efcb-08db1f1baf6c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3439.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 14:53:17.5161
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HdBdTgq72EcI2oDkKSOKonQciZI07I8UOWqj65rCfg0Mm7E3yV61S8U495lMAKNT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9815
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 07, 2023 at 09:09:59PM +0800, Chester Lin wrote:
> Hi Linus and Andy,
> 
> On Tue, Mar 07, 2023 at 01:49:00PM +0100, Linus Walleij wrote:
> > On Tue, Mar 7, 2023 at 10:56 AM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > > On Tue, Mar 7, 2023 at 11:22 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> > > > On Tue, Mar 7, 2023 at 12:28 AM <andy.shevchenko@gmail.com> wrote:
> > >
> > > ...
> > >
> > > > > Can you unpull this?
> > >
> > > > If need be.
> > > >
> > > > Are there serious issues with the patch set such that they cannot be fixed
> > > > by add-on patches?
> > >
> > > There are a few absent error checks, some error code shadowing, etc.
> > > I can't tell if these all are serious, but the amount of them is like a dozen.
> > >
> > > I reviewed the patch, so you can look into that yourself and decide.
> > 
> > I looked at it and some of the comments are pretty serious and need
> > addressing ASAP.
> > 
> 
> Thanks for reviewing the patch.
> 
> Please kindly leave review comments if it doesn't take too much time for you.
> I just want to ensure that I won't miss anything.
> 

Sorry that I just found that my mailbox didn't receive Andy's mail [comments on
v5 2/3]. I will try answering it and come up with a patch ASAP.

Thanks for your patience,
Chester

> > However it only affects this hardware so it's not like it's breaking the
> > world. I generally prefer in-tree development over too many big patch
> > iterations, it gets more focused.
> > 
> > I think if Chester can follow up with a patch or several addressing the
> > comments in the next week or two that's fine.
> > 
> 
> I will do my best to solve it.
> 
> Thanks,
> Chester
> 
> > However if we get closer to -rc6 and nothing has happened I would
> > not be so happy and then I might just revert the driver patch.
> > 
> > Yours,
> > Linus Walleij