Message-ID: <9f72ff19-7e04-9ced-4988-aa88ab98536a@oracle.com>
Date:   Tue, 7 Mar 2023 15:12:39 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 01/11] scsi: scsi_debug: Don't hold driver host struct
 pointer in host->hostdata[]
Content-Language: en-US
To:     Bart Van Assche <bvanassche@acm.org>, jejb@linux.ibm.com,
        martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        dgilbert@interlog.com
References: <20230307105555.3745277-1-john.g.garry@oracle.com>
 <20230307105555.3745277-2-john.g.garry@oracle.com>
 <7c66fd8e-78bf-9f3e-0baf-36a8fef27f45@acm.org>
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <7c66fd8e-78bf-9f3e-0baf-36a8fef27f45@acm.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVlxWUE1azIxdHVwY25oZUsrWXRwRUdKeEpnRFVKeWsrSmoyYjZmRVhCUmVE?=
 =?utf-8?B?SVJHcXByQTBoSTh2Z3M0NVlpS2JkdWl4VWZJV3k5ZGVITXlGb0RtVWduNTlX?=
 =?utf-8?B?bVFkQXVkQkY4VTkyL3hScHlybGJRUWRiaDlid0lZTFNxbFhONHRCZFhTeXZk?=
 =?utf-8?B?ckJIQVdmaW5zMHRXeTNPdWk0dnorNE56NkFlLzJqWnN3ZXRnN1E0bkZ2eTV6?=
 =?utf-8?B?bUVjOFo5TzhPTm9yNVByaGlyZnlWNjlacDltbTlQZ0hHa2F4NGJRTUlrdHE3?=
 =?utf-8?B?L1RpUyt0U0hKSFZrQUZoeUtuYUpTL3Y3R2pmUytWL0kzZHhxUFZjYnNnSzVV?=
 =?utf-8?B?aDNGYVZmLzMveXRuUkx6dEFCalFBdnFMY1Fzd05LUkdodStFTTF1eTJ0YUZI?=
 =?utf-8?B?U1h5a1kxQ0ZjcU9kenovRnFLZ0lhdjdlT3dHOGFaY3NqT2lZdGhKSVJjT3Js?=
 =?utf-8?B?U0dGeEJydTV1SVJ3bVRiTlptek5mbU9VMzVjOVlsNlZUYTNOVUo0TXhoa3BS?=
 =?utf-8?B?ajEzZE9MeUtqRlVSaFZYQStvcitGY2JRa0ZTejdzSnplSVlqR05jTERkVlFE?=
 =?utf-8?B?bFhXZndtVHVTYzRqZjhDMEJyUXVtSlJjMmFvcjFySzRuY095WFVmalJjNmZl?=
 =?utf-8?B?Q1hyWWYvN1hKWTN0aTc0QzRpQzM2SnBvUFNkdWliQ25oZU9LQ1A4TC9IQXBB?=
 =?utf-8?B?aEMyRVc5dlp5S2xMRzkyczM3OE40WXFMbUIyYVdNK2xGbERvek5PVC9PRTRH?=
 =?utf-8?B?ZWx6K05yRTRCTTY2WGNQOTRGUUF2Q245Q0kvemNsdTBDMDNVdEdqV09BODNX?=
 =?utf-8?B?dEZQVkFDaldwcU80Y3VpZ2VZeUF3NW5uR0VCWFI0VzRLNVRqRzNFTE4zc0VV?=
 =?utf-8?B?elZsOWF1RSswYmtEcGxaZnRCbW9nVjRYTzg1NFZWZ2VKQnZjc3VmSG1obnZ5?=
 =?utf-8?B?SEZJRERueVZCaTZ0eWsrejB3R3ptZ1JQeFRhZk5ucitJM1lET0lHdUlidUhk?=
 =?utf-8?B?YmJnUE9rK0pRNDdwNjNoSVF3UURWMUZ3anRwQk40K054T3VqVFQ2cTJmTjBL?=
 =?utf-8?B?aHpTRFZRU3Q0U1hOdkZZLzc4SVoycUlIWUVLMHQ0MnhDQzR0em9BZkVUNDNq?=
 =?utf-8?B?MHJTcUZ0VzUwTnVLNVUzQVZJZzNCWFBGSnlLMUpaSWN6Q3cvc0FHSXRGL3BL?=
 =?utf-8?B?dVlwRTZ1eWsrSGtKeFZleHBhaVBCaEZzRWdrSG9iMTNTMkI2M1UvcWJRcHZa?=
 =?utf-8?B?T3ZBWnRwVnlsSmk1VW45MHFGTTRsaDM3eGVpNkNwbUNKT3NPelZ4N3dLdnNL?=
 =?utf-8?B?cE5zR0haUjBROUNzb0pCTGJyYnpCQndiVGVYenZyWWRPTzBrQ2tnaVNWL01P?=
 =?utf-8?B?by9NMFo5RTV5WmhxSG5nMTFncyt2TnFLSzVjRFppSjVwMUp0MFpabXl5TU5r?=
 =?utf-8?B?UHRBU0JXTFJZMlQ3MWErR2NXOUMyK3lTREFDQy9xVlBsV1ZERFJkMFhQaGhh?=
 =?utf-8?B?cFVGUDI2aVZjMGxWek1JU0VRTURvVmRiT0hnd0tPd2dZMXNuNGNhRXlpTzRj?=
 =?utf-8?B?TzBDOW0wOGJHa1pablZIUjNlY2J2WktaT0p6a2xDd2ZObWpsRXlCdGZnVkRT?=
 =?utf-8?B?YnNzL2dQSUZPMHErSW9kSEpIcEdHL2lQdFJ4ZTk0VnZPV1grYUd1cWtBQ3Jw?=
 =?utf-8?B?a3NwMUJLQVZqL3lKUzRYdm5VQkNjVHNnRVlYWEFmRmVMcWF4MUY3cVB3aldZ?=
 =?utf-8?B?MU50bUdwY1h1d2JlcFdNVUkyVy9yUGdJM3ZQVmNmaVlQU3lYUHcvVUt1MWcz?=
 =?utf-8?B?V3hucS9zNjNOMktWNHlXSUt5K2hCdGVzN3VWUHk2V3JtR0lFSWd6SmhtbUZC?=
 =?utf-8?B?VlhFZ243dWdKNjhacDB1cENLNGwrVWZDWllzZlcvUFVTdkl1aWphYlpGQVgr?=
 =?utf-8?B?MXUvRnMwNHJRWmdTc205K0Z3OXUrU3B0bnh4MEUzaG94SWE1SUVLZFJVSVI5?=
 =?utf-8?B?bmR1YXNuMlkyN2thS0JOQlNON0lzZU1tZW5sTy9tNVlROVd2RkZ0WDB3eWl3?=
 =?utf-8?B?cnRaUzRxUHNtWnNad0dDTzM4cHErZWY5VFpjTTU1d09jQjNNNXBHbXZKREJ3?=
 =?utf-8?B?WVBNSFJ0OXgrQkQrYTYrRzdOUmlqN2dqRFphcnJ4bFdhQXR5UlUvVWNGZ3or?=
 =?utf-8?B?Snc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6uczaB/fO8I0nu4VVf/BMmYj0YbOW3N7m7TbUsYLwQA4GUPnwmdSfN6U6bYYX+ySn59wRpJ+JH6RrjK7hkHgF3F+0WiOomKJprJ20L0lYrm0RmwTXosMe4lS4LPhTnTbg1I4yo39f6PbwqD9qxJ4iOeOj0av7ZqLIzVcO9zbyAxOWq+agcNEcT7q/I/Y9o42dQfE4H79Z/D1QeIz7Se3Gug2K1qzFA/gphuljs48VYLtwQthoDbqjY2JscNnUEeBAF5UjUFJk2tJTagHtKPGPtNCFqmjiR9HzDMxB4HDj2OZZNr8n7DLN8FD0AgxZ20tCVxEuazkJvwAI585erpmI8pLHf8EqkBOnUq3T+WSpxEespBKDmNMBSLUzhf1A21JqtDSWeq0cqkkcytZ9ucAXHWQerONo7EiaB+ubRGPG0aAJus4pDgWtCGJBKAKSncAFJR4Ft7mV2wcn9fsbcLyAG4B1sCa6pxfNvxbe59knVu24Iv+z7VH2AMoy4nwmiUikhZhdUIOGAV0NarNmdm4IIdefH4QmdUvcCIkvWIElbYvlp3oD7NKn/Ht8k7iMJay8bbyvPgWvFYA89CV8kIn7Qeogtb95nct6S7rbSEcpTj26i6tsnLYt68yi1No7asjN2mgcB8c2H/jMD6nslTiGi0HDlQ4Wwp2Y2aFYx84x/UIGzwVhcdPuZzJTO1bttEo/XC1mQTa8GhkwW6CBUcktrJHjAmCqa4WSzc82g5Hy1zNz+z3/SlElWpwI6l6UhyctgmhopB0UZFWQlhSkAz8KgpCVZ5DEkaOo8t6S0izO+JfcE1qAJDSvehRy5ruEkwKnh6u++uRWSypTj7IVkhL/DiCBGM0EA3DUiqJDrkZCZY=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1d76ae2-d712-45ac-b2a8-08db1f1e66ed
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 15:12:44.1902
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U8ukJq2F0fL2r6BUV6xFtZoI1AqXo5eDRYxErKIbfTjCog5Vvo3J2e2qnfEB8+3CK4BvZQOCeWLGbwOgByJmNg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4812
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-07_09,2023-03-07_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 malwarescore=0
 mlxlogscore=999 bulkscore=0 mlxscore=0 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2303070136
X-Proofpoint-GUID: 8cOAU-mZgKyrrIgECwUeC3l3NIF3rQah
X-Proofpoint-ORIG-GUID: 8cOAU-mZgKyrrIgECwUeC3l3NIF3rQah
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/03/2023 14:58, Bart Van Assche wrote:
> On 3/7/23 02:55, John Garry wrote:
>> +#define to_sdebug_host_from_shost(shost)    \
>> +    to_sdebug_host(shost->dma_dev)
> 
> Please make the name of this macro shorter and following naming 
> conventions used elsewhere in the SCSI core. How about the following 
> name: shost_to_sdebug_host()?

ok, fine, I can change that. Maybe then I'll also change 
to_sdebug_host() -> dev_to_sdebug_host() to avoid ambiguity.

Thanks,
John