Date:   Tue, 7 Mar 2023 16:46:01 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc:     David Howells <dhowells@redhat.com>,
        Marc Dionne <marc.dionne@auristor.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-afs@lists.infradead.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] rxrpc: Replace fake flex-array with flexible-array
 member
Message-ID: <ZAdcOYUloeb2Echh@corigine.com>
References: <ZAZT11n4q5bBttW0@work>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZAZT11n4q5bBttW0@work>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmFhcEpnQk1Sakh2R0xYMTZ5Y0I0U0VYbGpscmRvZ3Q0ZWdOV3AxMVNDVllB?=
 =?utf-8?B?aUJuNDdONHRsV1BPYis4SlM0MW1zbW5oeTBTeXhWTldobTYvUXZ6dW84Umkx?=
 =?utf-8?B?R3UvRjErdGNiRGVTNC9ncHJOZU9oR2xQc0RseHpVdEdpNm53NkxzMmdWZmts?=
 =?utf-8?B?Tmw0cXN3UG0vWldacUZqNUdtc3RpZVRhcjM0VTY4WXFlTlY1b1Q4RHpKbjZq?=
 =?utf-8?B?VFpoTTdQcDJwSytOK3JKUGR0TkFMRGJPVDJSUmxWT1RVa1NBNUZkcklVMUpa?=
 =?utf-8?B?M0F2ZUs2YXc0aDR4OEV4THptU1QwUjhNYk1wNDlvcHNXL2dsc1RrWVQyNFFI?=
 =?utf-8?B?MkhUeG02M1VxMHdGTGJiRVZkOWZ4cE9EdnBzM09XQzJlM2FhU0s4REhqNW0v?=
 =?utf-8?B?dXcrR3JxS1F6cURoWWdQbGtqZGJ1TzUzMEpKdjdOQjdmUkU5bllURlI3V0t5?=
 =?utf-8?B?M3llUVpKV3RTQjJGT2R3NWxBcUoxSG53d2c4OHp5djhZRzBxTHVYR1djRURy?=
 =?utf-8?B?aXNxRDNJSjFoZGR6NVE2dVBoNlFMZTJ1cm9wamNJYlFSMDQ1QUxzVExHR3Rr?=
 =?utf-8?B?aVNOejlOTWxqS0xoYTMzSGMvcW5Id2h6Q25NQkFjU2tuSlYySzRhekNSYW5K?=
 =?utf-8?B?b2R4ZUJFSkRHRFpEREY5ZjViVkdFWndSRUpSZmFJN1VPMmh1N0JvUEpQOEN6?=
 =?utf-8?B?aTBXcHRGV1RQaytkVHJVdXlUdzk3WmNPcTFxekdTUWM4SDBzbk55a0pYZTEx?=
 =?utf-8?B?OW0zc2NVQ0NXQ0w2WURIWWZtc1BLWmJjb0lYQnpvTUhFKytydFFpZW4rc1Nx?=
 =?utf-8?B?M216SS9Odk9kcjdvSkUxbm9KanA4ZWwxM2hhM05oNjBiUzZNSFhOQmlzeDBs?=
 =?utf-8?B?SURxODV3SFZ3dFEzSDVRcUovd0RsNnZ5aUpDMVlrOEhwc25rS0hGaXA1Mlpt?=
 =?utf-8?B?dkZkSXRPT1M0MWVPS3huTnd4eGpLcUVxNVlIQ2YyQjNwQnZrdm5ZR0ZEa3ZH?=
 =?utf-8?B?bWJjTWNBMlVZOVNTWWNtWGJxY2lLZkJ2VUI5dDhkRlNrN2VrL2t3OFVMOW1a?=
 =?utf-8?B?TE9udk1EWFI3QWg0VFozbDBReUthZ09lQVhDVWc3ZXdkUFRUWWprMFh0QU5x?=
 =?utf-8?B?OE9CY3hrSUNpM2lNeGR4Y0ZYb0lZbjExZVZwWWV4YndxYnVWd0pUVFBBYk5o?=
 =?utf-8?B?RUdvYUd5TmdZVFUzNlRpQVE2aEVLclhNaXRrQWpKdDk5dHd5ZXVsRDVyMi82?=
 =?utf-8?B?K1pyU1UyaGs5bzUvN1pFa2craDV6NDhiK2VKbEpOaC9ZVXZtN3p2dXVMYk44?=
 =?utf-8?B?Q2Q3YTJGRmIwaVlLYW5pekJGWTRuZElIN01hcC9BVHlUY0FNcGc0VTB1c1Jy?=
 =?utf-8?B?WlJYMWxWMUlaZktMdE54TkNWQlVqMlhKYkpSZmhoaXQ1V0R2b3JOS1ZNUy9I?=
 =?utf-8?B?U2ZxVVRkRDFjS1ZkSE9QUVpQaWhqbDRFWFFvVzVPeXRpZHp4NVhuV3FtMWhZ?=
 =?utf-8?B?NzBMcEhwRm1VRm9GaXp3cVloSmJrci9kMENDU2FLMHo4eVk3NXlmT1F0YStm?=
 =?utf-8?B?eWtkL0wyYTUrVTRoUUhlWmpKOUJiTG5BL1VRVDJ5Unc1MWdVem8xOFdRK3l5?=
 =?utf-8?B?Q2J0R21QTnZIeUxGL1podkNSYTVCTlJuS2FSdDQ3MnZjR0dkWEtBeDFyTUJH?=
 =?utf-8?B?R0pZSHM3dXlLVFIzdXc1a2U2Rm9USXBEeTBzS2ZuYnhndkFqYVIyTlQ4MEQr?=
 =?utf-8?B?U0oxRkFtTGF4aC8wU2p1YXhxRUZtUkg1NEVSNHBWSXV3RVYyQWlsTExSaDZ2?=
 =?utf-8?B?UEU3LzkyNkViNDVkQ25QMFF5REFQNVlzR1NtcTJ4SXRucVB6cHpLeVd3ZTFY?=
 =?utf-8?B?R3ZaSzZ4dEFSYjBaQlRFWUxOSjU4aVVCN2MxcE44UU5ScXZ3eW9UQnp0aURj?=
 =?utf-8?B?RTEwaXJpd3F4a0hGNmR5S3Y3MC84a1ZXck9nQ1plcStRczhpMk5mL2prWlV0?=
 =?utf-8?B?NFJjV0xyeFlLb2QyQlNyQ3dZUVNTWHlzbDFualBERThJVEo3UjIxbVkyT0p4?=
 =?utf-8?B?bGJYY2dXMzgwNVZKakNZM3FibE1LN0szQVFjYlZBL2xEQXVhM1F2ZHMrNWR3?=
 =?utf-8?B?KzFsS1Ntb3VSOHEyQm5XM21GbHR3WlhDNDRUZXJKcDQ1bDB4bDZadG5SLy84?=
 =?utf-8?B?RzFva3VDK1FEVWFuZWx2ekZ1SnlURVJhMWZSdzFGM3RJcjJFR3p3Q3JEM1Rn?=
 =?utf-8?B?TU8zQlo2dXFSdFdCNEpTVTNXeWlRPT0=?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cba1eb05-95a7-4d8e-c88a-08db1f231149
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 15:46:07.8830
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pKjoqiS3Dzj2Mu0CoUy3hTIx6jxqsUFXSrf2UGixqak4XjKKkWk/BzkGrCv176NSl+AlJNjyZ5ULZRpybhgJNmaIu3A2J5Oy7w+RKaDvcGE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR13MB4685
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 06, 2023 at 02:57:59PM -0600, Gustavo A. R. Silva wrote:
> Zero-length arrays as fake flexible arrays are deprecated and we are
> moving towards adopting C99 flexible-array members instead.
> 
> Transform zero-length array into flexible-array member in struct
> rxrpc_ackpacket.
> 
> Address the following warnings found with GCC-13 and
> -fstrict-flex-arrays=3 enabled:
> net/rxrpc/call_event.c:149:38: warning: array subscript i is outside array bounds of ‘uint8_t[0]’ {aka ‘unsigned char[]’} [-Warray-bounds=]
> 
> This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
> routines on memcpy() and help us make progress towards globally
> enabling -fstrict-flex-arrays=3 [1].
> 
> Link: https://github.com/KSPP/linux/issues/21
> Link: https://github.com/KSPP/linux/issues/263
> Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [1]
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Reviewed-by: Simon Horman <simon.horman@corigine.com>