MIME-Version: 1.0
References: <20230306152810.ptb622tfhoxehhdc@mobilestation>
 <20230307122021.1569285-1-void0red@gmail.com> <e4ac3d74-9a91-e4ff-eee3-67237f35ac7b@intel.com>
In-Reply-To: <e4ac3d74-9a91-e4ff-eee3-67237f35ac7b@intel.com>
From:   Kang Chen <void0red@gmail.com>
Date:   Wed, 8 Mar 2023 00:26:17 +0800
Message-ID: <CANE+tVo98AZuRGcAshv5W6v2+fKjTruDVRRdgjfyAVk93cC3_g@mail.gmail.com>
Subject: Re: [PATCH v2] ntb_tool: check null return of devm_kcalloc in tool_init_mws
To:     Dave Jiang <dave.jiang@intel.com>
Cc:     fancer.lancer@gmail.com, allenbh@gmail.com, jdmason@kudzu.us,
        linux-kernel@vger.kernel.org, ntb@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

What a cool tool, thanks for your suggestions.

On Wed, Mar 8, 2023 at 12:06=E2=80=AFAM Dave Jiang <dave.jiang@intel.com> w=
rote:
>
>
>
> On 3/7/23 5:20 AM, Kang Chen wrote:
> > devm_kcalloc may fails, tc->peers[pidx].outmws might be null
> > and will cause null pointer dereference later.
> >
> > Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API suppor=
t")
> > Signed-off-by: Kang Chen <void0red@gmail.com>
> > Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
>
> You forgot to pick up my review tag. I do recommend using the tool 'b4'.
> It picks up all the tags for you and works rather well.
>
> > ---
> > v2 -> v1: add Fixes and Reviewed-by tags
> >
> >   drivers/ntb/test/ntb_tool.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
> > index 5ee0afa62..eeeb4b1c9 100644
> > --- a/drivers/ntb/test/ntb_tool.c
> > +++ b/drivers/ntb/test/ntb_tool.c
> > @@ -998,6 +998,8 @@ static int tool_init_mws(struct tool_ctx *tc)
> >               tc->peers[pidx].outmws =3D
> >                       devm_kcalloc(&tc->ntb->dev, tc->peers[pidx].outmw=
_cnt,
> >                                  sizeof(*tc->peers[pidx].outmws), GFP_K=
ERNEL);
> > +             if (tc->peers[pidx].outmws =3D=3D NULL)
> > +                     return -ENOMEM;
> >
> >               for (widx =3D 0; widx < tc->peers[pidx].outmw_cnt; widx++=
) {
> >                       tc->peers[pidx].outmws[widx].pidx =3D pidx;