Date:   Tue, 7 Mar 2023 16:32:04 +0000
From:   Gary Guo <gary@garyguo.net>
To:     Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc:     Asahi Lina <lina@asahilina.net>,
        Andreas Hindborg <nmi@metaspace.dk>,
        rust-for-linux@vger.kernel.org,
        Andreas Hindborg <a.hindborg@samsung.com>,
        Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scripts: rust-analyzer: Skip crate module directories
Message-ID: <20230307163204.44278987.gary@garyguo.net>
In-Reply-To: <CANiq72mvL3f-MZiZiZp-uZDQGCnYJ9yFh_QTWrTMUkUdiXdm=Q@mail.gmail.com>
References: <20230307120736.75492-1-nmi@metaspace.dk>
        <CANiq72mvL3f-MZiZiZp-uZDQGCnYJ9yFh_QTWrTMUkUdiXdm=Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yk5JMk54Wnd6cFo0M1h1dHNpc3c4VjZkS01TV1BJYW03ejl5Ykd6d3BJZUd2?=
 =?utf-8?B?KzRESERHN0VDUTVIdTBhbUJSVGJxaG9TTDNFT2hPOGdRZjFkWmdrQ0VsTlcv?=
 =?utf-8?B?WG1ybXBSOVA1WDV1RlNmMmFtb3hkUmFnais1SHhwNWNzM3pUNytzWmpESitl?=
 =?utf-8?B?SzI1a05zakZkQmVhVG52bWpjZzhGRWQ0Ny8reU9SWTQrNnhSTGdDdWR5c0R2?=
 =?utf-8?B?ZmF3YjA4QnZNYnBaeXVhWVcrUXpxTkJIQjdvWktWR1A0NWJldG1zTE1PUDVK?=
 =?utf-8?B?RmlMcUNrSnIrdnFmOVJVQ1lidVU2RGhDbUlRNk5jMjJvb25CSFBudTVsOGNL?=
 =?utf-8?B?d0xjY2lVdGpNTnNPVW14a0NxbElkbFlvcFREd2Z5blJUYVQrYkRVeXFMQkRh?=
 =?utf-8?B?QzJjT2xvRDZoeloxWFdITm9NcElXN1R0UFk1c21kSHpjTkZDQVhObEE1aFF2?=
 =?utf-8?B?YW40SHBzRm85RFBzV1BSQ3krRXdlMjZPbks3ZFcxS3ZTajBzNWFzVjdMTS9I?=
 =?utf-8?B?MlVyVUFHc3lVR2RiMzZvSlU0VTZybEdMWlNXYlZYK2RBRFRVOER2eCtWZHBF?=
 =?utf-8?B?VmNKYzBIeXQ1NG9LTDF5b2ZCWnN5YTJWdjhFMlJnblFYODVGOHBoWnZ6eWpT?=
 =?utf-8?B?dFYxbmQ2bW9wa2V0OUFEazQ1WC9zSjZwdUNzMzJ0Nm9ObVFUYnNZRG01UTVq?=
 =?utf-8?B?ZFR2eGJUdVY2eFI1cG1CZnlDOE56V1p1TlVtRDd3K1lESWlhalJhVFY4WGFL?=
 =?utf-8?B?Y1hRYzUzTlZ2NFA0ZVNKSUJ0Uk9ac0YxWEpjTm5DK3FmQ1Z4YzNQK2ptNk4x?=
 =?utf-8?B?cGR2cGZUYUNEUVNxcDIrUFRaL2NLSTluZkJsVnZjWmxtb3JzM0RuTU5zbHZp?=
 =?utf-8?B?Uk5YRlRaZWVMSTBLNnY1MkFLYU9MS3Q0N2YycVRVNGJyRmVwOG5wbXBIOWlp?=
 =?utf-8?B?UFNGbzBJL0RMSTlkSDJUOUlmYzNsS3I2VkMzdmF0SndmMkNVSytzTnhZdU5L?=
 =?utf-8?B?ZnFya3RFWmQzQi9UZnN3d1puTVozSC9RcEZteG1IZi9uVUNpOTBSbm5ZSWx4?=
 =?utf-8?B?dmx1WHhpTEE4Z1hLMEx1VTV4YlN2ckI5T1dCNDllTWp6ODNaNkczVTJka0F6?=
 =?utf-8?B?dC9zUWE2THhTaFl5bDkrV1BXTjNIbHRoUGZlV1Z1TkR0TmdqNUFtUUZBSXhl?=
 =?utf-8?B?M1EraTVXRDJGNDhxRHFJRHZ0c3hQRjkyOVBocnR0Q3pmSjN0N0ppT0pSMlRz?=
 =?utf-8?B?ZS9Ea3pYVm9mU0d4bnBUa3RycFREMGRML1lTYVhxTHlXbFJmZW43a2VZTlBm?=
 =?utf-8?B?Mk5FcGM5b251SnVibEk4eUFEamdDbXEwcGRuU0pKSjF0ZC9uRHdtNVc3MWht?=
 =?utf-8?B?RzhPcTV6UkZyTFNlT2RTU1BsU3FkQyt3eTB6cVlrSXljOFY4dlZ1SU1wVU94?=
 =?utf-8?B?ZjlJTldYajBGYVRRVW14V2ZsQ3lWamdOdG10OThOOWdRZjJPc0JlODd0WVRx?=
 =?utf-8?B?WnhZUFNHTjhFNTVNUlhwYkMvcTJOczB4dzY2bnZ2TkJ5WStXa0ZIODk5UDht?=
 =?utf-8?B?dTVyU2ZxeEk3aVhQbGRyRnUrVDdFN0RKUGdsc1pxMnNKOWNaVTV6R2NvL3Rs?=
 =?utf-8?B?bkJXMmR2cG5YMWZwajRMSWs4YytITm5JSzVLWVJtRm45VlIxclRpemNMNlQw?=
 =?utf-8?B?Y3RRL3A5ekNmR1pxemQrbHd5ZW1pRjJQai8vTGNKNUxYWTF1ZjE2MFhUSXFH?=
 =?utf-8?B?TkRHV0daN2dxK0dKTEZhTDQ4NEdqbEdjVHNSaVlRdUdDdFFjUUNQL09oeEVt?=
 =?utf-8?B?M3V1M015Z3R0YjlzNFgxVlFQblpHZWRxSGxQa2t5b3FjeVliWk1TcVhyZ2hB?=
 =?utf-8?B?VnJRZmo2WldPRVd4RytlTG8walZQZ09HeTdpdU5CY1hPMmlkTTJjY1owTzMw?=
 =?utf-8?B?bGFuUi90ZnJPUFhubkUvbU5Vd011ZFpmM25BUHJKUmRWM1k5Q1lTSWlIZmJ4?=
 =?utf-8?B?a01Xdmk4T1Y3Y0p0b0E0SkVjU3BpMXdWTWJzcXYzQUFEMkJ4R3B6SmZuS0tR?=
 =?utf-8?B?Z0tJOXloRzJqeldzN3czaHo1V2w4cEJsejFvTjRpRUkyWlhNOENNT0JzSlBD?=
 =?utf-8?Q?d+VqtSMEXEkcaSTZAvz/z5I4J?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 473b6a52-d60d-44a1-420a-08db1f297eef
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 16:32:08.8192
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2aUvTIGq8gDPM6uOrpexM86W0Gx+ws1gphczq6/j4p0l3rnHsqNtM8cLhL4fyqqwXkTi9pK80krOstImDRxNzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP265MB2021
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 7 Mar 2023 13:38:10 +0100
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:

> On Tue, Mar 7, 2023 at 1:08=E2=80=AFPM Andreas Hindborg <nmi@metaspace.dk=
> wrote:
> >
> > When generating rust-analyzer configuration, skip module directories. =
=20
>=20
> This is https://github.com/Rust-for-Linux/linux/pull/883, also handled
> by Vinay's patch
> https://lore.kernel.org/rust-for-linux/20230118160220.776302-1-varmavinay=
m@gmail.com/.
>=20
> Lina's approach is arguably a bit more idiomatic in Python in that it
> is usually encouraged to follow the "Easier to ask for forgiveness
> than permission" approach.
>=20
> Lina, would you like to submit yours? Or do you prefer a `Link: ` /
> `Reported-by: ` / `Co-developed-by: ` here?
>=20
> > If `driver_mod` is a module of the crate `driver`, the directory `drive=
r_mod`
> > may not contain `Makefile`, and `generate_rust_analyzer.py` will fail. =
=20
>=20
> By the way, note that in the kernel crate we are avoiding `mod.rs`
> files, instead using `name.rs` in the parent folder, in other to make
> it easier to find the files. I will add a note about it in the docs.

I personally think mod.rs makes it easier for me to find files because
all related stuff are contained inside a single directory, especially
the parent modules and submodules are closed related.

That's just personal opinion though.

Best,
Gary