Date:   Tue, 7 Mar 2023 17:33:56 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Daniel Machon <daniel.machon@microchip.com>
Cc:     netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, lars.povlsen@microchip.com,
        Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com,
        joe@perches.com, error27@gmail.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: microchip: sparx5: fix deletion of existing
 DSCP mappings
Message-ID: <ZAdndDaDiuSy5Lwf@corigine.com>
References: <20230307112103.2733285-1-daniel.machon@microchip.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230307112103.2733285-1-daniel.machon@microchip.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?X5MRicyp0gyxhQXe6r/OSQKwcASZc37z9Y+OdYjaBd0nwZBcLvKpK2+cBgOc?=
 =?us-ascii?Q?Bl+lyKgUY/xzG4Kbk1z5RFGkkroBta3ruOsi85rp4AkOrl9DIJqqbSghuq/A?=
 =?us-ascii?Q?rQ94iULy8stWphZvVVYPTu4zB0LJjONRXlFJaRplOjYljhO3EJqofAsi6pkG?=
 =?us-ascii?Q?3p6M69tp5iZ2JuFdiocliCrMpnCEsPdJTTCvNozuaAftCpGuzORjXz80d9HR?=
 =?us-ascii?Q?TuecocdiUUgjuluxBJVZPjnsaFEB13/baKH29jEFoDUOUZFtsJ+OH7mawyjk?=
 =?us-ascii?Q?7ikoQRHsc09qpumNFjjm9O9weLrBzvZdpQqVIug8usoDTbO+7lFjkYZ+FPcp?=
 =?us-ascii?Q?ET3ZLlzHQWwEYfDBPHe9CZI/qazIrp5LA3Mf+/yK4CGm7AuV8yXhWJD4fLxN?=
 =?us-ascii?Q?YtdAdrBYUBE+3BbgR7Crnpf7Y9cEK3j0mwZGM89GXQDBGJD1E86/JH54i5XE?=
 =?us-ascii?Q?cZ4xEFb6utOymFkHddzflvipFg9TPjjHfs8uXqA89vlFSqdk/lA5ZP2OLpnn?=
 =?us-ascii?Q?lxZXTIXx3eCbxZJ0JrJtqUkv26Zc1tiQApE+HSSw9IKNj6KEoh/sKu5c/Nro?=
 =?us-ascii?Q?FYleASEJUYuKYGLTtL3xwV5LKMMgf6RA44NkA1zmENR+lwi/xu2R5o/WpT1R?=
 =?us-ascii?Q?caT7XlgqC2sSPFSPZcxJ1CxUHhAqJvjfwoQyzAkbCidrHwvkncYid04e1tuO?=
 =?us-ascii?Q?+PMYAQuukiFc9e1WSfXUoERsDXNRvQiUAzqIbRctXy5ou+o0QuTx6AEDpLdH?=
 =?us-ascii?Q?DrZzheNVw6zrs4eoCL90C9IoiBM3pZ2cs+nGFJOtnay44EzvqcorpySC8bAi?=
 =?us-ascii?Q?jj8qXb5IhgLIgI5qjpvTq2l9hCPKdBU5M9LrkFuiNs0J86NabhoxeMVd/ECM?=
 =?us-ascii?Q?vk1U70lStWUoNQ/u1/fB4amlCzHK0APoj6RQh9LAI0hipeBmlJzoBgGIn59A?=
 =?us-ascii?Q?bQAk75BxHXUTzZ3cmaMmA2Ko81pzCp1+cwmxfCaarB70NeEu4O2eZC7ohZfS?=
 =?us-ascii?Q?kLbU2cONuiP5yR6o+tJbZtoIuRK5HiOPoJFEC8ZifDmnUefY5/zNvLtVB6hn?=
 =?us-ascii?Q?UVbqQWC2GajLVomBD5/RFiEwpLDb/BefYUsF/89XZSyR/Vrt0YKRlx4IxzjW?=
 =?us-ascii?Q?jwAI+rTBAB0LXMTS8RCtU/XyraiXIXqwrgoct98mOEe4R77T2M23BqlXPeM1?=
 =?us-ascii?Q?WcPh8ECHAD9871nKFccHYLsYRRy3XqsKRnSRLzyS89Abzawyh/acyZDy2HCd?=
 =?us-ascii?Q?HM6N/tGYN/c7q23Y5r5c9sLKJthTQYZqTFpmW+8h5vy4HWmvbU4VXzeu0ch8?=
 =?us-ascii?Q?NZ5gQnY7M9riPJ44QNSAxt8+ttXCiLGFO+q2+DKZNgfeZp8HSkPDlcJRICbq?=
 =?us-ascii?Q?XQ5e0ZF2T9a7Zf+I0W8p5L7ryMr/svTAKzGuO4LYqWyD3Vh4rYtgYIpLQlGy?=
 =?us-ascii?Q?z2TBj43GvwVtXc8hGm+XlVcCDsDB690+ylTBt53ZhEHQe/B0gCzgAj5d8jeQ?=
 =?us-ascii?Q?CNfc90FXkn9t+GjMjc6q0UxRq4BV8FZ3VpPeKzi22Qe5WkTfxE/ySBSFnUn7?=
 =?us-ascii?Q?LJu/xqaA5KUl3a/Ah5ZlEo+16xStylTPDsRU1YckYoyN9ucnqc1lMDJeLmOs?=
 =?us-ascii?Q?udCFnD71eQIKdgBCcwSRkDyPoFaJlYmtuDGF4XTu4iPjcRXf3reWDB4UvB6l?=
 =?us-ascii?Q?x15Pmw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 663782a0-aa35-47a6-eac6-08db1f29c2e3
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 16:34:02.8613
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X/v4+VBonFR22xDMQrfU3RAYoPrI+o7LE9x3Hp6g43hV3dxmM1wR/BYW11ssqhWr4D/o6KBGIyG5X4l1ZL5F/q19RwR3bPXjSe2yCHpL2TE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB4151
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 07, 2023 at 12:21:03PM +0100, Daniel Machon wrote:
> Fix deletion of existing DSCP mappings in the APP table.
> 
> Adding and deleting DSCP entries are replicated per-port, since the
> mapping table is global for all ports in the chip. Whenever a mapping
> for a DSCP value already exists, the old mapping is deleted first.
> However, it is only deleted for the specified port. Fix this by calling
> sparx5_dcb_ieee_delapp() instead of dcb_ieee_delapp() as it ought to be.
> 
> Reproduce:
> 
> // Map and remap DSCP value 63
> $ dcb app add dev eth0 dscp-prio 63:1
> $ dcb app add dev eth0 dscp-prio 63:2
> 
> $ dcb app show dev eth0 dscp-prio
> dscp-prio 63:2
> 
> $ dcb app show dev eth1 dscp-prio
> dscp-prio 63:1 63:2 <-- 63:1 should not be there
> 
> Fixes: 8dcf69a64118 ("net: microchip: sparx5: add support for offloading dscp table")
> Signed-off-by: Daniel Machon <daniel.machon@microchip.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>