Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5908C6FD1A for ; Tue, 7 Mar 2023 16:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229794AbjCGQ6W (ORCPT ); Tue, 7 Mar 2023 11:58:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230367AbjCGQ5q (ORCPT ); Tue, 7 Mar 2023 11:57:46 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E62BF222DB; Tue, 7 Mar 2023 08:53:56 -0800 (PST) Received: from [192.168.10.12] (unknown [39.45.145.7]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 56E156602EC7; Tue, 7 Mar 2023 16:53:52 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678208034; bh=iDRLwy+I9K1uAgspVj4Ndxr8weBRivPlro3rl0BqmeE=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=Zvs4d7EE8Pxee98prvgIB8JHuFRCHGzpwDbvzQwL5TNlvktQMX46BxF36m+KarELz PT/UXxYFHg2lDDT0ef9yleXFHzxZnqqF7u/0JcbboB8j56cr35x8PF8b1Ryh0O7H3u 2/VYY2qgds+wwXlVzKLr6blior23BAnm5NyGwV3SrN2ESKwqNbOW9A3F4PlIdl9qED iIfmM8xYcrz/GWoB13rta+4k5Zzpi3Isg6EJtw6bc/ewkouRWT76xrBJm8trCPNnCl MZ7SU/D/HGnhx3suQ5TX2AJb/B1YfTtMEM2tmpOlrMMgttJ8GnlLkhp+S910TObUjV JHoH53NfoBuow== Message-ID: <1107bc10-9b14-98f4-3e47-f87188453ce7@collabora.com> Date: Tue, 7 Mar 2023 21:53:48 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Cc: Muhammad Usama Anjum , Jakub Kicinski , Ariel Elior , Manish Chopra , "David S. Miller" , Eric Dumazet , Paolo Abeni , kernel@collabora.com, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] qede: remove linux/version.h and linux/compiler.h Content-Language: en-US To: Simon Horman References: <20230303185351.2825900-1-usama.anjum@collabora.com> <20230303155436.213ee2c0@kernel.org> From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/7/23 9:38 PM, Simon Horman wrote: > On Tue, Mar 07, 2023 at 06:39:20PM +0500, Muhammad Usama Anjum wrote: >> On 3/4/23 4:54 AM, Jakub Kicinski wrote: >>> On Fri, 3 Mar 2023 23:53:50 +0500 Muhammad Usama Anjum wrote: >>>> make versioncheck reports the following: >>>> ./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed. >>>> ./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed. >>>> >>>> So remove linux/version.h from both of these files. Also remove >>>> linux/compiler.h while at it as it is also not being used. >>>> >>>> Signed-off-by: Muhammad Usama Anjum >>> >>> # Form letter - net-next is closed >>> >>> The merge window for v6.3 has begun and therefore net-next is closed >>> for new drivers, features, code refactoring and optimizations. >>> We are currently accepting bug fixes only. >>> >>> Please repost when net-next reopens after Mar 6th. >> It is Mar 7th. Please review. > > I think that the way it works is that you need to repost the patch. > Probably with REPOST in the subject if it is unchanged:Sorry, I didn't know. I'll repost it. > > Subject: [PATCH net-next repost v2] ... > > Or bumped to v3 if there are changes. > > Subject: [PATCH net-next v3] ... > > Also, as per the examples above, the target tree, in this case > 'net-next' should be included in the subject. I don't know much about net tree and its location. This is why people use linux-next for sending patches. I'm not sure about the networking sub system. Would it be accepted if I send it against linux-next as in [PATCH linux-next repost v2]? -- BR, Muhammad Usama Anjum