MIME-Version: 1.0
References: <20230307140522.2311461-1-ardb@kernel.org> <20230307140522.2311461-7-ardb@kernel.org>
 <448139c7-bef0-3ddc-388c-db793a37d55e@arm.com>
In-Reply-To: <448139c7-bef0-3ddc-388c-db793a37d55e@arm.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Tue, 7 Mar 2023 18:01:22 +0100
Message-ID: <CAMj1kXHaFea17OTXT6xEN+xOsmwQMjFs=he5z8OcJNtVM=cnBw@mail.gmail.com>
Subject: Re: [PATCH v3 06/60] arm64: ptdump: Allow VMALLOC_END to be defined
 at boot
To:     Ryan Roberts <ryan.roberts@arm.com>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Kees Cook <keescook@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 7 Mar 2023 at 17:58, Ryan Roberts <ryan.roberts@arm.com> wrote:
>
> On 07/03/2023 14:04, Ard Biesheuvel wrote:
> > Extend the existing pattern for populating ptdump marker entries at
> > boot, and add handling of VMALLOC_END, which will cease to be a compile
> > time constant for configurations that support 52-bit virtual addressing.
> >
> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > ---
> >  arch/arm64/mm/ptdump.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/mm/ptdump.c b/arch/arm64/mm/ptdump.c
> > index 76d28056bd14920a..910b35f02280cbdb 100644
> > --- a/arch/arm64/mm/ptdump.c
> > +++ b/arch/arm64/mm/ptdump.c
> > @@ -31,7 +31,12 @@ enum address_markers_idx {
> >       PAGE_END_NR,
> >  #if defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS)
> >       KASAN_START_NR,
> > +     KASAN_END_NR,
> >  #endif
> > +     MODULES_NR,
> > +     MODULES_END_NR,
> > +     VMALLOC_START_NR,
> > +     VMALLOC_END_NR,
> >  };
> >
> >  static struct addr_marker address_markers[] = {
> > @@ -44,7 +49,7 @@ static struct addr_marker address_markers[] = {
> >       { MODULES_VADDR,                "Modules start" },
> >       { MODULES_END,                  "Modules end" },
> >       { VMALLOC_START,                "vmalloc() area" },
> > -     { VMALLOC_END,                  "vmalloc() end" },
> > +     { 0,                            "vmalloc() end" },
> >       { VMEMMAP_START,                "vmemmap start" },
> >       { VMEMMAP_START + VMEMMAP_SIZE, "vmemmap end" },
> >       { PCI_IO_START,                 "PCI I/O start" },
>
> With all the VA layout changes, and the addition of 52-bit PA/VA for 4KB and
> 16KB pages, Documentation/arm64/memory.rst now looks very wrong. Suggest
> updating it to reflect reality?
>

Yeah good point. And I don't think we necessarily have to describe
every imaginable combo exhaustively.