Message-ID: <8a90dca3-af66-5348-72b9-ac49610f22ce@intel.com>
Date:   Tue, 7 Mar 2023 18:13:16 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2] qede: remove linux/version.h and linux/compiler.h
Content-Language: en-US
To:     Muhammad Usama Anjum <usama.anjum@collabora.com>
CC:     Simon Horman <simon.horman@corigine.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Ariel Elior <aelior@marvell.com>,
        Manish Chopra <manishc@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, <kernel@collabora.com>,
        <kernel-janitors@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230303185351.2825900-1-usama.anjum@collabora.com>
 <20230303155436.213ee2c0@kernel.org>
 <df8a446a-e8a9-3b3d-fd0f-791f0d01a0c9@collabora.com>
 <ZAdoivY94Y5dfOa4@corigine.com>
 <1107bc10-9b14-98f4-3e47-f87188453ce7@collabora.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <1107bc10-9b14-98f4-3e47-f87188453ce7@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?STRVcmNsdGJlU3NIOTl5b1N1WEwvL1dwR3JqbUJ4dTFnWHJGMnhvdEppd0tn?=
 =?utf-8?B?dEZ1RGxhclNONVdMcnAwT1Vvc1E2RENqMms2WENIcmF3QXZnNjh5NGVGeGlU?=
 =?utf-8?B?Wm05NzFvZHE1aHV3bjg5S1dVUDBRUlBja3JqNzZQd3ArSE5zVXFHNEt1d05Z?=
 =?utf-8?B?WkZsY3ErUnZHNFFBY3l2Z0VXWkRJb3pVR1ZhR21GK2kxUUV1bm0xMU5UVjRS?=
 =?utf-8?B?WEgvVHlHd0VSVlpLSHNjQW1uVkpMSmhqNzRwSnV3Yy9xeWVuUE84RjdMbFhO?=
 =?utf-8?B?ZGdrZ2dueGdDcmx5MzNQNzJ2clgwRG1kNllIdGdHbWM5SjEzd1dMWHBDaUhu?=
 =?utf-8?B?bnpQWCtxK3JRZG55TzNMc0poNE5wMEtiMVFBZE1JQ015RVhCaUFQbnNjUmpX?=
 =?utf-8?B?eVVQQkxoNWRSeEtuNjRJUWVKUWJ2VDBSOWhVb25hZEFHUWFmUmJyd2o0cGJF?=
 =?utf-8?B?eGZCVW1lUUdCcjl1VFZVVkZyZVZZMHBlbHN4YURuZlJLUTgxSEx6L0d0aytB?=
 =?utf-8?B?a28wMjN0RHowSXhXbE9aWnMvdVRuWDhrT0lGTzByVGFNQXRlNHR2U280Qi9U?=
 =?utf-8?B?V20vN3lCUXdTZWFmSmxCeHZPYUI2aGZzek9lOU5jZC9MSngvMk1iTk5XamFN?=
 =?utf-8?B?eE5HTmlyYmpadWQ5RDR0aVRqNmthTndHQVpYa1BnSmVULzA5YW1ldloxZ0V5?=
 =?utf-8?B?bmlpWFY1KzBjU0dOSk1BamNPRXZ3UEp1RnIzNjVUYldvYnRIVENaUXlkbHNL?=
 =?utf-8?B?Mk1XME9MTG1tZHBadEs0QU5yUkxPQXdrS0R5SEdld0VnQmZldlEvcmFvVGsr?=
 =?utf-8?B?Y25LZW5DZVlnVktZc1RjNlFnQmJVNmRLOHVSdFBPcS9Ed1lTUEIrZUNHSmtM?=
 =?utf-8?B?N3E2WWhxdFphRjRhdHFRVU1HS3pxS0FHMGIySFNNYjJmQzQ4cVNQaUdmclpH?=
 =?utf-8?B?TnRyNFNLb3A5M2dBaEtIUGFvSkZ1aEZoUnNMQ1YvVTIxYVNoaGZLaDFDNWhY?=
 =?utf-8?B?RkdVZ0VlUTd6bjFOTjhnUGdmcHVsaWFxVUVSYTJhV0xwc2cwNWQxVnc3Rk0x?=
 =?utf-8?B?cnJOUkkrZVVlNVRWSm04bU80aUx4RzBsWnB2ZTV4Y3NFQmVhNnM3ak9veTFY?=
 =?utf-8?B?c2dOTUVxVXIzcHlaL0ExNWxHM0FyWFZIR0hyNkwzT3NVSHVQdTd2UVNaSkJG?=
 =?utf-8?B?dmRvQ1laTjRSOHh3MVgvdWZySkhMQjZyUFhaNWtjcGpmcCtxWGRpMUlsei85?=
 =?utf-8?B?dTRxa2dld1UrUzMwaGVGdEl2OUl3MFJ6ZWR5eE9OYmlUL3VYZDZ1UUF4WHIw?=
 =?utf-8?B?RHE5Yy9Ic3dhbkp5Q2RUYzl6TURLK2NkVXFhTGJEMkdYNnFxcVEyaGlRaEJ4?=
 =?utf-8?B?S012SlozNmdYMGlyd3QraVJwTmUwMUVDdG9mbGxxV0VsYkJETzRvSUxHQlpR?=
 =?utf-8?B?SXdUYmdGK0MvS2hqckdsbm84bjVpVCt0WTl4NkZienFCL1lOVi9RcWZHbXNw?=
 =?utf-8?B?MlFaaDVGcnB4ckdPOVRyeGVCRVdCeXlaTGFjK2Rwak80MkJmTFY1Y3lLTldk?=
 =?utf-8?B?dmFLa09PWlZPaW5ydUN5VkxLMW5CNlZFZkZxbWlzenJRVllxRk1tU0JrNWto?=
 =?utf-8?B?T1VCaTkwUzNsQ3V1eVIyVm1FOGRXK1Z1NytEdmlSdnRjV0ZacXBob0tFUkU5?=
 =?utf-8?B?YStnY3pPTVdoOVFBUVRQd0p3NWtMSWQxM2hsc3lmWU41MHMvTUtnRTZuKzRv?=
 =?utf-8?B?ek5xZzNEQnBRSXpGRHRiR1V2MVhrR3NhM3czVklwc25VbDdaV1ZIeVhtNHpW?=
 =?utf-8?B?NzRkZWhoNDFxTWpuc2g0alNRN1ZzWmJneml3cnd2N2lzTXVjeWR3THZFN3Rm?=
 =?utf-8?B?UVQ5ZXRWakx2a3F3NjJJczB2VFR4eFF2NG9qQzB0TUg0TVl2ZlJaVG1NNWQv?=
 =?utf-8?B?WU5GaDc2bEExSWhiMXAyWlJIYUVNL1dvMVZFNEdzY1BCOUN2SnpjQStKRk5a?=
 =?utf-8?B?R1ZmeTRud04zckp4NkVNYkZXbXY2aGFVSWlUWktuZ0NNM1JlSS9YdUpzOWRG?=
 =?utf-8?B?ZXpYaGdRNW9oMitlTDgrZkRBNXRaRGplZWw5blRnRS8yUkZPOUNRSmNOYnFU?=
 =?utf-8?B?a3FwOGNXMUN4bDNLeThldXdpdEtMMHEybVpFVkp6TG5WRnhhcnl4ZUExQ2Yw?=
 =?utf-8?Q?zq7rY9OA0BYOJRaux2DVBD0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4efdddc1-5e07-4cb7-540a-08db1f2f5b27
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 17:14:06.3472
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Pkvy3D+UK5jYlkzdibn2kwNbpiqy6qGcc7Rd9rJoQNoUuMmF8T5ZBcuXL6Stk/ilZ7yo1RKdA7+hJNLM9xSoNcnXf581Vfc6QegTATXd2c0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6888
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Muhammad Usama Anjum <usama.anjum@collabora.com>
Date: Tue, 7 Mar 2023 21:53:48 +0500

> On 3/7/23 9:38 PM, Simon Horman wrote:
>> On Tue, Mar 07, 2023 at 06:39:20PM +0500, Muhammad Usama Anjum wrote:
>>> On 3/4/23 4:54 AM, Jakub Kicinski wrote:
>>>> On Fri,  3 Mar 2023 23:53:50 +0500 Muhammad Usama Anjum wrote:
>>>>> make versioncheck reports the following:
>>>>> ./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed.
>>>>> ./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed.
>>>>>
>>>>> So remove linux/version.h from both of these files. Also remove
>>>>> linux/compiler.h while at it as it is also not being used.
>>>>>
>>>>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>>>>
>>>> # Form letter - net-next is closed
>>>>
>>>> The merge window for v6.3 has begun and therefore net-next is closed
>>>> for new drivers, features, code refactoring and optimizations.
>>>> We are currently accepting bug fixes only.
>>>>
>>>> Please repost when net-next reopens after Mar 6th.
>>> It is Mar 7th. Please review.
>>
>> I think that the way it works is that you need to repost the patch.
>> Probably with REPOST in the subject if it is unchanged:Sorry, I didn't know. I'll repost it.
> 
>>
>> Subject: [PATCH net-next repost v2] ...
>>
>> Or bumped to v3 if there are changes.
>>
>> Subject: [PATCH net-next v3] ...
>>
>> Also, as per the examples above, the target tree, in this case
>> 'net-next' should be included in the subject.
> I don't know much about net tree and its location. This is why people use

Here[0].

> linux-next for sending patches. I'm not sure about the networking sub

No, people use the corresponding mailing lists to send and repositories
to base their patches on.

> system. Would it be accepted if I send it against linux-next as in [PATCH
> linux-next repost v2]?

No. Please use net-next I provided above. Your subject prefix will be

[PATCH net-next v3]

since you'll have changes (specifying the correct tree).
You can ask git-format-patch to generate it automatically via

`git format-patch --subject-prefix='PATCH net-next' -v3 ...`

> 
> 

One more note: I was participating in reviewing/discussing your first
patch version, so please add all the participants to --cc when you send
next versions. For this particular patch it means Jakub, Simon and me
must be specified explicitly in --cc when you send v3.

[0] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/

Thanks,
Olek