Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73563C678D5 for ; Tue, 7 Mar 2023 17:49:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232255AbjCGRtq (ORCPT ); Tue, 7 Mar 2023 12:49:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231933AbjCGRtV (ORCPT ); Tue, 7 Mar 2023 12:49:21 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45E5BA18AB; Tue, 7 Mar 2023 09:44:08 -0800 (PST) X-IronPort-AV: E=McAfee;i="6500,9779,10642"; a="400741844" X-IronPort-AV: E=Sophos;i="5.98,241,1673942400"; d="scan'208";a="400741844" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2023 09:44:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10642"; a="709142959" X-IronPort-AV: E=Sophos;i="5.98,241,1673942400"; d="scan'208";a="709142959" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 07 Mar 2023 09:44:06 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pZbM4-00H2UM-1T; Tue, 07 Mar 2023 19:44:04 +0200 Date: Tue, 7 Mar 2023 19:44:04 +0200 From: Andy Shevchenko To: Andrew Davis Cc: Peter Tyser , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] gpio: pisosr: Use devm_gpiochip_add_data() to simplify remove path Message-ID: References: <20230307165432.25484-1-afd@ti.com> <20230307165432.25484-4-afd@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230307165432.25484-4-afd@ti.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 07, 2023 at 10:54:30AM -0600, Andrew Davis wrote: > Use devm version of gpiochip add function to handle removal for us. > > While here update copyright and module author. ... > - mutex_destroy(&gpio->lock); You need to wrap this into devm. -- With Best Regards, Andy Shevchenko